This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Move completion signatures and labelDetails

Authored by sammccall on May 23 2023, 1:40 PM.



(When clients support it, otherwise keep the existing rendering).

In VSCode this makes the signature darker.

Diff Detail

Event Timeline

sammccall created this revision.May 23 2023, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2023, 1:40 PM
sammccall requested review of this revision.May 23 2023, 1:40 PM

Looks like this:

Hmm, having looked at that screenshot more, the bullets are not rendered properly on some lines...

sammccall updated this revision to Diff 525517.May 25 2023, 3:05 AM
sammccall retitled this revision from [clangd] Move completion signatures and insertion markers into labelDetails to [clangd] Move completion signatures and labelDetails.
sammccall edited the summary of this revision. (Show Details)

revert change to insertion bullets: no consensus, and some rendering issues in vscode

hokein accepted this revision.May 25 2023, 10:17 AM
This revision is now accepted and ready to land.May 25 2023, 10:17 AM
This revision was landed with ongoing or failed builds.Jun 5 2023, 9:08 AM
This revision was automatically updated to reflect the committed changes.