Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D151253

[clangd] Move completion signatures and labelDetails
ClosedPublic
Actions

Authored by sammccall on May 23 2023, 1:40 PM.

Details

Reviewers
hokein
Commits
rG3f9f1463719d: [clangd] Move completion signatures and labelDetails
Summary

(When clients support it, otherwise keep the existing rendering).

In VSCode this makes the signature darker.

Diff Detail

Event Timeline

sammccall created this revision.May 23 2023, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2023, 1:40 PM
Herald added subscribers: kadircet, arphaman. · View Herald Transcript
sammccall requested review of this revision.May 23 2023, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2023, 1:40 PM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
sammccall added a comment.May 23 2023, 1:40 PM

Looks like this:

sammccall added a comment.May 23 2023, 1:42 PM

Hmm, having looked at that screenshot more, the bullets are not rendered properly on some lines...

Harbormaster completed remote builds in B233970: Diff 524865.May 23 2023, 2:44 PM
sammccall updated this revision to Diff 525517.May 25 2023, 3:05 AM
sammccall retitled this revision from [clangd] Move completion signatures and insertion markers into labelDetails to [clangd] Move completion signatures and labelDetails.
sammccall edited the summary of this revision. (Show Details)

revert change to insertion bullets: no consensus, and some rendering issues in vscode

Harbormaster completed remote builds in B234443: Diff 525517.May 25 2023, 3:17 AM
hokein accepted this revision.May 25 2023, 10:17 AM
This revision is now accepted and ready to land.May 25 2023, 10:17 AM
This revision was landed with ongoing or failed builds.Jun 5 2023, 9:08 AM
Closed by commit rG3f9f1463719d: [clangd] Move completion signatures and labelDetails (authored by sammccall). · Explain Why
This revision was automatically updated to reflect the committed changes.
sammccall added a commit: rG3f9f1463719d: [clangd] Move completion signatures and labelDetails.

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clangd/
2 lines
3 lines
6 lines
25 lines
23 lines
unittests/
9 lines

Diff 528473

View Options

clang-tools-extra/clangd/ClangdLSPServer.h

Loading...
View Options

clang-tools-extra/clangd/ClangdLSPServer.cpp

Loading...
View Options

clang-tools-extra/clangd/CodeComplete.cpp

Loading...
View Options

clang-tools-extra/clangd/Protocol.h

Loading...
View Options

clang-tools-extra/clangd/Protocol.cpp

Loading...
View Options

clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

Loading...