This is an archive of the discontinued LLVM Phabricator instance.

[flang][hlfir] Support rank mismatch with IGNORE_TKR(R).
ClosedPublic

Authored by vzakhari on May 19 2023, 9:20 PM.

Details

Summary

Reboxing of the actual argument according to the type of the dummy
argument has to be aware of the potential rank mismatch, when
IGNORE_TKR(R) is used. This change only adds support for the mismatching
rank when the dummy argument has unlimited polymorphic type.

Diff Detail

Event Timeline

vzakhari created this revision.May 19 2023, 9:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2023, 9:20 PM
vzakhari requested review of this revision.May 19 2023, 9:20 PM
tschuett added inline comments.
flang/lib/Lower/ConvertCall.cpp
978

Can it miscompile in release mode?

vzakhari added inline comments.May 21 2023, 6:09 PM
flang/lib/Lower/ConvertCall.cpp
978

Yes, it can. Thanks for the catch! I think DIE should be better here.

vzakhari updated this revision to Diff 524143.May 21 2023, 6:09 PM
jeanPerier accepted this revision.May 21 2023, 11:55 PM

Looks great, thanks!

This revision is now accepted and ready to land.May 21 2023, 11:55 PM
This revision was automatically updated to reflect the committed changes.