This is an archive of the discontinued LLVM Phabricator instance.

[clang][Darwin] Error out when missing requested libarclite library
ClosedPublic

Authored by keith on May 19 2023, 12:32 PM.

Details

Summary

Starting with the SDKs provided with Xcode 14.3, this library no longer
exists. Before this change this results in an opaque linker error in the
case that your deployment target is low enough that this library is
added. This produces a more useful error message in that case.

Diff Detail

Event Timeline

keith created this revision.May 19 2023, 12:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2023, 12:32 PM
keith requested review of this revision.May 19 2023, 12:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2023, 12:32 PM
keith updated this revision to Diff 523899.May 19 2023, 12:39 PM

Improve test

Adding 1 more test chage.

Rebasing to main.

ravikandhadai added inline comments.May 31 2023, 6:50 PM
clang/include/clang/Basic/DiagnosticDriverKinds.td
623

To be consistent with other error messages, it would better to rephrase as
"SDK does not contain 'libarclite' at the path '%0'; try increasing the minimum deployment target"

keith updated this revision to Diff 527261.May 31 2023, 6:57 PM

Improve error message

This revision is now accepted and ready to land.Jun 1 2023, 7:37 AM