Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People fahadnayyar

fahadnayyar (Fahad Nayyar)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 21 2022, 6:38 AM (43 w, 6 d)

Recent Activity
View All

Jun 1 2023

fahadnayyar updated the diff for D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.

Edits in comments.

Jun 1 2023, 1:37 PM · Unknown Object (Project), Unknown Object (Project), Restricted Project
fahadnayyar added inline comments to D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.
Jun 1 2023, 11:07 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project
fahadnayyar updated the diff for D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.

Simplifying the test case.

Jun 1 2023, 11:05 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project
fahadnayyar added a reviewer for D150988: [clang][Darwin] Error out when missing requested libarclite library: egorzhdan.
Jun 1 2023, 7:37 AM · Unknown Object (Project), Restricted Project
fahadnayyar accepted D150988: [clang][Darwin] Error out when missing requested libarclite library.

LGTM

Jun 1 2023, 7:37 AM · Unknown Object (Project), Restricted Project
fahadnayyar updated the diff for D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.

Rebasing to latest main.

Jun 1 2023, 7:10 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project

May 31 2023

fahadnayyar updated the diff for D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.

Passing -L <toolchain-install>/bin/../lib/ unconditionally to the linker.

May 31 2023, 5:07 PM · Unknown Object (Project), Unknown Object (Project), Restricted Project

May 30 2023

fahadnayyar added reviewers for D150988: [clang][Darwin] Error out when missing requested libarclite library: ahatanak, ravikandhadai.
May 30 2023, 4:46 PM · Unknown Object (Project), Restricted Project
fahadnayyar updated the diff for D150988: [clang][Darwin] Error out when missing requested libarclite library.

Rebasing to main.

May 30 2023, 6:48 AM · Unknown Object (Project), Restricted Project

May 25 2023

fahadnayyar added reviewers for D150988: [clang][Darwin] Error out when missing requested libarclite library: fahadnayyar, arphaman.
May 25 2023, 2:07 PM · Unknown Object (Project), Restricted Project
fahadnayyar updated the diff for D150988: [clang][Darwin] Error out when missing requested libarclite library.

Adding 1 more test chage.

May 25 2023, 2:06 PM · Unknown Object (Project), Restricted Project

Apr 18 2023

fahadnayyar updated the diff for D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.

Fixing some more regression test errors.

Apr 18 2023, 11:26 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project

Apr 17 2023

fahadnayyar updated the diff for D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.

Fixed regression error in clang-tidy test.

Apr 17 2023, 2:11 PM · Unknown Object (Project), Unknown Object (Project), Restricted Project
fahadnayyar added inline comments to D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.
Apr 17 2023, 7:49 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project

Apr 16 2023

fahadnayyar updated the diff for D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.

Added test case. Now checking the existence of libc++ headers in the toolchain when including the libc++.dylib form toolchain and vice versa. Also checking the absence of -nostdinc, -nostdinc++ or -nostdlib
arguments before linking with libc++.dylib from the toolchain.

Apr 16 2023, 11:07 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project

Apr 14 2023

fahadnayyar updated the summary of D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.
Apr 14 2023, 10:45 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project

Apr 13 2023

fahadnayyar added a reviewer for D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang: fdeazeve.
Apr 13 2023, 1:31 PM · Unknown Object (Project), Unknown Object (Project), Restricted Project
fahadnayyar added reviewers for D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang: ldionne, ahatanak, egorzhdan.
Apr 13 2023, 1:09 PM · Unknown Object (Project), Unknown Object (Project), Restricted Project
fahadnayyar requested review of D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.
Apr 13 2023, 1:06 PM · Unknown Object (Project), Unknown Object (Project), Restricted Project

Jan 20 2023

fahadnayyar committed rG5e5d901feb3c: [Clang] [Sema] Removed a fix-it for system headers (authored by fahadnayyar).
[Clang] [Sema] Removed a fix-it for system headers
Jan 20 2023, 1:30 PM · Unknown Object (Project), Restricted Project
fahadnayyar closed D141868: [Clang] [Sema] Removed a fix-it for system headers.
Jan 20 2023, 1:29 PM · Unknown Object (Project), Restricted Project

Jan 19 2023

fahadnayyar added a comment to D141868: [Clang] [Sema] Removed a fix-it for system headers.
In D141868#4060757, @NoQ wrote:

Looks great! Sounds like you're looking for a more permanent fix, I guess ConversionFixItGenerator could try to avoid adding fixits to system header functions?

Jan 19 2023, 11:45 AM · Unknown Object (Project), Restricted Project
fahadnayyar updated the diff for D141868: [Clang] [Sema] Removed a fix-it for system headers.

Added release notes and changed a normal for-loop to range-based for-loop.

Jan 19 2023, 11:39 AM · Unknown Object (Project), Restricted Project

Jan 18 2023

fahadnayyar added a reviewer for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.: shafik.
Jan 18 2023, 8:20 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jan 17 2023

fahadnayyar added a comment to D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..

@aaron.ballman do you think that we should call `CheckImplicitConversion``` only for arithemetic compound assignment operators like +=, -=, /=, *= and %= ?

Jan 17 2023, 9:57 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar added a reviewer for D141868: [Clang] [Sema] Removed a fix-it for system headers: ravikandhadai.
Jan 17 2023, 9:06 AM · Unknown Object (Project), Restricted Project
fahadnayyar added a reviewer for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.: ravikandhadai.
Jan 17 2023, 8:40 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar added a reviewer for D141868: [Clang] [Sema] Removed a fix-it for system headers: NoQ.
Jan 17 2023, 7:16 AM · Unknown Object (Project), Restricted Project

Jan 16 2023

fahadnayyar added reviewers for D141868: [Clang] [Sema] Removed a fix-it for system headers: egorzhdan, ahatanak, aaron.ballman.
Jan 16 2023, 11:48 AM · Unknown Object (Project), Restricted Project
fahadnayyar requested review of D141868: [Clang] [Sema] Removed a fix-it for system headers.
Jan 16 2023, 11:46 AM · Unknown Object (Project), Restricted Project

Jan 13 2023

fahadnayyar committed rG4c37671a7c94: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment… (authored by fahadnayyar).
[Clang][Sema] Enabled implicit conversion warning for CompoundAssignment…
Jan 13 2023, 8:05 AM · Unknown Object (Project), Restricted Project
fahadnayyar closed D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..
Jan 13 2023, 8:05 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar committed rG226798f3aa2f: [libunwind] Fixed an upcoming clang -Wsign-conversion warning (authored by fahadnayyar).
[libunwind] Fixed an upcoming clang -Wsign-conversion warning
Jan 13 2023, 8:03 AM · Restricted Project
fahadnayyar closed D141515: [libunwind] Fixed an upcoming clang -Wsign-conversion warning.
Jan 13 2023, 8:02 AM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

fahadnayyar updated the diff for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..

Refactoring.

Jan 12 2023, 6:08 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar updated the diff for D141515: [libunwind] Fixed an upcoming clang -Wsign-conversion warning.

Correction.

Jan 12 2023, 5:28 AM · Restricted Project, Restricted Project, Restricted Project
fahadnayyar updated the diff for D141515: [libunwind] Fixed an upcoming clang -Wsign-conversion warning.

Removed space.

Jan 12 2023, 5:26 AM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2023

fahadnayyar added a comment to D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..

Moved the libunwind change to this separate patch: https://reviews.llvm.org/D141515

Jan 11 2023, 9:08 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar added a reviewer for D141515: [libunwind] Fixed an upcoming clang -Wsign-conversion warning: • maskray0.
Jan 11 2023, 9:07 AM · Restricted Project, Restricted Project, Restricted Project
fahadnayyar requested review of D141515: [libunwind] Fixed an upcoming clang -Wsign-conversion warning.
Jan 11 2023, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
fahadnayyar removed a reviewer for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.: Restricted Project.
Jan 11 2023, 8:56 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar updated the diff for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..

Moving the libunwind change to a separate patch and some refactoring.

Jan 11 2023, 8:53 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jan 10 2023

fahadnayyar updated the diff for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..

Rebasing on main.

Jan 10 2023, 12:46 PM · Restricted Project, Unknown Object (Project), Restricted Project

Jan 6 2023

fahadnayyar added inline comments to D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..
Jan 6 2023, 10:55 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar retitled D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator. from [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator. to [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator. .
Jan 6 2023, 10:42 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar updated the diff for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..

Added summary in clang release notes.

Jan 6 2023, 10:38 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar added a comment to D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..
In D139114#4023456, @aaron.ballman wrote:

It looks like this change breaks libc++ (see the precommit CI failures) by making more changes than expected. I'm now seeing implicit conversion changes signedness diagnostics where we didn't previously get them. Is that expected and intentional? (I think it may be a fix: https://godbolt.org/z/hTaaf8c5P so I'm adding the libc++ folks just in case they disagree.)

Also, these changes should come with an entry in the release notes.

Jan 6 2023, 9:07 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar updated the diff for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..

Fixed libcxx failure and added test case for expected warning for shift assigsn operator.

Jan 6 2023, 9:04 AM · Restricted Project, Unknown Object (Project), Restricted Project

Dec 19 2022

fahadnayyar added inline comments to D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..
Dec 19 2022, 2:20 AM · Restricted Project, Unknown Object (Project), Restricted Project

Dec 12 2022

fahadnayyar updated the diff for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..

Added forward declare for CheckImplicitConversion to make the diff look clean.

Dec 12 2022, 6:33 AM · Restricted Project, Unknown Object (Project), Restricted Project

Dec 2 2022

fahadnayyar updated the diff for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..

Fixing clang-format error.

Dec 2 2022, 7:06 AM · Restricted Project, Unknown Object (Project), Restricted Project

Dec 1 2022

fahadnayyar retitled D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator. from [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator. This change enables Wshorten-64-to-32 waring for compound assignment statements which has implicit conversion of RHS form 64-bit integer type to 32-bit integer type. rdar... to [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator. .
Dec 1 2022, 7:06 AM · Restricted Project, Unknown Object (Project), Restricted Project
fahadnayyar requested review of D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator..
Dec 1 2022, 7:02 AM · Restricted Project, Unknown Object (Project), Restricted Project

Nov 21 2022

fahadnayyar added reviewers for D138434: [Clang][Sema] Added space after ',' in a warning: egorzhdan, ahatanak.
Nov 21 2022, 6:50 AM · Unknown Object (Project), Restricted Project
fahadnayyar requested review of D138434: [Clang][Sema] Added space after ',' in a warning.
Nov 21 2022, 6:49 AM · Unknown Object (Project), Restricted Project