This is an archive of the discontinued LLVM Phabricator instance.

Differential D150626

[Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr test.
ClosedPublic

Authored by raghavendhra on May 15 2023, 4:50 PM.

Details

Reviewers
jdoerfert
TIFitis
kiranchandramohan
kiranktp
raghavendhra
Commits
rG608fe0b032d9: [Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr…
Summary

Missed adding this check in previous commit so adding it through separate commit.

Diff Detail

Event Timeline

raghavendhra created this revision.May 15 2023, 4:50 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 15 2023, 4:50 PM
Herald added subscribers: sunshaoce, guansong, yaxunl. · View Herald Transcript
raghavendhra requested review of this revision.May 15 2023, 4:50 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptMay 15 2023, 4:50 PM
Herald added subscribers: jplehr, sstefan1, jdoerfert. · View Herald Transcript
raghavendhra added reviewers: TIFitis, kiranchandramohan, kiranktp.May 15 2023, 4:52 PM
raghavendhra added a subscriber: dpalermo.
raghavendhra updated this revision to Diff 522391.May 15 2023, 5:09 PM

Rebasing

Harbormaster completed remote builds in B232160: Diff 522391.May 15 2023, 6:36 PM
raghavendhra accepted this revision.May 16 2023, 9:21 AM
This revision is now accepted and ready to land.May 16 2023, 9:21 AM
Closed by commit rG608fe0b032d9: [Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr… (authored by raghavendhra). · Explain WhyMay 16 2023, 10:42 AM
This revision was automatically updated to reflect the committed changes.
raghavendhra added a commit: rG608fe0b032d9: [Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr….

Revision Contents

PathSize
flang/
test/
Semantics/
OpenMP/
2 lines

Diff 522704

flang/test/Semantics/OpenMP/use_device_ptr.f90

! RUN: %flang -fc1 -fopenmp -fdebug-dump-symbols %s | FileCheck %s ! RUN: %flang -fc1 -fopenmp -fdebug-dump-symbols %s | FileCheck %s
! OpenMP Version 5.0 ! OpenMP Version 5.0
! 2.10.1 use_device_ptr clause ! 2.10.1 use_device_ptr clause
! List items that appear in a use_device_ptr clause are converted into device ! List items that appear in a use_device_ptr clause are converted into device
! pointers to the corresponding list item in the device data environment. ! pointers to the corresponding list item in the device data environment.
subroutine omp_target_data subroutine omp_target_data
use iso_c_binding use iso_c_binding
integer :: a(1024) integer :: a(1024)
!CHECK: b size=8 offset=4096: ObjectEntity type: TYPE(c_ptr) !CHECK: b size=8 offset=4096: ObjectEntity type: TYPE(c_ptr)
type(C_PTR) :: b type(C_PTR) :: b
integer, pointer :: arrayB integer, pointer :: arrayB
a = 1 a = 1
!$omp target data map(tofrom: a, arrayB) use_device_ptr(b) !$omp target data map(tofrom: a, arrayB) use_device_ptr(b)
!CHECK: b (OmpUseDevicePtr) !CHECK: b (OmpUseDevicePtr): HostAssoc
allocate(arrayB) allocate(arrayB)
call c_f_pointer(b, arrayB) call c_f_pointer(b, arrayB)
a = arrayB a = arrayB
!$omp end target data !$omp end target data
end subroutine omp_target_data end subroutine omp_target_data