This is an archive of the discontinued LLVM Phabricator instance.

[clang] Convert a few OpenMP tests to use opaque pointers
ClosedPublic

Authored by barannikov88 on May 14 2023, 10:48 AM.

Diff Detail

Event Timeline

barannikov88 created this revision.May 14 2023, 10:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2023, 10:48 AM
barannikov88 requested review of this revision.May 14 2023, 10:48 AM
Herald added a project: Restricted Project. · View Herald Transcript
barannikov88 added inline comments.May 14 2023, 10:51 AM
clang/test/OpenMP/atomic_capture_codegen.cpp
868

Some GEPs like this one have changed the base type and are new missing inbounds keyword, is that OK?

nikic accepted this revision.May 14 2023, 11:49 AM

LGTM

clang/test/OpenMP/atomic_capture_codegen.cpp
868

Yes, this is fine. It's a known weakness in constant folding.

This revision is now accepted and ready to land.May 14 2023, 11:49 AM