This is an archive of the discontinued LLVM Phabricator instance.

[AST] Construct Capture objects before use
ClosedPublic

Authored by vitalybuka on May 12 2023, 6:44 PM.

Details

Summary

Msan reports https://reviews.llvm.org/P8308
The reason is if PointerIntPair is not properly
constructed, setPointer uses Info::updatePointer
on uninitialized value.

Diff Detail

Event Timeline

vitalybuka created this revision.May 12 2023, 6:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2023, 6:44 PM
vitalybuka requested review of this revision.May 12 2023, 6:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2023, 6:44 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
vitalybuka edited the summary of this revision. (Show Details)May 12 2023, 6:44 PM
craig.topper resigned from this revision.May 15 2023, 5:06 PM
vitalybuka added a reviewer: Restricted Project.May 18 2023, 1:16 PM

ping, any concerns regarding this patch?
i want to make MSAN stricter on our bot by reducing -O level

rsmith accepted this revision.May 23 2023, 9:44 PM
This revision is now accepted and ready to land.May 23 2023, 9:44 PM
This revision was automatically updated to reflect the committed changes.