This is an archive of the discontinued LLVM Phabricator instance.

Differential D150232

[mlir][openacc][NFC] Add missing check lines for acc.update tests
ClosedPublic

Authored by clementval on May 9 2023, 4:17 PM.

Details

Reviewers
razvanlupusoru
vzakhari
jeanPerier
nicolasvasilache
Commits
rG647db57cdd08: [mlir][openacc][NFC] Add missing check lines for acc.update tests
Summary

D149909 was missing the check lines in the ops.mlir lit test.

Diff Detail

Event Timeline

clementval created this revision.May 9 2023, 4:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2023, 4:17 PM
Herald added subscribers: bviyer, sunshaoce, Moerafaat and 22 others. · View Herald Transcript
clementval requested review of this revision.May 9 2023, 4:17 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMay 9 2023, 4:17 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B230991: Diff 520856.May 9 2023, 4:34 PM
vzakhari accepted this revision.May 9 2023, 9:50 PM
This revision is now accepted and ready to land.May 9 2023, 9:50 PM
Closed by commit rG647db57cdd08: [mlir][openacc][NFC] Add missing check lines for acc.update tests (authored by clementval). · Explain WhyMay 10 2023, 8:24 AM
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rG647db57cdd08: [mlir][openacc][NFC] Add missing check lines for acc.update tests.

Revision Contents

PathSize
mlir/
test/
Dialect/
OpenACC/
20 lines

Diff 521001

mlir/test/Dialect/OpenACC/ops.mlir

Show First 20 Lines • Show All 1,299 Lines • ▼ Show 20 Lines
// CHECK: [[COPYIN:%.*]] = acc.copyin varPtr([[ARGA]] : memref<10xf32>) -> memref<10xf32> {structured = false} // CHECK: [[COPYIN:%.*]] = acc.copyin varPtr([[ARGA]] : memref<10xf32>) -> memref<10xf32> {structured = false}
// CHECK-NEXT: acc.enter_data dataOperands([[COPYIN]] : memref<10xf32>) // CHECK-NEXT: acc.enter_data dataOperands([[COPYIN]] : memref<10xf32>)
// CHECK: [[DEVPTR:%.*]] = acc.getdeviceptr varPtr([[ARGA]] : memref<10xf32>) -> memref<10xf32> {dataClause = 4 : i64} // CHECK: [[DEVPTR:%.*]] = acc.getdeviceptr varPtr([[ARGA]] : memref<10xf32>) -> memref<10xf32> {dataClause = 4 : i64}
// CHECK-NEXT: acc.exit_data dataOperands([[DEVPTR]] : memref<10xf32>) // CHECK-NEXT: acc.exit_data dataOperands([[DEVPTR]] : memref<10xf32>)
// CHECK-NEXT: acc.copyout accPtr([[DEVPTR]] : memref<10xf32>) to varPtr([[ARGA]] : memref<10xf32>) {structured = false} // CHECK-NEXT: acc.copyout accPtr([[DEVPTR]] : memref<10xf32>) to varPtr([[ARGA]] : memref<10xf32>) {structured = false}
// ----- // -----
func.func @host_device_ops(%a: memref<10xf32>) -> () { func.func @host_device_ops(%a: memref<f32>) -> () {
%devptr = acc.getdeviceptr varPtr(%a : memref<10xf32>) -> memref<10xf32> {dataClause = 16} %devptr = acc.getdeviceptr varPtr(%a : memref<f32>) -> memref<f32> {dataClause = 16}
acc.update_host accPtr(%devptr : memref<10xf32>) to varPtr(%a : memref<10xf32>) {structured = false} acc.update_host accPtr(%devptr : memref<f32>) to varPtr(%a : memref<f32>) {structured = false}
acc.update dataOperands(%devptr : memref<10xf32>) acc.update dataOperands(%devptr : memref<f32>)
%accPtr = acc.update_device varPtr(%a : memref<10xf32>) -> memref<10xf32> %accPtr = acc.update_device varPtr(%a : memref<f32>) -> memref<f32>
acc.update dataOperands(%accPtr : memref<10xf32>) acc.update dataOperands(%accPtr : memref<f32>)
return return
} }
// CHECK-LABEL: func.func @host_device_ops(
// CHECK-SAME: %[[A:.*]]: memref<f32>)
// CHECK: %[[DEVPTR_A:.*]] = acc.getdeviceptr varPtr(%[[A]] : memref<f32>) -> memref<f32>
// CHECK: acc.update_host accPtr(%[[DEVPTR_A]] : memref<f32>) to varPtr(%[[A]] : memref<f32>) {structured = false}
// CHECK: acc.update dataOperands(%[[DEVPTR_A]] : memref<f32>)
// CHECK: %[[DEVPTR_A:.*]] = acc.update_device varPtr(%[[A]] : memref<f32>) -> memref<f32>
// CHECK: acc.update dataOperands(%[[DEVPTR_A]] : memref<f32>)