This is an archive of the discontinued LLVM Phabricator instance.

Differential D150092

[ValueTracking] Add tests for knownbits of `sdiv` and `udiv`; NFC
ClosedPublic

Authored by goldstein.w.n on May 7 2023, 11:57 PM.

Details

Reviewers
foad
nikic
RKSimon
Commits
rG53a079c8f723: [ValueTracking] Add tests for knownbits of `sdiv` and `udiv`; NFC

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

goldstein.w.n created this revision.May 7 2023, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 11:57 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.May 7 2023, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 11:57 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D150093: [KnownBits] Add implementation for `KnownBits::sdiv`.May 8 2023, 12:01 AM
Harbormaster completed remote builds in B230556: Diff 520266.May 8 2023, 12:56 AM
RKSimon added a comment.May 8 2023, 3:56 AM

What are you trying to achieve with these over just relying on the KnownBitsTests unit test coverage?

goldstein.w.n updated this revision to Diff 520561.May 8 2023, 7:54 PM

Rebase

Harbormaster completed remote builds in B230768: Diff 520561.May 8 2023, 8:25 PM
RKSimon accepted this revision.May 13 2023, 4:52 AM

LGTM to unblock D150093

This revision is now accepted and ready to land.May 13 2023, 4:52 AM
goldstein.w.n updated this revision to Diff 521921.May 13 2023, 10:53 AM

Rebase

Harbormaster completed remote builds in B231800: Diff 521921.May 13 2023, 12:32 PM
goldstein.w.n updated this revision to Diff 522357.May 15 2023, 3:27 PM

Rebase

Harbormaster completed remote builds in B232133: Diff 522357.May 15 2023, 5:12 PM
This revision was landed with ongoing or failed builds.May 16 2023, 4:58 PM
Closed by commit rG53a079c8f723: [ValueTracking] Add tests for knownbits of `sdiv` and `udiv`; NFC (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG53a079c8f723: [ValueTracking] Add tests for knownbits of `sdiv` and `udiv`; NFC.

Revision Contents

PathSize
llvm/
test/
Analysis/
ValueTracking/
269 lines

Diff 520266

llvm/test/Analysis/ValueTracking/knownbits-div.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -passes=instsimplify -S < %s | FileCheck %s
define i1 @sdiv_neg_neg_high_bits(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_neg_neg_high_bits(
; CHECK-NEXT: [[NUM:%.*]] = or i8 [[X:%.*]], -128
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[Y:%.*]], -125
; CHECK-NEXT: [[DIV:%.*]] = sdiv i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], -128
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], -128
; CHECK-NEXT: ret i1 [[R]]
;
%num = or i8 %x, 128
%denum = or i8 %y, 131
%div = sdiv i8 %num, %denum
%and = and i8 %div, 128
%r = icmp eq i8 %and, 128
ret i1 %r
}
define i1 @sdiv_pos_neg_high_bits(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_pos_neg_high_bits(
; CHECK-NEXT: [[XX:%.*]] = and i8 [[X:%.*]], 127
; CHECK-NEXT: [[NUM:%.*]] = or i8 [[XX]], 49
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[Y:%.*]], -15
; CHECK-NEXT: [[DIV:%.*]] = sdiv i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], -128
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%xx = and i8 %x, 127
%num = or i8 %xx, 49
%denum = or i8 %y, 241
%div = sdiv i8 %num, %denum
%and = and i8 %div, 128
%r = icmp eq i8 %and, 0
ret i1 %r
}
define i1 @sdiv_pos_neg_high_bits_fail_maybez(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_pos_neg_high_bits_fail_maybez(
; CHECK-NEXT: [[XX:%.*]] = and i8 [[X:%.*]], 127
; CHECK-NEXT: [[NUM:%.*]] = or i8 [[XX]], 49
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[Y:%.*]], -64
; CHECK-NEXT: [[DIV:%.*]] = sdiv i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], -128
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%xx = and i8 %x, 127
%num = or i8 %xx, 49
%denum = or i8 %y, 192
%div = sdiv i8 %num, %denum
%and = and i8 %div, 128
%r = icmp eq i8 %and, 0
ret i1 %r
}
define i1 @sdiv_exact_pos_neg_high_bits(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_exact_pos_neg_high_bits(
; CHECK-NEXT: [[XX:%.*]] = and i8 [[X:%.*]], 127
; CHECK-NEXT: [[NUM:%.*]] = or i8 [[XX]], 49
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[Y:%.*]], -64
; CHECK-NEXT: [[DIV:%.*]] = sdiv exact i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], -128
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%xx = and i8 %x, 127
%num = or i8 %xx, 49
%denum = or i8 %y, 192
%div = sdiv exact i8 %num, %denum
%and = and i8 %div, 128
%r = icmp eq i8 %and, 0
ret i1 %r
}
define i1 @sdiv_neg_pos_high_bits(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_neg_pos_high_bits(
; CHECK-NEXT: [[XX:%.*]] = and i8 [[X:%.*]], -97
; CHECK-NEXT: [[NUM:%.*]] = or i8 [[XX]], -127
; CHECK-NEXT: [[YY:%.*]] = and i8 [[Y:%.*]], 15
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[YY]], 9
; CHECK-NEXT: [[DIV:%.*]] = sdiv i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], -128
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%xx = and i8 %x, 159
%num = or i8 %xx, 129
%yy = and i8 %y, 15
%denum = or i8 %yy, 9
%div = sdiv i8 %num, %denum
%and = and i8 %div, 128
%r = icmp eq i8 %and, 0
ret i1 %r
}
define i1 @sdiv_neg_pos_high_bits_fail_maybez(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_neg_pos_high_bits_fail_maybez(
; CHECK-NEXT: [[NUM:%.*]] = or i8 [[X:%.*]], -128
; CHECK-NEXT: [[YY:%.*]] = and i8 [[Y:%.*]], 15
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[YY]], 9
; CHECK-NEXT: [[DIV:%.*]] = sdiv i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], -128
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%num = or i8 %x, 128
%yy = and i8 %y, 15
%denum = or i8 %yy, 9
%div = sdiv i8 %num, %denum
%and = and i8 %div, 128
%r = icmp eq i8 %and, 0
ret i1 %r
}
define i1 @sdiv_exact_odd_odd(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_exact_odd_odd(
; CHECK-NEXT: [[NUM:%.*]] = or i8 [[X:%.*]], 1
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[Y:%.*]], 1
; CHECK-NEXT: [[DIV:%.*]] = sdiv exact i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], 1
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%num = or i8 %x, 1
%denum = or i8 %y, 1
%div = sdiv exact i8 %num, %denum
%and = and i8 %div, 1
%r = icmp eq i8 %and, 0
ret i1 %r
}
define i1 @sdiv_exact_even_odd(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_exact_even_odd(
; CHECK-NEXT: [[NUM:%.*]] = and i8 [[X:%.*]], -2
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[Y:%.*]], 1
; CHECK-NEXT: [[DIV:%.*]] = sdiv exact i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], 1
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 1
; CHECK-NEXT: ret i1 [[R]]
;
%num = and i8 %x, -2
%denum = or i8 %y, 1
%div = sdiv exact i8 %num, %denum
%and = and i8 %div, 1
%r = icmp eq i8 %and, 1
ret i1 %r
}
define i1 @sdiv_exact_even_even_fail_unknown(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_exact_even_even_fail_unknown(
; CHECK-NEXT: [[NUM:%.*]] = and i8 [[X:%.*]], -2
; CHECK-NEXT: [[DENUM:%.*]] = and i8 [[Y:%.*]], -2
; CHECK-NEXT: [[DIV:%.*]] = sdiv exact i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], 1
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 1
; CHECK-NEXT: ret i1 [[R]]
;
%num = and i8 %x, -2
%denum = and i8 %y, -2
%div = sdiv exact i8 %num, %denum
%and = and i8 %div, 1
%r = icmp eq i8 %and, 1
ret i1 %r
}
define i1 @sdiv_exact_even_even_fail_unknown2(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_exact_even_even_fail_unknown2(
; CHECK-NEXT: [[NUM:%.*]] = and i8 [[X:%.*]], -2
; CHECK-NEXT: [[DENUM:%.*]] = and i8 [[Y:%.*]], -2
; CHECK-NEXT: [[DIV:%.*]] = sdiv exact i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], 1
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%num = and i8 %x, -2
%denum = and i8 %y, -2
%div = sdiv exact i8 %num, %denum
%and = and i8 %div, 1
%r = icmp eq i8 %and, 0
ret i1 %r
}
define i1 @udiv_high_bits(i8 %x, i8 %y) {
; CHECK-LABEL: @udiv_high_bits(
; CHECK-NEXT: [[NUM:%.*]] = and i8 [[X:%.*]], -127
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[Y:%.*]], 31
; CHECK-NEXT: [[DIV:%.*]] = udiv i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], 8
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 8
; CHECK-NEXT: ret i1 [[R]]
;
%num = and i8 %x, 129
%denum = or i8 %y, 31
%div = udiv i8 %num, %denum
%and = and i8 %div, 8
%r = icmp eq i8 %and, 8
ret i1 %r
}
define i1 @udiv_exact_odd_odd(i8 %x, i8 %y) {
; CHECK-LABEL: @udiv_exact_odd_odd(
; CHECK-NEXT: [[NUM:%.*]] = or i8 [[X:%.*]], 1
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[Y:%.*]], 1
; CHECK-NEXT: [[DIV:%.*]] = udiv exact i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], 1
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%num = or i8 %x, 1
%denum = or i8 %y, 1
%div = udiv exact i8 %num, %denum
%and = and i8 %div, 1
%r = icmp eq i8 %and, 0
ret i1 %r
}
define i1 @udiv_exact_even_odd(i8 %x, i8 %y) {
; CHECK-LABEL: @udiv_exact_even_odd(
; CHECK-NEXT: [[NUM:%.*]] = and i8 [[X:%.*]], -2
; CHECK-NEXT: [[DENUM:%.*]] = or i8 [[Y:%.*]], 1
; CHECK-NEXT: [[DIV:%.*]] = udiv exact i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], 1
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 1
; CHECK-NEXT: ret i1 [[R]]
;
%num = and i8 %x, -2
%denum = or i8 %y, 1
%div = udiv exact i8 %num, %denum
%and = and i8 %div, 1
%r = icmp eq i8 %and, 1
ret i1 %r
}
define i1 @udiv_exact_even_even_fail_unknown(i8 %x, i8 %y) {
; CHECK-LABEL: @udiv_exact_even_even_fail_unknown(
; CHECK-NEXT: [[NUM:%.*]] = and i8 [[X:%.*]], -2
; CHECK-NEXT: [[DENUM:%.*]] = and i8 [[Y:%.*]], -2
; CHECK-NEXT: [[DIV:%.*]] = udiv exact i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], 1
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 1
; CHECK-NEXT: ret i1 [[R]]
;
%num = and i8 %x, -2
%denum = and i8 %y, -2
%div = udiv exact i8 %num, %denum
%and = and i8 %div, 1
%r = icmp eq i8 %and, 1
ret i1 %r
}
define i1 @udiv_exact_even_even_fail_unknown2(i8 %x, i8 %y) {
; CHECK-LABEL: @udiv_exact_even_even_fail_unknown2(
; CHECK-NEXT: [[NUM:%.*]] = and i8 [[X:%.*]], -2
; CHECK-NEXT: [[DENUM:%.*]] = and i8 [[Y:%.*]], -2
; CHECK-NEXT: [[DIV:%.*]] = udiv exact i8 [[NUM]], [[DENUM]]
; CHECK-NEXT: [[AND:%.*]] = and i8 [[DIV]], 1
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AND]], 0
; CHECK-NEXT: ret i1 [[R]]
;
%num = and i8 %x, -2
%denum = and i8 %y, -2
%div = udiv exact i8 %num, %denum
%and = and i8 %div, 1
%r = icmp eq i8 %and, 0
ret i1 %r
}