Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D149966

[SLP]Include cost of the reshuffling for same nodes with resizing.
ClosedPublic
Actions

Authored by ABataev on May 5 2023, 8:27 AM.

Details

Reviewers
RKSimon
vdmitrie
Commits
rG83ba148a8ae1: [SLP]Include cost of the reshuffling for same nodes with resizing.
Summary

Need to account reshuffling, required for the reused elements in the
buildvector nodes, which are copies (perfect match) of other nodes, but
include reused elements.

Diff Detail

Event Timeline

ABataev created this revision.May 5 2023, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2023, 8:27 AM
Herald added subscribers: vporpo, hiraditya. · View Herald Transcript
ABataev requested review of this revision.May 5 2023, 8:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2023, 8:27 AM
Herald added a subscriber: • pcwang-thead. · View Herald Transcript
Harbormaster completed remote builds in B230254: Diff 519875.May 5 2023, 9:15 AM
ABataev updated this revision to Diff 527374.Jun 1 2023, 5:28 AM

Rebase

Harbormaster completed remote builds in B235809: Diff 527374.Jun 1 2023, 6:18 AM
ABataev updated this revision to Diff 538277.Jul 7 2023, 2:54 PM

Rebase, ping!

Herald added a subscriber: wangpc. · View Herald TranscriptJul 7 2023, 2:54 PM
Harbormaster completed remote builds in B243869: Diff 538277.Jul 7 2023, 5:02 PM
RKSimon added inline comments.Jul 9 2023, 5:09 AM
llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
7018

CommonMask?

ABataev updated this revision to Diff 538619.Jul 10 2023, 6:44 AM

Address comment

Harbormaster completed remote builds in B244123: Diff 538619.Jul 10 2023, 7:36 AM
ABataev updated this revision to Diff 538677.Jul 10 2023, 9:02 AM

Use getCommonMask() instead of just ReuseShuffleIndices

Harbormaster completed remote builds in B244167: Diff 538677.Jul 10 2023, 10:17 AM
ABataev updated this revision to Diff 540987.Jul 17 2023, 6:17 AM

Rebase, ping!

Harbormaster completed remote builds in B245819: Diff 540987.Jul 17 2023, 10:00 AM
RKSimon accepted this revision.Jul 18 2023, 5:12 AM

LGTM

This revision is now accepted and ready to land.Jul 18 2023, 5:12 AM
Closed by commit rG83ba148a8ae1: [SLP]Include cost of the reshuffling for same nodes with resizing. (authored by ABataev). · Explain WhyJul 18 2023, 6:08 AM
This revision was automatically updated to reflect the committed changes.
ABataev added a commit: rG83ba148a8ae1: [SLP]Include cost of the reshuffling for same nodes with resizing..

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
Vectorize/
23 lines
test/
Transforms/
SLPVectorizer/
X86/
2 lines

Diff 541492

View Options

llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/crash_clear_undefs.ll

Loading...