This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Remove incorrect result from wasm64 store_lane instructions
ClosedPublic

Authored by tlively on May 3 2023, 12:38 PM.

Details

Summary

The wasm64 versions of the v128.storeX_lane instructions was incorrectly defined
as returning a v128 value, which resulted in spurious drop instructions being
emitted and causing validation to fail. This was not caught earlier because
wasm64 has been experimental and not well tested. Update the relevant test file
to test both wasm32 and wasm64.

Fixes #62443.

Diff Detail

Event Timeline

tlively created this revision.May 3 2023, 12:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2023, 12:38 PM
Herald added subscribers: pmatos, asb, wingo and 5 others. · View Herald Transcript
tlively requested review of this revision.May 3 2023, 12:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2023, 12:38 PM
tlively updated this revision to Diff 519225.May 3 2023, 1:09 PM
  • Update additional test
sbc100 added a comment.May 3 2023, 2:06 PM

Nice! God knows how long it would have taken me to find that one!

sbc100 accepted this revision.May 3 2023, 2:07 PM
This revision is now accepted and ready to land.May 3 2023, 2:07 PM