[flang] Removed unnecessary llvm/CodeGen/SelectionDAGNodes.h include.

[vzakhari]

Summary

Required after D148767 for flang+debug+slibs build.

[clementval]

LGTM

[chapuni]

Fine.

But I wonder why this didn't have LINK_COMPONENTS before. I guess this would rely on transitive deps.
(LLT impl was provided by LLVMSupport before)

[vzakhari]

In D149764#4316368, @chapuni wrote:

Fine.

But I wonder why this didn't have LINK_COMPONENTS before. I guess this would rely on transitive deps.
(LLT impl was provided by LLVMSupport before)

Good question! It turns out the problem is caused by an unnecessary inclusion of llvm/CodeGen/SelectionDAGNodes.h that ends up including LowLevelType.h. I will upload the diff shortly.

[chapuni]

I am not certain about this change. Ok if this resolves your matter.

I guess the issue was because Debug build would instantiate everything. So, cleaning up unused headers would be good idea.

ps. I expect cmake -DCMAKE_OPTIMIZE_DEPENDENCIES:BOOL=ON . would discover more hidden issues.

flang/lib/Optimizer/Transforms/SimplifyIntrinsics.cpp

 #include "mlir/IR/Matchers.h"
 #include "mlir/IR/Operation.h"
 #include "mlir/Pass/Pass.h"
 #include "mlir/Transforms/DialectConversion.h"
 #include "mlir/Transforms/GreedyPatternRewriteDriver.h"
 #include "mlir/Transforms/RegionUtils.h"
 #include "llvm/Support/Debug.h"
 #include "llvm/Support/raw_ostream.h"
-#include <llvm/CodeGen/SelectionDAGNodes.h>
 #include <llvm/Support/ErrorHandling.h>
 #include <mlir/Dialect/Arith/IR/Arith.h>
 #include <mlir/IR/BuiltinTypes.h>
 #include <mlir/IR/Location.h>
 #include <mlir/IR/MLIRContext.h>
 #include <mlir/IR/Value.h>
 #include <mlir/Support/LLVM.h>
 #include <optional>