This is an archive of the discontinued LLVM Phabricator instance.

Differential D149758

Revert "[AMDGPU] Define data layout entries for buffers"
ClosedPublic

Authored by krzysz00 on May 3 2023, 9:10 AM.

Details

Reviewers
jdoerfert
sstefan1
Commits
rG3f2fbe92d0f4: Revert "[AMDGPU] Define data layout entries for buffers"
Summary

This reverts commit f9c1ede2543b37fabe9f2d8f8fed5073c475d850.

Diff Detail

Event Timeline

krzysz00 created this revision.May 3 2023, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2023, 9:10 AM
Herald added subscribers: kosarev, jeroen.dobbelaere, foad and 14 others. · View Herald Transcript
krzysz00 requested review of this revision.May 3 2023, 9:10 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptMay 3 2023, 9:10 AM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, cfe-commits, • pcwang-thead, wdng. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2023, 9:11 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG3f2fbe92d0f4: Revert "[AMDGPU] Define data layout entries for buffers" (authored by krzysz00). · Explain Why
This revision was automatically updated to reflect the committed changes.
krzysz00 added a commit: rG3f2fbe92d0f4: Revert "[AMDGPU] Define data layout entries for buffers".
krzysz00 added a reverting change: D149776: Re-land "[AMDGPU] Define data layout entries for buffers"".May 3 2023, 11:52 AM
krzysz00 added a reverting change: rGf0415f2a456d: Re-land "[AMDGPU] Define data layout entries for buffers"".May 3 2023, 12:44 PM

Large Diff

This large diff affects 148 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
4 lines
test/
CodeGen/
4 lines
CodeGenOpenCL/
2 lines
llvm/
docs/
21 lines
lib/
IR/
30 lines
Target/
AMDGPU/
5 lines
27 lines
12 lines
3 lines
8 lines
test/
CodeGen/
AMDGPU/
GlobalISel/
16 lines
16 lines
16 lines
16 lines
8 lines
37 lines
96 lines
168 lines
96 lines
48 lines
8 lines
8 lines
282 lines
16 lines
12 lines
76 lines
32 lines
40 lines
16 lines
10 lines
2 lines
40 lines
20 lines
12 lines
70 lines
44 lines
24 lines
66 lines
32 lines
18 lines
40 lines
16 lines
50 lines
14 lines
10 lines
2 lines
40 lines
24 lines
20 lines
32 lines
20 lines
12 lines
20 lines
24 lines
14 lines
16 lines
20 lines
10 lines
10 lines
10 lines
2 lines
2 lines
16 lines
16 lines
16 lines
16 lines
8 lines
200 lines
2 lines
4 lines
2 lines
10 lines
12 lines
70 lines
22 lines
24 lines
66 lines
16 lines
18 lines
20 lines
50 lines
32 lines
2 lines
2 lines
2 lines
15 lines
2 lines
2 lines
2 lines
62 lines
2 lines
2 lines
2 lines
2 lines
MIR/
AMDGPU/
4 lines
Instrumentation/
AddressSanitizer/
AMDGPU/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
Transforms/
AlignmentFromAssumptions/
2 lines
AtomicExpand/
AMDGPU/
2 lines
EarlyCSE/
AMDGPU/
2 lines
IndVarSimplify/
AMDGPU/
2 lines
InferAddressSpaces/
AMDGPU/
2 lines
2 lines
X86/
2 lines
Inline/
AMDGPU/
2 lines
InstCombine/
AMDGPU/
2 lines
2 lines
LoadStoreVectorizer/
AMDGPU/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
LoopLoadElim/
2 lines
LoopStrengthReduce/
AMDGPU/
2 lines
2 lines
2 lines
2 lines
2 lines
OpenMP/
2 lines
2 lines
2 lines
SLPVectorizer/
AMDGPU/
2 lines
VectorCombine/
AMDGPU/
2 lines
2 lines
unittests/
Bitcode/
34 lines

Diff 519103

clang/lib/Basic/Targets/AMDGPU.cpp

clang/test/CodeGen/target-data.c

clang/test/CodeGenOpenCL/amdgpu-env-amdgcn.cl

llvm/docs/AMDGPUUsage.rst

llvm/lib/IR/AutoUpgrade.cpp

llvm/lib/Target/AMDGPU/AMDGPU.h

llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp

llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp

llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

llvm/test/CodeGen/AMDGPU/GlobalISel/buffer-atomic-fadd.f32-no-rtn.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/buffer-atomic-fadd.f32-rtn.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/buffer-atomic-fadd.f64.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/buffer-atomic-fadd.v2f16-no-rtn.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/buffer-atomic-fadd.v2f16-rtn.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-non-integral-address-spaces.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.atomic.dim.a16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.dim.a16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.load.2d.d16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.load.2d.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.load.2darraymsaa.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.load.3d.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.sample.a16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.sample.d.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.sample.g16.a16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.sample.g16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.store.2d.d16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.image.atomic.dim.mir

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.buffer.atomic.add.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.buffer.atomic.cmpswap.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.buffer.atomic.fadd-with-ret.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.buffer.atomic.fadd.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.buffer.load.format.f16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.buffer.load.format.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.buffer.load.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.buffer.store.format.f16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.buffer.store.format.f32.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.buffer.store.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.tbuffer.load.f16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.tbuffer.load.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.tbuffer.store.f16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.tbuffer.store.i8.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.raw.tbuffer.store.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.buffer.atomic.add.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.buffer.atomic.cmpswap.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.buffer.atomic.fadd-with-ret.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.buffer.atomic.fadd.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.buffer.load.format.f16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.buffer.load.format.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.buffer.load.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.buffer.store.format.f16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.buffer.store.format.f32.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.buffer.store.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.tbuffer.load.f16.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.struct.tbuffer.load.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.image.load.1d.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.image.sample.1d.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.raw.buffer.load.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.struct.buffer.load.ll

llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.struct.buffer.store.ll

llvm/test/CodeGen/AMDGPU/addrspacecast-captured.ll

llvm/test/CodeGen/AMDGPU/annotate-kernel-features-hsa.ll

llvm/test/CodeGen/AMDGPU/buffer-atomic-fadd.f32-no-rtn.ll

llvm/test/CodeGen/AMDGPU/buffer-atomic-fadd.f32-rtn.ll

llvm/test/CodeGen/AMDGPU/buffer-atomic-fadd.f64.ll

llvm/test/CodeGen/AMDGPU/buffer-atomic-fadd.v2f16-no-rtn.ll

llvm/test/CodeGen/AMDGPU/buffer-atomic-fadd.v2f16-rtn.ll

llvm/test/CodeGen/AMDGPU/buffer-intrinsics-mmo-offsets.ll

llvm/test/CodeGen/AMDGPU/cgp-addressing-modes.ll

llvm/test/CodeGen/AMDGPU/extract_subvector_vec4_vec3.ll

llvm/test/CodeGen/AMDGPU/force-alwaysinline-lds-global-address.ll

llvm/test/CodeGen/AMDGPU/legalize-amdgcn.raw.buffer.load.format.f16.ll

llvm/test/CodeGen/AMDGPU/legalize-amdgcn.raw.buffer.load.format.ll

llvm/test/CodeGen/AMDGPU/legalize-amdgcn.raw.buffer.load.ll

llvm/test/CodeGen/AMDGPU/legalize-amdgcn.raw.buffer.store.format.f16.ll

llvm/test/CodeGen/AMDGPU/legalize-amdgcn.raw.buffer.store.format.f32.ll

llvm/test/CodeGen/AMDGPU/legalize-amdgcn.raw.buffer.store.ll

llvm/test/CodeGen/AMDGPU/legalize-amdgcn.raw.tbuffer.load.f16.ll

llvm/test/CodeGen/AMDGPU/legalize-amdgcn.raw.tbuffer.load.ll

llvm/test/CodeGen/AMDGPU/legalize-amdgcn.raw.tbuffer.store.f16.ll

llvm/test/CodeGen/AMDGPU/legalize-amdgcn.raw.tbuffer.store.ll

llvm/test/CodeGen/AMDGPU/legalize-soffset-mbuf.ll

llvm/test/CodeGen/AMDGPU/loop-idiom.ll

llvm/test/CodeGen/AMDGPU/mdt-preserving-crash.ll

llvm/test/CodeGen/AMDGPU/noop-shader-O0.ll

llvm/test/CodeGen/AMDGPU/nullptr-long-address-spaces.ll

llvm/test/CodeGen/AMDGPU/nullptr.ll

llvm/test/CodeGen/AMDGPU/promote-alloca-lifetime.ll

llvm/test/CodeGen/AMDGPU/promote-alloca-to-lds-select.ll

llvm/test/CodeGen/AMDGPU/sgpr-copy-local-cse.ll

llvm/test/CodeGen/AMDGPU/splitkit-getsubrangeformask.ll

llvm/test/CodeGen/AMDGPU/unroll.ll

llvm/test/CodeGen/AMDGPU/unsupported-image-a16.ll

llvm/test/CodeGen/AMDGPU/unsupported-image-g16.ll

llvm/test/CodeGen/AMDGPU/vgpr-liverange-ir.ll

llvm/test/CodeGen/MIR/AMDGPU/custom-pseudo-source-values.ll

llvm/test/Instrumentation/AddressSanitizer/AMDGPU/adaptive_constant_global_redzones.ll

llvm/test/Instrumentation/AddressSanitizer/AMDGPU/adaptive_global_redzones.ll

llvm/test/Instrumentation/AddressSanitizer/AMDGPU/asan_do_not_instrument_lds.ll

llvm/test/Instrumentation/AddressSanitizer/AMDGPU/asan_do_not_instrument_scratch.ll

llvm/test/Instrumentation/AddressSanitizer/AMDGPU/asan_instrument_constant_address_space.ll

llvm/test/Instrumentation/AddressSanitizer/AMDGPU/asan_instrument_generic_address_space.ll

llvm/test/Instrumentation/AddressSanitizer/AMDGPU/asan_instrument_global_address_space.ll

llvm/test/Instrumentation/AddressSanitizer/AMDGPU/global_metadata_addrspacecasts.ll

llvm/test/Instrumentation/AddressSanitizer/AMDGPU/no_redzones_in_lds_globals.ll

llvm/test/Instrumentation/AddressSanitizer/AMDGPU/no_redzones_in_scratch_globals.ll

llvm/test/Transforms/AlignmentFromAssumptions/amdgpu-crash.ll

llvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomic-i16.ll

llvm/test/Transforms/EarlyCSE/AMDGPU/memrealtime.ll

llvm/test/Transforms/IndVarSimplify/AMDGPU/no-widen-to-i64.ll

llvm/test/Transforms/InferAddressSpaces/AMDGPU/noop-ptrint-pair.ll

llvm/test/Transforms/InferAddressSpaces/AMDGPU/ptrmask.ll

llvm/test/Transforms/InferAddressSpaces/X86/noop-ptrint-pair.ll

llvm/test/Transforms/Inline/AMDGPU/amdgpu-inline-alloca-argument.ll

llvm/test/Transforms/InstCombine/AMDGPU/memcpy-from-constant.ll

llvm/test/Transforms/InstCombine/alloca-in-non-alloca-as.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/aa-metadata.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/adjust-alloca-alignment.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/complex-index.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/extended-index.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/gep-bitcast.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/insertion-point.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/interleaved-mayalias-store.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/invariant-load.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/merge-stores-private.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/merge-stores.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/missing-alignment.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/multiple_tails.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/no-implicit-float.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/optnone.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/pointer-elements.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/selects-inseltpoison.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/selects.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/store_with_aliasing_load.ll

llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/weird-type-accesses.ll

llvm/test/Transforms/LoopLoadElim/pr46854-adress-spaces.ll

llvm/test/Transforms/LoopStrengthReduce/AMDGPU/atomics.ll

llvm/test/Transforms/LoopStrengthReduce/AMDGPU/different-addrspace-addressing-mode-loops.ll

llvm/test/Transforms/LoopStrengthReduce/AMDGPU/lsr-invalid-ptr-extend.ll

llvm/test/Transforms/LoopStrengthReduce/AMDGPU/lsr-postinc-pos-addrspace.ll

llvm/test/Transforms/LoopStrengthReduce/AMDGPU/preserve-addrspace-assert.ll

llvm/test/Transforms/OpenMP/attributor_pointer_offset_crash.ll

llvm/test/Transforms/OpenMP/spmdization_constant_prop.ll

llvm/test/Transforms/OpenMP/values_in_offload_arrays.alloca.ll

llvm/test/Transforms/SLPVectorizer/AMDGPU/address-space-ptr-sze-gep-index-assert.ll

llvm/test/Transforms/VectorCombine/AMDGPU/as-transition-inseltpoison.ll

llvm/test/Transforms/VectorCombine/AMDGPU/as-transition.ll

llvm/unittests/Bitcode/DataLayoutUpgradeTest.cpp