This is an archive of the discontinued LLVM Phabricator instance.

Fix a typo in head comment of CurPPLexer
ClosedPublic

Authored by zhouyizhou on May 2 2023, 5:37 PM.

Details

Summary

In head comment of CurPPLexer field of class Preprocessor,
'The current top of the stack what we're lexing from' should be
'The current top of the stack that we're lexing from'

Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>

Diff Detail

Event Timeline

zhouyizhou created this revision.May 2 2023, 5:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2023, 5:37 PM
zhouyizhou requested review of this revision.May 2 2023, 5:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2023, 5:37 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
vsapsai accepted this revision.May 2 2023, 7:14 PM

Thanks for the fix! Don't see any other places in the file to fix.

clang/include/clang/Lex/Preprocessor.h
726

This already uses "that".

This revision is now accepted and ready to land.May 2 2023, 7:14 PM

Thanks for the fix! Don't see any other places in the file to fix.

Thanks for review my patch ;-)
I have no write access to LLVM project, can you commit it for me ?

Thanks in Advance ;-)
Zhouyi Zhou <zhouzhouyi@gmail.com>

This revision was landed with ongoing or failed builds.May 2 2023, 7:50 PM
This revision was automatically updated to reflect the committed changes.