This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Drop and auto-upgrade llvm.amdgcn.ldexp to llvm.ldexp
ClosedPublic

Authored by arsenm on May 1 2023, 7:39 AM.

Details

Reviewers
foad
Joe_Nash
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

arsenm created this revision.May 1 2023, 7:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2023, 7:39 AM
arsenm requested review of this revision.May 1 2023, 7:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2023, 7:39 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm updated this revision to Diff 518444.May 1 2023, 7:59 AM

Missed test update

arsenm updated this revision to Diff 518445.May 1 2023, 8:02 AM
arsenm updated this revision to Diff 518447.May 1 2023, 8:07 AM
Joe_Nash added inline comments.May 1 2023, 8:09 AM
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ldexp.f16.ll
6

Should we not update these tests to use the generic intrinsic rather than delete them? I am working on Codegen for the new version of this instruction where src1 is 16-bit, and these tests are covering useful output.

arsenm added inline comments.May 1 2023, 8:35 AM
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ldexp.f16.ll
6

New ones are added in D14327

Joe_Nash added inline comments.May 18 2023, 7:43 AM
llvm/test/CodeGen/AMDGPU/known-never-snan.ll
661

Why did this case need a manual update rather than use the autoupgrade?

arsenm added inline comments.May 18 2023, 9:24 AM
llvm/test/CodeGen/AMDGPU/known-never-snan.ll
661

The auto-upgrade would work functionality wise. But there are 2 issues. For the optimization purposes, the old form wasn't recognized in isCanonicalized so the optimization broke. Second I think it's good practice to upgrade tests to the new intrinsics and only test the old forms in upgrade tests

This revision is now accepted and ready to land.May 18 2023, 9:59 AM
This revision is now accepted and ready to land.Jul 11 2023, 2:31 AM
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ldexp.f16.ll