Diff Detail
Event Timeline
| llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ldexp.f16.ll | ||
|---|---|---|
| 6 | Should we not update these tests to use the generic intrinsic rather than delete them? I am working on Codegen for the new version of this instruction where src1 is 16-bit, and these tests are covering useful output. | |
| llvm/test/CodeGen/AMDGPU/known-never-snan.ll | ||
|---|---|---|
| 661 | Why did this case need a manual update rather than use the autoupgrade? | |
| llvm/test/CodeGen/AMDGPU/known-never-snan.ll | ||
|---|---|---|
| 661 | The auto-upgrade would work functionality wise. But there are 2 issues. For the optimization purposes, the old form wasn't recognized in isCanonicalized so the optimization broke. Second I think it's good practice to upgrade tests to the new intrinsics and only test the old forms in upgrade tests | |
Why did this case need a manual update rather than use the autoupgrade?