This is an archive of the discontinued LLVM Phabricator instance.

[mlir][bytecode] Return error instead of min version
ClosedPublic

Authored by jpienaar on Apr 30 2023, 9:27 PM.

Details

Summary

Can't return a well-formed IR output while enabling version to be bumped
up during emission. Previously it would return min version but
potentially invalid IR which was confusing, instead make it return
error and abort immediately instead.

Diff Detail

Event Timeline

jpienaar created this revision.Apr 30 2023, 9:27 PM
Herald added a project: Restricted Project. · View Herald Transcript
jpienaar requested review of this revision.Apr 30 2023, 9:28 PM
mehdi_amini accepted this revision.Apr 30 2023, 10:09 PM
This revision is now accepted and ready to land.Apr 30 2023, 10:09 PM
This revision was automatically updated to reflect the committed changes.