This is an archive of the discontinued LLVM Phabricator instance.

Differential D149543

[libc++][format] Fixes vector<bool> requirements.
ClosedPublic

Authored by Mordante on Apr 30 2023, 4:48 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG7e6bcb35a811: [libc++][format] Fixes vector<bool> requirements.
Summary

Makes sure the formatter for the vector<bool>::reference is enabled
when only the header <vector> is included. Before this change it
required <vector> and <format> to be included. This violated the
requirements in the Standard.

Fixes: https://llvm.org/PR61314

Diff Detail

Event Timeline

Mordante created this revision.Apr 30 2023, 4:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2023, 4:48 AM
Mordante requested review of this revision.Apr 30 2023, 4:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2023, 4:48 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B229119: Diff 518296.Apr 30 2023, 5:14 AM
Mordante updated this revision to Diff 518311.Apr 30 2023, 7:40 AM

Rebased and CI fixes.

Harbormaster failed remote builds in B229133: Diff 518311!Apr 30 2023, 7:40 AM
Mordante updated this revision to Diff 518312.Apr 30 2023, 7:49 AM

CI fixes.

Harbormaster failed remote builds in B229134: Diff 518312!Apr 30 2023, 7:49 AM
Mordante updated this revision to Diff 518331.Apr 30 2023, 8:30 AM

CI fixes.

Harbormaster failed remote builds in B229140: Diff 518331!Apr 30 2023, 8:30 AM
Mordante updated this revision to Diff 518337.Apr 30 2023, 11:08 AM

Fixes CI.

Harbormaster failed remote builds in B229144: Diff 518337!Apr 30 2023, 11:09 AM
ldionne accepted this revision.May 3 2023, 9:00 AM
ldionne added a subscriber: ldionne.

LGTM but I think we should probably remove the header workaround.

libcxx/include/vector
327

Which ones would we need to remove in order not to have this workaround? I think it might be reasonable to take the hit -- usually our stance is that we try not to remove transitive includes just for the sake of it, however when those transitive includes are a blocker to our work, we remove them. So IMO it would be reasonable to remove the transitive includes causing problems here, unless the impact is really too big.

This revision is now accepted and ready to land.May 3 2023, 9:00 AM
Mordante updated this revision to Diff 519147.May 3 2023, 10:11 AM

Rebased and addresses review comment.

Harbormaster completed remote builds in B229738: Diff 519147.May 3 2023, 10:12 AM
Mordante updated this revision to Diff 519501.May 4 2023, 8:03 AM

Rebased and trigger CI.

Mordante updated this revision to Diff 519541.May 4 2023, 9:45 AM

CI fixes.

Harbormaster completed remote builds in B230017: Diff 519541.May 4 2023, 12:55 PM
Mordante updated this revision to Diff 520058.May 6 2023, 2:44 AM

Rebased and trigger CI.

Harbormaster completed remote builds in B230399: Diff 520058.May 6 2023, 4:56 AM
This revision was landed with ongoing or failed builds.May 6 2023, 5:07 AM
Closed by commit rG7e6bcb35a811: [libc++][format] Fixes vector<bool> requirements. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG7e6bcb35a811: [libc++][format] Fixes vector<bool> requirements..
Mordante mentioned this in D150041: [NFC][libc++][format] Tests formatter requirements..May 6 2023, 8:30 AM
Mordante mentioned this in rG62858636f54a: [NFC][libc++][format] Tests formatter requirements..May 13 2023, 2:21 AM
hans added a subscriber: hans.Jun 28 2023, 5:40 AM

In Chromium we noticed that this almost doubled the preprocessed size of <vector>, from ca 1.6 MB to 3.2 MB. Since it's a widely included header, that results in ca 8 GB (2.5%) of extra code to compile during a full build.

I realize this change is based on a requirement in the standard, but it seems unfortunate that the cost of the format library is spilling over to vector like this. If there's anything that could be done to reduce the impact here, that would be very valuable to us and presumably other libc++ users too.

Mordante added a comment.Jun 28 2023, 8:44 AM
In D149543#4455780, @hans wrote:

In Chromium we noticed that this almost doubled the preprocessed size of <vector>, from ca 1.6 MB to 3.2 MB. Since it's a widely included header, that results in ca 8 GB (2.5%) of extra code to compile during a full build.

I realize this change is based on a requirement in the standard, but it seems unfortunate that the cost of the format library is spilling over to vector like this. If there's anything that could be done to reduce the impact here, that would be very valuable to us and presumably other libc++ users too.

Interesting. Am I right to assume most of the new size is due to including <string>? 2.5% is quite a bit. I'm not sure whether there is a good solution. (Unfortunately modules are not really usable yet.)

I have verified and the bool formatter really needs a string. It needs to use truename which is a string
https://en.cppreference.com/w/cpp/locale/numpunct/truefalsename

hans added a comment.Jun 28 2023, 12:02 PM
In D149543#4456497, @Mordante wrote:

Interesting. Am I right to assume most of the new size is due to including <string>?

I don't think it's <string>; that's already widely included. I think it's __format/formatter_output.h where most of it gets added.

Part of me thinks maybe <format> could be gated behind a macro like is was while it was experimental, since we're not currently using it in Chromium. But that would only delay the issue until we do want to use it of course.

ldionne added a comment.Jun 29 2023, 8:07 AM
In D149543#4456976, @hans wrote:
In D149543#4456497, @Mordante wrote:

Interesting. Am I right to assume most of the new size is due to including <string>?

I don't think it's <string>; that's already widely included. I think it's __format/formatter_output.h where most of it gets added.

@Mordante What's the very very minimum amount of stuff we need to implement formatter<bool>? Are we somehow including a lot more than we strictly need? Can we split up some of those format headers to avoid including some of this stuff transitively?

Part of me thinks maybe <format> could be gated behind a macro like is was while it was experimental, since we're not currently using it in Chromium. But that would only delay the issue until we do want to use it of course.

IMO that's just sweeping the issue under the carpet.

Mordante added a comment.Jun 29 2023, 10:40 AM
In D149543#4459956, @ldionne wrote:
In D149543#4456976, @hans wrote:
In D149543#4456497, @Mordante wrote:

Interesting. Am I right to assume most of the new size is due to including <string>?

I don't think it's <string>; that's already widely included. I think it's __format/formatter_output.h where most of it gets added.

Thanks for the info @hans.

@Mordante What's the very very minimum amount of stuff we need to implement formatter<bool>? Are we somehow including a lot more than we strictly need? Can we split up some of those format headers to avoid including some of this stuff transitively?

At the moment we include the minimum set of granularized headers we need. I had a look yesterday and I found some unneeded includes in our granularized format headers, I'll create a patch for that after testing. I think I can slice up formatter_output.h and reduce the number includes that way. I'll look into that later this week.

Part of me thinks maybe <format> could be gated behind a macro like is was while it was experimental, since we're not currently using it in Chromium. But that would only delay the issue until we do want to use it of course.

IMO that's just sweeping the issue under the carpet.

I agree. However I think the performance of compiling vector is important. So I'm not entirely against it as long as users (chromium) explicitly needs to opt out of it, so by default you get the the current behaviour.

Mordante mentioned this in D154122: [libc++][format] Removes unneeded includes..Jun 29 2023, 10:58 AM
Mordante mentioned this in rG285e1e2a0020: [libc++][format] Removes unneeded includes..Jul 8 2023, 3:39 AM
hans mentioned this in D154286: [libc++][format] Granularize formatter_output..Jul 11 2023, 6:18 AM
Mordante mentioned this in D157298: [RFC][libc++] Reduce the size of translation units.Aug 7 2023, 10:12 AM
huihuiz added a subscriber: huihuiz.Aug 24 2023, 5:42 PM

This is causing compilation failure in https://github.com/llvm/llvm-project/issues/64971

Herald added a subscriber: sunshaoce. · View Herald TranscriptAug 24 2023, 5:42 PM

Revision Contents

PathSize
libcxx/
docs/
2 lines
include/
1 line
5 lines
test/
libcxx/
transitive_includes/
13 lines
13 lines
13 lines
13 lines
13 lines
6 lines
std/
containers/
sequences/
vector.bool/
vector.bool.fmt/
41 lines

Diff 519147

libcxx/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines- Several incidental transitive includes have been removed from libc++. Those
includes are removed based on the language version used. Incidental transitive includes are removed based on the language version used. Incidental transitive
inclusions of the following headers have been removed: inclusions of the following headers have been removed:
- C++2b: ``atomic``, ``bit``, ``cstdint``, ``cstdlib``, ``cstring``, ``initializer_list``, ``limits``, ``new``, - C++2b: ``atomic``, ``bit``, ``cstdint``, ``cstdlib``, ``cstring``, ``initializer_list``, ``limits``, ``new``,
``stdexcept``, ``system_error``, ``type_traits``, ``typeinfo`` ``stdexcept``, ``system_error``, ``type_traits``, ``typeinfo``
- ``<algorithm>`` no longer includes ``<chrono>`` in any C++ version (it was prevously included in C++17 and earlier). - ``<algorithm>`` no longer includes ``<chrono>`` in any C++ version (it was prevously included in C++17 and earlier).
- ``<string>`` no longer includes ``<vector>`` in any C++ version (it was prevously included in C++20 and earlier).
- The headers ``<experimental/algorithm>`` and ``<experimental/functional>`` have been removed, since all the contents - The headers ``<experimental/algorithm>`` and ``<experimental/functional>`` have been removed, since all the contents
have been implemented in namespace ``std`` for at least two releases. have been implemented in namespace ``std`` for at least two releases.
- The formatter specialization ``template<size_t N> struct formatter<const charT[N], charT>`` - The formatter specialization ``template<size_t N> struct formatter<const charT[N], charT>``
has been removed. Since libc++'s format library was marked experimental there has been removed. Since libc++'s format library was marked experimental there
is no backwards compatibility option. This specialization has been removed is no backwards compatibility option. This specialization has been removed
from the Standard since it was never used, the proper specialization to use from the Standard since it was never used, the proper specialization to use
instead is ``template<size_t N> struct formatter<charT[N], charT>``. instead is ``template<size_t N> struct formatter<charT[N], charT>``.
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines

libcxx/include/string

Show First 20 Lines • Show All 4,389 Lines • ▼ Show 20 Lines
# include <concepts> # include <concepts>
# include <cstdlib> # include <cstdlib>
# include <functional> # include <functional>
# include <iterator> # include <iterator>
# include <new> # include <new>
# include <type_traits> # include <type_traits>
# include <typeinfo> # include <typeinfo>
# include <utility> # include <utility>
# include <vector>
#endif #endif
#endif // _LIBCPP_STRING #endif // _LIBCPP_STRING

libcxx/include/vector

Show First 20 Lines • Show All 287 Lines • ▼ Show 20 Lines
#include <__algorithm/unwrap_iter.h> #include <__algorithm/unwrap_iter.h>
#include <__assert> // all public C++ headers provide the assertion handler #include <__assert> // all public C++ headers provide the assertion handler
#include <__bit_reference> #include <__bit_reference>
#include <__concepts/same_as.h> #include <__concepts/same_as.h>
#include <__config> #include <__config>
#include <__debug> #include <__debug>
#include <__format/enable_insertable.h> #include <__format/enable_insertable.h>
#include <__format/formatter.h> #include <__format/formatter.h>
#include <__format/formatter_bool.h>
#include <__functional/hash.h> #include <__functional/hash.h>
#include <__functional/unary_function.h> #include <__functional/unary_function.h>
#include <__iterator/advance.h> #include <__iterator/advance.h>
#include <__iterator/iterator_traits.h> #include <__iterator/iterator_traits.h>
#include <__iterator/reverse_iterator.h> #include <__iterator/reverse_iterator.h>
#include <__iterator/wrap_iter.h> #include <__iterator/wrap_iter.h>
#include <__memory/addressof.h> #include <__memory/addressof.h>
#include <__memory/allocate_at_least.h> #include <__memory/allocate_at_least.h>
Show All 14 Lines
#include <__utility/swap.h> #include <__utility/swap.h>
#include <climits> #include <climits>
#include <cstring> #include <cstring>
#include <iosfwd> // for forward declaration of vector #include <iosfwd> // for forward declaration of vector
#include <limits> #include <limits>
#include <stdexcept> #include <stdexcept>
#include <version> #include <version>
// standard-mandated includes // standard-mandated includes
ldionneUnsubmitted
Not Done
ReplyInline Actions

Which ones would we need to remove in order not to have this workaround? I think it might be reasonable to take the hit -- usually our stance is that we try not to remove transitive includes just for the sake of it, however when those transitive includes are a blocker to our work, we remove them. So IMO it would be reasonable to remove the transitive includes causing problems here, unless the impact is really too big.

ldionne: Which ones would we need to remove in order not to have this workaround? I think it might be…
// [iterator.range] // [iterator.range]
#include <__iterator/access.h> #include <__iterator/access.h>
#include <__iterator/data.h> #include <__iterator/data.h>
#include <__iterator/empty.h> #include <__iterator/empty.h>
#include <__iterator/reverse_access.h> #include <__iterator/reverse_access.h>
#include <__iterator/size.h> #include <__iterator/size.h>
▲ Show 20 Lines • Show All 2,983 Lines • ▼ Show 20 Lines
inline constexpr bool __format::__enable_insertable<vector<char>> = true; inline constexpr bool __format::__enable_insertable<vector<char>> = true;
#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS #ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
template <> template <>
inline constexpr bool __format::__enable_insertable<vector<wchar_t>> = true; inline constexpr bool __format::__enable_insertable<vector<wchar_t>> = true;
#endif #endif
#endif // _LIBCPP_STD_VER >= 20 #endif // _LIBCPP_STD_VER >= 20
#if _LIBCPP_STD_VER >= 23 #if !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT) && _LIBCPP_STD_VER >= 23
template <class _Tp, class CharT> template <class _Tp, class CharT>
// Since is-vector-bool-reference is only used once it's inlined here. // Since is-vector-bool-reference is only used once it's inlined here.
requires same_as<typename _Tp::__container, vector<bool, typename _Tp::__container::allocator_type>> requires same_as<typename _Tp::__container, vector<bool, typename _Tp::__container::allocator_type>>
struct _LIBCPP_TEMPLATE_VIS formatter<_Tp, CharT> { struct _LIBCPP_TEMPLATE_VIS formatter<_Tp, CharT> {
private: private:
formatter<bool, CharT> __underlying_; formatter<bool, CharT> __underlying_;
public: public:
template <class _ParseContext> template <class _ParseContext>
_LIBCPP_HIDE_FROM_ABI constexpr typename _ParseContext::iterator parse(_ParseContext& __ctx) { _LIBCPP_HIDE_FROM_ABI constexpr typename _ParseContext::iterator parse(_ParseContext& __ctx) {
return __underlying_.parse(__ctx); return __underlying_.parse(__ctx);
} }
template <class _FormatContext> template <class _FormatContext>
_LIBCPP_HIDE_FROM_ABI typename _FormatContext::iterator format(const _Tp& __ref, _FormatContext& __ctx) const { _LIBCPP_HIDE_FROM_ABI typename _FormatContext::iterator format(const _Tp& __ref, _FormatContext& __ctx) const {
return __underlying_.format(__ref, __ctx); return __underlying_.format(__ref, __ctx);
} }
}; };
#endif // _LIBCPP_STD_VER >= 23 #endif // !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT) && _LIBCPP_STD_VER >= 23
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
#if _LIBCPP_STD_VER >= 17 #if _LIBCPP_STD_VER >= 17
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
namespace pmr { namespace pmr {
template <class _ValueT> template <class _ValueT>
using vector = std::vector<_ValueT, polymorphic_allocator<_ValueT>>; using vector = std::vector<_ValueT, polymorphic_allocator<_ValueT>>;
Show All 17 Lines

libcxx/test/libcxx/transitive_includes/cxx03.csv

Show First 20 Lines • Show All 392 Lines • ▼ Show 20 Lines
functional tuple functional tuple
functional type_traits functional type_traits
functional typeinfo functional typeinfo
functional unordered_map functional unordered_map
functional utility functional utility
functional vector functional vector
functional version functional version
future atomic future atomic
future cerrno
future chrono future chrono
future cstddef future cstddef
future cstdint future cstdint
future cstdlib future cstdlib
future cstring future cstring
future exception future exception
future initializer_list future initializer_list
future iosfwd future iosfwd
▲ Show 20 Lines • Show All 400 Lines • ▼ Show 20 Lines
string limits string limits
string new string new
string stdexcept string stdexcept
string string_view string string_view
string tuple string tuple
string type_traits string type_traits
string typeinfo string typeinfo
string utility string utility
string vector
string version string version
string_view algorithm string_view algorithm
string_view compare string_view compare
string_view concepts string_view concepts
string_view cstddef string_view cstddef
string_view cstdint string_view cstdint
string_view cstdio string_view cstdio
string_view cstdlib string_view cstdlib
string_view cstring string_view cstring
string_view cwchar string_view cwchar
string_view functional string_view functional
string_view initializer_list string_view initializer_list
string_view iosfwd string_view iosfwd
string_view iterator string_view iterator
string_view limits string_view limits
string_view stdexcept string_view stdexcept
string_view type_traits string_view type_traits
string_view version string_view version
strstream istream strstream istream
strstream ostream strstream ostream
strstream version strstream version
system_error cerrno system_error cerrno
system_error compare system_error compare
system_error cstddef
system_error cstdint system_error cstdint
system_error cstring system_error cstring
system_error limits system_error limits
system_error stdexcept
system_error string system_error string
system_error type_traits system_error type_traits
system_error version system_error version
thread array
thread cerrno thread cerrno
thread chrono thread chrono
thread compare thread compare
thread cstddef thread cstddef
thread cstdint thread cstdint
thread cstdlib
thread cstring thread cstring
thread ctime thread ctime
thread functional thread functional
thread iosfwd thread iosfwd
thread limits thread limits
thread locale
thread new thread new
thread ratio thread ratio
thread stdexcept thread stdexcept
thread string thread string
thread string_view
thread system_error thread system_error
thread tuple thread tuple
thread type_traits thread type_traits
thread version thread version
tuple compare tuple compare
tuple cstddef tuple cstddef
tuple exception tuple exception
tuple iosfwd tuple iosfwd
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines
variant limits variant limits
variant new variant new
variant tuple variant tuple
variant type_traits variant type_traits
variant typeinfo variant typeinfo
variant utility variant utility
variant version variant version
vector algorithm vector algorithm
vector array
vector atomic vector atomic
vector cerrno
vector climits vector climits
vector compare vector compare
vector concepts vector concepts
vector cstddef vector cstddef
vector cstdint vector cstdint
vector cstdlib vector cstdlib
vector cstring vector cstring
vector initializer_list vector initializer_list
vector iosfwd vector iosfwd
vector limits vector limits
vector locale
vector new vector new
vector stdexcept vector stdexcept
vector string
vector string_view
vector tuple vector tuple
vector type_traits vector type_traits
vector typeinfo vector typeinfo
vector utility vector utility
vector version vector version

libcxx/test/libcxx/transitive_includes/cxx11.csv

Show First 20 Lines • Show All 392 Lines • ▼ Show 20 Lines
functional tuple functional tuple
functional type_traits functional type_traits
functional typeinfo functional typeinfo
functional unordered_map functional unordered_map
functional utility functional utility
functional vector functional vector
functional version functional version
future atomic future atomic
future cerrno
future chrono future chrono
future cstddef future cstddef
future cstdint future cstdint
future cstdlib future cstdlib
future cstring future cstring
future exception future exception
future initializer_list future initializer_list
future iosfwd future iosfwd
▲ Show 20 Lines • Show All 401 Lines • ▼ Show 20 Lines
string limits string limits
string new string new
string stdexcept string stdexcept
string string_view string string_view
string tuple string tuple
string type_traits string type_traits
string typeinfo string typeinfo
string utility string utility
string vector
string version string version
string_view algorithm string_view algorithm
string_view compare string_view compare
string_view concepts string_view concepts
string_view cstddef string_view cstddef
string_view cstdint string_view cstdint
string_view cstdio string_view cstdio
string_view cstdlib string_view cstdlib
string_view cstring string_view cstring
string_view cwchar string_view cwchar
string_view functional string_view functional
string_view initializer_list string_view initializer_list
string_view iosfwd string_view iosfwd
string_view iterator string_view iterator
string_view limits string_view limits
string_view stdexcept string_view stdexcept
string_view type_traits string_view type_traits
string_view version string_view version
strstream istream strstream istream
strstream ostream strstream ostream
strstream version strstream version
system_error cerrno system_error cerrno
system_error compare system_error compare
system_error cstddef
system_error cstdint system_error cstdint
system_error cstring system_error cstring
system_error limits system_error limits
system_error stdexcept
system_error string system_error string
system_error type_traits system_error type_traits
system_error version system_error version
thread array
thread cerrno thread cerrno
thread chrono thread chrono
thread compare thread compare
thread cstddef thread cstddef
thread cstdint thread cstdint
thread cstdlib
thread cstring thread cstring
thread ctime thread ctime
thread functional thread functional
thread iosfwd thread iosfwd
thread limits thread limits
thread locale
thread new thread new
thread ratio thread ratio
thread stdexcept thread stdexcept
thread string thread string
thread string_view
thread system_error thread system_error
thread tuple thread tuple
thread type_traits thread type_traits
thread version thread version
tuple compare tuple compare
tuple cstddef tuple cstddef
tuple exception tuple exception
tuple iosfwd tuple iosfwd
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines
variant limits variant limits
variant new variant new
variant tuple variant tuple
variant type_traits variant type_traits
variant typeinfo variant typeinfo
variant utility variant utility
variant version variant version
vector algorithm vector algorithm
vector array
vector atomic vector atomic
vector cerrno
vector climits vector climits
vector compare vector compare
vector concepts vector concepts
vector cstddef vector cstddef
vector cstdint vector cstdint
vector cstdlib vector cstdlib
vector cstring vector cstring
vector initializer_list vector initializer_list
vector iosfwd vector iosfwd
vector limits vector limits
vector locale
vector new vector new
vector stdexcept vector stdexcept
vector string
vector string_view
vector tuple vector tuple
vector type_traits vector type_traits
vector typeinfo vector typeinfo
vector utility vector utility
vector version vector version

libcxx/test/libcxx/transitive_includes/cxx14.csv

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines
functional tuple functional tuple
functional type_traits functional type_traits
functional typeinfo functional typeinfo
functional unordered_map functional unordered_map
functional utility functional utility
functional vector functional vector
functional version functional version
future atomic future atomic
future cerrno
future chrono future chrono
future cstddef future cstddef
future cstdint future cstdint
future cstdlib future cstdlib
future cstring future cstring
future exception future exception
future initializer_list future initializer_list
future iosfwd future iosfwd
▲ Show 20 Lines • Show All 401 Lines • ▼ Show 20 Lines
string limits string limits
string new string new
string stdexcept string stdexcept
string string_view string string_view
string tuple string tuple
string type_traits string type_traits
string typeinfo string typeinfo
string utility string utility
string vector
string version string version
string_view algorithm string_view algorithm
string_view compare string_view compare
string_view concepts string_view concepts
string_view cstddef string_view cstddef
string_view cstdint string_view cstdint
string_view cstdio string_view cstdio
string_view cstdlib string_view cstdlib
string_view cstring string_view cstring
string_view cwchar string_view cwchar
string_view functional string_view functional
string_view initializer_list string_view initializer_list
string_view iosfwd string_view iosfwd
string_view iterator string_view iterator
string_view limits string_view limits
string_view stdexcept string_view stdexcept
string_view type_traits string_view type_traits
string_view version string_view version
strstream istream strstream istream
strstream ostream strstream ostream
strstream version strstream version
system_error cerrno system_error cerrno
system_error compare system_error compare
system_error cstddef
system_error cstdint system_error cstdint
system_error cstring system_error cstring
system_error limits system_error limits
system_error stdexcept
system_error string system_error string
system_error type_traits system_error type_traits
system_error version system_error version
thread array
thread cerrno thread cerrno
thread chrono thread chrono
thread compare thread compare
thread cstddef thread cstddef
thread cstdint thread cstdint
thread cstdlib
thread cstring thread cstring
thread ctime thread ctime
thread functional thread functional
thread iosfwd thread iosfwd
thread limits thread limits
thread locale
thread new thread new
thread ratio thread ratio
thread stdexcept thread stdexcept
thread string thread string
thread string_view
thread system_error thread system_error
thread tuple thread tuple
thread type_traits thread type_traits
thread version thread version
tuple compare tuple compare
tuple cstddef tuple cstddef
tuple exception tuple exception
tuple iosfwd tuple iosfwd
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines
variant limits variant limits
variant new variant new
variant tuple variant tuple
variant type_traits variant type_traits
variant typeinfo variant typeinfo
variant utility variant utility
variant version variant version
vector algorithm vector algorithm
vector array
vector atomic vector atomic
vector cerrno
vector climits vector climits
vector compare vector compare
vector concepts vector concepts
vector cstddef vector cstddef
vector cstdint vector cstdint
vector cstdlib vector cstdlib
vector cstring vector cstring
vector initializer_list vector initializer_list
vector iosfwd vector iosfwd
vector limits vector limits
vector locale
vector new vector new
vector stdexcept vector stdexcept
vector string
vector string_view
vector tuple vector tuple
vector type_traits vector type_traits
vector typeinfo vector typeinfo
vector utility vector utility
vector version vector version

libcxx/test/libcxx/transitive_includes/cxx17.csv

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines
functional tuple functional tuple
functional type_traits functional type_traits
functional typeinfo functional typeinfo
functional unordered_map functional unordered_map
functional utility functional utility
functional vector functional vector
functional version functional version
future atomic future atomic
future cerrno
future chrono future chrono
future cstddef future cstddef
future cstdint future cstdint
future cstdlib future cstdlib
future cstring future cstring
future exception future exception
future initializer_list future initializer_list
future iosfwd future iosfwd
▲ Show 20 Lines • Show All 401 Lines • ▼ Show 20 Lines
string limits string limits
string new string new
string stdexcept string stdexcept
string string_view string string_view
string tuple string tuple
string type_traits string type_traits
string typeinfo string typeinfo
string utility string utility
string vector
string version string version
string_view algorithm string_view algorithm
string_view compare string_view compare
string_view concepts string_view concepts
string_view cstddef string_view cstddef
string_view cstdint string_view cstdint
string_view cstdio string_view cstdio
string_view cstdlib string_view cstdlib
string_view cstring string_view cstring
string_view cwchar string_view cwchar
string_view functional string_view functional
string_view initializer_list string_view initializer_list
string_view iosfwd string_view iosfwd
string_view iterator string_view iterator
string_view limits string_view limits
string_view stdexcept string_view stdexcept
string_view type_traits string_view type_traits
string_view version string_view version
strstream istream strstream istream
strstream ostream strstream ostream
strstream version strstream version
system_error cerrno system_error cerrno
system_error compare system_error compare
system_error cstddef
system_error cstdint system_error cstdint
system_error cstring system_error cstring
system_error limits system_error limits
system_error stdexcept
system_error string system_error string
system_error type_traits system_error type_traits
system_error version system_error version
thread array
thread cerrno thread cerrno
thread chrono thread chrono
thread compare thread compare
thread cstddef thread cstddef
thread cstdint thread cstdint
thread cstdlib
thread cstring thread cstring
thread ctime thread ctime
thread functional thread functional
thread iosfwd thread iosfwd
thread limits thread limits
thread locale
thread new thread new
thread ratio thread ratio
thread stdexcept thread stdexcept
thread string thread string
thread string_view
thread system_error thread system_error
thread tuple thread tuple
thread type_traits thread type_traits
thread version thread version
tuple compare tuple compare
tuple cstddef tuple cstddef
tuple exception tuple exception
tuple iosfwd tuple iosfwd
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines
variant limits variant limits
variant new variant new
variant tuple variant tuple
variant type_traits variant type_traits
variant typeinfo variant typeinfo
variant utility variant utility
variant version variant version
vector algorithm vector algorithm
vector array
vector atomic vector atomic
vector cerrno
vector climits vector climits
vector compare vector compare
vector concepts vector concepts
vector cstddef vector cstddef
vector cstdint vector cstdint
vector cstdlib vector cstdlib
vector cstring vector cstring
vector initializer_list vector initializer_list
vector iosfwd vector iosfwd
vector limits vector limits
vector locale
vector new vector new
vector stdexcept vector stdexcept
vector string
vector string_view
vector tuple vector tuple
vector type_traits vector type_traits
vector typeinfo vector typeinfo
vector utility vector utility
vector version vector version

libcxx/test/libcxx/transitive_includes/cxx20.csv

Show First 20 Lines • Show All 401 Lines • ▼ Show 20 Lines
functional tuple functional tuple
functional type_traits functional type_traits
functional typeinfo functional typeinfo
functional unordered_map functional unordered_map
functional utility functional utility
functional vector functional vector
functional version functional version
future atomic future atomic
future cerrno
future cstddef future cstddef
future cstdint future cstdint
future cstdlib future cstdlib
future cstring future cstring
future exception future exception
future initializer_list future initializer_list
future iosfwd future iosfwd
future limits future limits
▲ Show 20 Lines • Show All 400 Lines • ▼ Show 20 Lines
string limits string limits
string new string new
string stdexcept string stdexcept
string string_view string string_view
string tuple string tuple
string type_traits string type_traits
string typeinfo string typeinfo
string utility string utility
string vector
string version string version
string_view algorithm string_view algorithm
string_view compare string_view compare
string_view concepts string_view concepts
string_view cstddef string_view cstddef
string_view cstdint string_view cstdint
string_view cstdio string_view cstdio
string_view cstdlib string_view cstdlib
string_view cstring string_view cstring
string_view cwchar string_view cwchar
string_view functional string_view functional
string_view initializer_list string_view initializer_list
string_view iosfwd string_view iosfwd
string_view iterator string_view iterator
string_view limits string_view limits
string_view stdexcept string_view stdexcept
string_view type_traits string_view type_traits
string_view version string_view version
strstream istream strstream istream
strstream ostream strstream ostream
strstream version strstream version
system_error cerrno system_error cerrno
system_error compare system_error compare
system_error cstddef
system_error cstdint system_error cstdint
system_error cstring system_error cstring
system_error limits system_error limits
system_error stdexcept
system_error string system_error string
system_error type_traits system_error type_traits
system_error version system_error version
thread array
thread cerrno thread cerrno
thread compare thread compare
thread cstddef thread cstddef
thread cstdint thread cstdint
thread cstdlib
thread cstring thread cstring
thread ctime thread ctime
thread functional thread functional
thread iosfwd thread iosfwd
thread limits thread limits
thread locale
thread new thread new
thread ratio thread ratio
thread stdexcept thread stdexcept
thread string thread string
thread string_view
thread system_error thread system_error
thread tuple thread tuple
thread type_traits thread type_traits
thread version thread version
tuple compare tuple compare
tuple cstddef tuple cstddef
tuple exception tuple exception
tuple iosfwd tuple iosfwd
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines
variant limits variant limits
variant new variant new
variant tuple variant tuple
variant type_traits variant type_traits
variant typeinfo variant typeinfo
variant utility variant utility
variant version variant version
vector algorithm vector algorithm
vector array
vector atomic vector atomic
vector cerrno
vector climits vector climits
vector compare vector compare
vector concepts vector concepts
vector cstddef vector cstddef
vector cstdint vector cstdint
vector cstdlib vector cstdlib
vector cstring vector cstring
vector initializer_list vector initializer_list
vector iosfwd vector iosfwd
vector limits vector limits
vector locale
vector new vector new
vector stdexcept vector stdexcept
vector string
vector string_view
vector tuple vector tuple
vector type_traits vector type_traits
vector typeinfo vector typeinfo
vector utility vector utility
vector version vector version

libcxx/test/libcxx/transitive_includes/cxx2b.csv

Show First 20 Lines • Show All 640 Lines • ▼ Show 20 Lines
variant cstddef variant cstddef
variant cstdint variant cstdint
variant cstring variant cstring
variant initializer_list variant initializer_list
variant limits variant limits
variant new variant new
variant tuple variant tuple
variant version variant version
vector array
vector cerrno
vector climits vector climits
vector compare vector compare
vector cstddef vector cstddef
vector cstdint vector cstdint
vector cstdlib
vector cstring vector cstring
vector initializer_list vector initializer_list
vector iosfwd vector iosfwd
vector limits vector limits
vector locale
vector new vector new
vector stdexcept vector stdexcept
vector string
vector string_view
vector tuple vector tuple
vector version vector version

libcxx/test/std/containers/sequences/vector.bool/vector.bool.fmt/types.compile.pass.cpp

  • This file was added.
//===----------------------------------------------------------------------===//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
// UNSUPPORTED: libcpp-has-no-incomplete-format
// <vector>
// template<class T, class charT> requires is-vector-bool-reference<T>
// struct formatter<T, charT>;
// [format.formatter.spec]/4
// If the library provides an explicit or partial specialization of
// formatter<T, charT>, that specialization is enabled and meets the
// Formatter requirements except as noted otherwise.
//
// Tests parts of the BasicFormatter requirements. Like the formattable concept
// it uses the semiregular concept. It test does not use the formattable
// concept since it is the intention the formatter is available without
// including the format header.
// TODO FMT Evaluate what to do with [format.formatter.spec]/2
// [format.formatter.spec]/2
// Each header that declares the template formatter provides the following
// enabled specializations:
// Then there is a list of formatters, but is that really useful?
// Note this should be discussed in LEWG.
#include <concepts>
#include <vector>
#include "test_macros.h"
static_assert(std::semiregular<std::formatter<std::vector<bool>::reference, char>>);
#ifndef TEST_HAS_NO_WIDE_CHARACTERS
static_assert(std::semiregular<std::formatter<std::vector<bool>::reference, wchar_t>>);
#endif