This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Track liveins for max-ilp-sched-strategy
ClosedPublic

Authored by jrbyrnes on Apr 27 2023, 10:11 AM.

Details

Summary

Even if optimizing for ILP, it is still useful to track RP to avoid spilling. Given that, we need to maintin consistent liveness state with the RP tracker. This patch makes RP tracking consistent by updating for liveins.

Otherwise, we should completely eliminate RP tracking for this scheduler (checkScheduling, initCandidate).

Diff Detail

Event Timeline

jrbyrnes created this revision.Apr 27 2023, 10:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 10:11 AM
jrbyrnes requested review of this revision.Apr 27 2023, 10:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 10:11 AM
rampitec accepted this revision.Apr 27 2023, 11:17 AM

LGTM with couple nits.

llvm/test/CodeGen/AMDGPU/schedule-ilp-liveness-tracking.mir
3

Please remove double whitespace before -run-pass.

35

Please remove blank line.

This revision is now accepted and ready to land.Apr 27 2023, 11:17 AM
jrbyrnes updated this revision to Diff 517673.Apr 27 2023, 12:13 PM
jrbyrnes marked 2 inline comments as done.

Nits

rampitec added inline comments.Apr 27 2023, 2:11 PM
llvm/test/CodeGen/AMDGPU/schedule-ilp-liveness-tracking.mir
34

Something wrong going on with this newline. Was it DOS style and now missing?

jrbyrnes updated this revision to Diff 517751.Apr 27 2023, 4:38 PM

Pesky newline

rampitec accepted this revision.Apr 27 2023, 4:39 PM
This revision was landed with ongoing or failed builds.Apr 27 2023, 4:46 PM
This revision was automatically updated to reflect the committed changes.