[HWASAN] Run sanitizer_common tests

[vitalybuka]

Summary

ninja check-sanitizer will run tests with hwasan as well

[vitalybuka]

remove xfails

[dyung]

Hi @vitalybuka , you may already be aware of it (I see you are making fixes in this area in follow-up commits), but this change caused a test failure on at least one bot that still seems to be failing. Please take a look and fix it if you can or XFAIL or revert if not.

https://lab.llvm.org/buildbot/#/builders/247/builds/3924

[vitalybuka]

In D149234#4300589, @dyung wrote:

Hi @vitalybuka , you may already be aware of it (I see you are making fixes in this area in follow-up commits), but this change caused a test failure on at least one bot that still seems to be failing. Please take a look and fix it if you can or XFAIL or revert if not.

https://lab.llvm.org/buildbot/#/builders/247/builds/3924

Thanks for pointer, I'll fix or revert soon.

[DavidSpickett]

These tests appear to fail on bots that are not building lld: https://lab.llvm.org/buildbot/#/builders/179/builds/6024

It is required that they use lld, should there be a dependency here?

[awarzynski]

In D149234#4301524, @DavidSpickett wrote:

These tests appear to fail on bots that are not building lld: https://lab.llvm.org/buildbot/#/builders/179/builds/6024

It is required that they use lld, should there be a dependency here?

@vitalybuka Could you take a look, please? I am very unfamiliar with HWSAN, but all the failing tests are "hwsan" related and started appearing after 3 HWSAN related changes landed. This one and:

• https://reviews.llvm.org/D149271
• https://reviews.llvm.org/D149219

All authored by you :) If you have no access to an AArch64 machine, I am happy to help with testing.

[vitalybuka]

In D149234#4312384, @awarzynski wrote:

In D149234#4301524, @DavidSpickett wrote:

These tests appear to fail on bots that are not building lld: https://lab.llvm.org/buildbot/#/builders/179/builds/6024

It is required that they use lld, should there be a dependency here?

@vitalybuka Could you take a look, please? I am very unfamiliar with HWSAN, but all the failing tests are "hwsan" related and started appearing after 3 HWSAN related changes landed. This one and:

• https://reviews.llvm.org/D149271
• https://reviews.llvm.org/D149219

All authored by you :) If you have no access to an AArch64 machine, I am happy to help with testing.

Sorry, I just notices. I will fix today.
We have arm but we use lld there :) There is a bug in ld which manifests with hwasan.
So I guess we need to disabled hwasan without lld.
What is confuses me, that we landed similar stuff for lsan+hwasan few month ago, and I don't see failures on that bot. And seems check-all does not run lsan tests.

[awarzynski]

In D149234#4312801, @vitalybuka wrote:

In D149234#4312384, @awarzynski wrote:

In D149234#4301524, @DavidSpickett wrote:

These tests appear to fail on bots that are not building lld: https://lab.llvm.org/buildbot/#/builders/179/builds/6024

It is required that they use lld, should there be a dependency here?

@vitalybuka Could you take a look, please? I am very unfamiliar with HWSAN, but all the failing tests are "hwsan" related and started appearing after 3 HWSAN related changes landed. This one and:

• https://reviews.llvm.org/D149271
• https://reviews.llvm.org/D149219

All authored by you :) If you have no access to an AArch64 machine, I am happy to help with testing.

Sorry, I just notices. I will fix today.

That would be much appreciated. This is affecting our SVE bot, and these are rare :)

We have arm but we use lld there :) There is a bug in ld which manifests with hwasan.
So I guess we need to disabled hwasan without lld.

+1

Once this is resolved, we could discuss installing lld on that bot. For that, however, we'd need to wait for @DavidSpickett to be back (he'll be away most of May).

[DavidSpickett]

This is correct but I’m not the only person who can deal with bots. Write
to the mailing list
https://lists.linaro.org/archives/list/[e-mail]/
and one of my Linaro colleagues can help you figure it out.

[vitalybuka]

LLD issue should be fixed now

compiler-rt/test/sanitizer_common/CMakeLists.txt

 set(SANITIZER_COMMON_LIT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
 
 set(SANITIZER_COMMON_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
 
 set(SANITIZER_COMMON_TESTSUITES)
 
 # FIXME(dliew): We should switch to COMPILER_RT_SANITIZERS_TO_BUILD instead of
 # the hard coded `SUPPORTED_TOOLS_INIT` list once we know that the other
 # sanitizers work.
-set(SUPPORTED_TOOLS_INIT asan lsan msan tsan ubsan)
+set(SUPPORTED_TOOLS_INIT asan lsan hwasan msan tsan ubsan)
 set(SUPPORTED_TOOLS)
   foreach(SANITIZER_TOOL ${SUPPORTED_TOOLS_INIT})
     string(TOUPPER ${SANITIZER_TOOL} SANITIZER_TOOL_UPPER)
     if (COMPILER_RT_HAS_${SANITIZER_TOOL_UPPER})
       list(APPEND SUPPORTED_TOOLS ${SANITIZER_TOOL})
     endif()
   endforeach()
 

compiler-rt/test/sanitizer_common/TestCases/Linux/allow_user_segv.cpp

 // Regression test for
 // https://code.google.com/p/address-sanitizer/issues/detail?id=180
 // Fails with debug checks: https://bugs.llvm.org/show_bug.cgi?id=46860
 // XFAIL: !compiler-rt-optimized && tsan
 
+// FIXME: Implement.
+// XFAIL: hwasan
+
 // RUN: %clangxx -O0 %s -o %t
 
 // RUN: %env_tool_opts=handle_segv=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0
 // RUN: %env_tool_opts=handle_segv=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1
 // RUN: %env_tool_opts=handle_segv=2 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK2
 
 // RUN: %env_tool_opts=handle_segv=0:allow_user_segv_handler=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0
 // RUN: %env_tool_opts=handle_segv=1:allow_user_segv_handler=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK2

compiler-rt/test/sanitizer_common/TestCases/Linux/deepbind.cpp

 // RUN: %clangxx %s -o %t && %run not %t 1 2>&1 | FileCheck %s
 // UNSUPPORTED: lsan,ubsan,android
 
+// FIXME: Implement.
+// XFAIL: hwasan
+
 #include <dlfcn.h>
 #include <stdio.h>
 #include <string>
 
 int main (int argc, char *argv[]) {
   // CHECK: You are trying to dlopen a <arbitrary path> shared library with RTLD_DEEPBIND flag
   void *lib = dlopen("<arbitrary path>", RTLD_NOW | RTLD_DEEPBIND);
   return 0;
 }

compiler-rt/test/sanitizer_common/TestCases/Linux/malloc_usable_size.c

 // RUN: %clang -O2 %s -o %t && %run %t
 
-// Ubsan does not provide allocator.
-// UNSUPPORTED: ubsan
+// Must not be implemented, no other reason to install interceptors.
+// XFAIL: ubsan
+
+// FIXME: Implement.
+// XFAIL: hwasan
 
 #include <assert.h>
 #include <malloc.h>
 #include <sanitizer/allocator_interface.h>
 #include <stdlib.h>
 
 int main() {
   assert(__sanitizer_get_allocated_size(NULL) == 0);

compiler-rt/test/sanitizer_common/TestCases/Linux/mlock_test.cpp

+// Test that sanitizers suppress mlock.
 // RUN: %clang  %s -o %t && %run %t
-// XFAIL: ubsan,lsan
+
+// No shadow, so no need to disable mlock.
+// XFAIL: ubsan, lsan
 
+// FIXME: Implement.
+// XFAIL: hwasan
+
 #include <assert.h>
 #include <sys/mman.h>
 
 int main() {
+#if defined(__has_feature)
+#  if __has_feature(hwaddress_sanitizer)
+  // Don't mlock, it may claim all memory.
+  abort();
+#  endif
+#endif
   assert(0 == mlockall(MCL_CURRENT));
   assert(0 == mlock((void *)0x12345, 0x5678));
   assert(0 == munlockall());
   assert(0 == munlock((void *)0x987, 0x654));
 }
-

compiler-rt/test/sanitizer_common/TestCases/Posix/dump_registers.cpp

 // Check that sanitizer prints registers dump_registers on dump_registers=1
 // RUN: %clangxx  %s -o %t
 // RUN: %env_tool_opts=dump_registers=0 %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-NODUMP
 // RUN: %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-DUMP
 //
 // FIXME: Implement.
-// UNSUPPORTED: asan
-// UNSUPPORTED: lsan
-// UNSUPPORTED: msan
-// UNSUPPORTED: tsan
-// UNSUPPORTED: ubsan
+// XFAIL: *
 
 #include <signal.h>
 
 int main() {
   raise(SIGSEGV);
   // CHECK-DUMP: Register values
   // CHECK-NODUMP-NOT: Register values
   return 0;
 }

compiler-rt/test/sanitizer_common/TestCases/Posix/mmap_write_exec.cpp

 // RUN: %clangxx %s -o %t
 // RUN: %env_tool_opts=detect_write_exec=1 %run %t 2>&1 | FileCheck %s
 // RUN: %env_tool_opts=detect_write_exec=0 %run %t 2>&1 | FileCheck %s \
 // RUN:   --check-prefix=CHECK-DISABLED
 // ubsan and lsan do not install mmap interceptors UNSUPPORTED: ubsan, lsan
 
 // TODO: Fix option on Android, it hangs there for unknown reasons.
 // XFAIL: android
 
+// FIXME: Implement.
+// XFAIL: hwasan
+
 #if defined(__APPLE__)
 #include <Availability.h>
 #endif
 #include <pthread.h>
 #include <stdio.h>
 #include <sys/mman.h>
 
 int main(int argc, char **argv) {

compiler-rt/test/sanitizer_common/TestCases/Posix/print-module-map.cpp

 // RUN: %env_tool_opts="print_module_map=2:halt_on_error=1" not %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-MM2
 
 // tsan support pending rdar://67747473
 // XFAIL: tsan
 
 // FIXME: Add linux support.
 // XFAIL: msan && target={{.*linux.*}}
 
-// FIXME: Add lsan support.
-// XFAIL: lsan
+// FIXME: Implement.
+// XFAIL: lsan, hwasan
 
 int global;
 
 int main() {
 #if defined(USING_ubsan)
   int value = 5;
   int computation = value / 0; // Division by zero.
 #else

compiler-rt/test/sanitizer_common/TestCases/Posix/weak_hook_test.cpp

 // Test the weak hooks.
-// RUN: %clangxx %s -o %t
-// RUN: %run %t
+// RUN: %clangxx %s -o %t && %run %t
 
-// Hooks are not implemented for lsan.
-// XFAIL: lsan
-// XFAIL: ubsan
+// Must not be implemented, no other reason to install interceptors.
+// XFAIL: lsan, ubsan
+
+// FIXME: Implement.
+// XFAIL: hwasan
 
 #include <assert.h>
 #include <string.h>
 #if defined(_GNU_SOURCE)
 #include <strings.h> // for bcmp
 #endif
 
 bool seen_memcmp, seen_strncmp, seen_strncasecmp, seen_strcmp, seen_strcasecmp,

compiler-rt/test/sanitizer_common/TestCases/get_allocated_begin.cpp

 // RUN: %clangxx -O0 -g %s -o %t && %run %t
 
-// UBSan does not have its own allocator
-// UNSUPPORTED: ubsan
+// Must not be implemented, no other reason to install interceptors.
+// XFAIL: ubsan
+
+// FIXME: Implement.
+// XFAIL: hwasan
 
 #include <assert.h>
 #include <sanitizer/allocator_interface.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
 // Based on lib/msan/tests/msan_test.cpp::get_allocated_size_and_ownership

compiler-rt/test/sanitizer_common/TestCases/malloc_hook.cpp

 // RUN: %clangxx -O2 %s -o %t && %run %t 2>&1 | FileCheck %s
 
 // Malloc/free hooks are not supported on Windows.
 // XFAIL: target={{.*windows-msvc.*}}
+
+// Must not be implemented, no other reason to install interceptors.
 // XFAIL: ubsan
 
+// FIXME: Implement.
+// XFAIL: hwasan
+
 #include <stdlib.h>
 #include <unistd.h>
 #include <sanitizer/allocator_interface.h>
 
 extern "C" {
 const volatile void *global_ptr;
 
 #define WRITE(s) write(1, s, sizeof(s))

compiler-rt/test/sanitizer_common/TestCases/max_allocation_size.cpp

 // RUN: %env_tool_opts=max_allocation_size_mb=2:allocator_may_return_null=0 \
 // RUN:   not %run %t strndup 2>&1 | FileCheck %s --check-prefix=CHECK-sCRASH
 // RUN: %env_tool_opts=max_allocation_size_mb=2:allocator_may_return_null=1 \
 // RUN:   %run %t strndup 2>&1 | FileCheck %s --check-prefix=CHECK-NULL
 
 // win32 is disabled due to failing errno tests.
 // UNSUPPORTED: ubsan, target={{.*windows-msvc.*}}
 
+// FIXME: Implement.
+// XFAIL: hwasan
+
 #include <assert.h>
 #include <errno.h>
 #include <limits>
 #include <new>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 

compiler-rt/test/sanitizer_common/lit.common.cfg.py

 # -*- Python -*-
 
 # Setup source root.
 config.test_source_root = os.path.join(os.path.dirname(__file__), "TestCases")
 
 config.name = "SanitizerCommon-" + config.name_suffix
 
 default_tool_options = []
 collect_stack_traces = ""
 if config.tool_name == "asan":
   tool_cflags = ["-fsanitize=address"]
   tool_options = "ASAN_OPTIONS"
+elif config.tool_name == "hwasan":
+  tool_cflags = ["-fsanitize=hwaddress", "-fuse-ld=lld"]
+  if config.target_arch == "x86_64":
+    tool_cflags += ["-fsanitize-hwaddress-experimental-aliasing"]
+  tool_options = "HWASAN_OPTIONS"
 elif config.tool_name == "tsan":
   tool_cflags = ["-fsanitize=thread"]
   tool_options = "TSAN_OPTIONS"
 elif config.tool_name == "msan":
   tool_cflags = ["-fsanitize=memory"]
   tool_options = "MSAN_OPTIONS"
   collect_stack_traces = "-fsanitize-memory-track-origins"
 elif config.tool_name == "lsan":