This is an archive of the discontinued LLVM Phabricator instance.

ValueTracking: Fix InterestedClasses logic for fadd/fsub
AbandonedPublic

Authored by arsenm on Apr 25 2023, 1:15 PM.

Reviewers

Summary

This was early exiting for -0 queries.

arsenm requested review of this revision.Apr 25 2023, 1:15 PM

This revision is now accepted and ready to land.Apr 26 2023, 12:16 AM

Squashed into D148575

Path

Size

llvm/

lib/

Analysis/

3 lines

Show First 20 Lines • Show All 4,610 Lines • ▼ Show 20 Lines	void computeKnownFPClass(const Value *V, const APInt &DemandedElts,
case Instruction::FAdd:		case Instruction::FAdd:
case Instruction::FSub: {		case Instruction::FSub: {
KnownFPClass KnownLHS, KnownRHS;		KnownFPClass KnownLHS, KnownRHS;

bool WantNegative =		bool WantNegative =
Op->getOpcode() == Instruction::FAdd &&		Op->getOpcode() == Instruction::FAdd &&
(InterestedClasses & (fcNegative & ~fcNegZero)) != fcNone;		(InterestedClasses & (fcNegative & ~fcNegZero)) != fcNone;
bool WantNaN = (InterestedClasses & fcNan) != fcNone;		bool WantNaN = (InterestedClasses & fcNan) != fcNone;
		bool WantNegZero = (InterestedClasses & fcNegZero) != fcNone;

if (!WantNaN && !WantNegative)		if (!WantNaN && !WantNegative && !WantNegZero)
break;		break;

computeKnownFPClass(Op->getOperand(1), DemandedElts, fcNan \| fcInf,		computeKnownFPClass(Op->getOperand(1), DemandedElts, fcNan \| fcInf,
KnownRHS, Depth + 1, Q, TLI);		KnownRHS, Depth + 1, Q, TLI);

if ((WantNaN && KnownRHS.isKnownNeverNaN()) \|\|		if ((WantNaN && KnownRHS.isKnownNeverNaN()) \|\|
(WantNegative && KnownRHS.cannotBeOrderedLessThanZero()) \|\|		(WantNegative && KnownRHS.cannotBeOrderedLessThanZero()) \|\|
KnownRHS.isKnownNeverNegZero() \|\| Opc == Instruction::FSub) {		KnownRHS.isKnownNeverNegZero() \|\| Opc == Instruction::FSub) {
▲ Show 20 Lines • Show All 3,834 Lines • Show Last 20 Lines