[mlir] ActionTracing: require ASSERTS for debugcounter test

[cota]

Summary

While at it, fix some typos.

[mehdi_amini]

Thanks for the fixed in the test, this should not require assertions though, I need to investigate what does not work as I intend! :)

[bkramer]

In D149159#4295853, @mehdi_amini wrote:

Thanks for the fixed in the test, this should not require assertions though, I need to investigate what does not work as I intend! :)

There's this NDEBUG check https://github.com/llvm/llvm-project/blob/main/mlir/lib/Debug/DebugCounter.cpp#L113

[mehdi_amini]

Thanks @bkramer ! Re-enabled in https://reviews.llvm.org/D149232 after removing the macro guard and confirming the test works with asserts disabled now.

mlir/test/mlir-opt/debugcounter.mlir

-// This test exercise the example in docs/ActionTracing.md ; changes here should
-// probably be reflected there.
+// This test exercises the example in docs/ActionTracing.md ; changes here
+// should probably be reflected there.
 
-// RUN: mlir-opt %s -mlir-debug-counter=unique-tag-for-my-action-skip=-1 -mlir-print-debug-counter --pass-pipeline="builtin.module(func.func(canonicalize))" --mlir-disable-threading 2>&1 | FileCheck %s --check-prefix=CHECK-UKNOWN-TAG
+// REQUIRES: asserts
+// RUN: mlir-opt %s -mlir-debug-counter=unique-tag-for-my-action-skip=-1 -mlir-print-debug-counter --pass-pipeline="builtin.module(func.func(canonicalize))" --mlir-disable-threading 2>&1 | FileCheck %s --check-prefix=CHECK-UNKNOWN-TAG
 // RUN: mlir-opt %s -mlir-debug-counter=pass-execution-skip=1 -mlir-print-debug-counter --pass-pipeline="builtin.module(func.func(canonicalize))" --mlir-disable-threading 2>&1 | FileCheck %s --check-prefix=CHECK-PASS
 
 func.func @foo() {
     return
 }
 
-// CHECK-UKNOWN-TAG:  DebugCounter counters:
-// CHECK-UKNOWN-TAG: unique-tag-for-my-action        : {0,-1,-1}
+// CHECK-UNKNOWN-TAG:  DebugCounter counters:
+// CHECK-UNKNOWN-TAG: unique-tag-for-my-action        : {0,-1,-1}
 
 // CHECK-PASS: DebugCounter counters:
 // CHECK-PASS: pass-execution                  : {1,1,-1}