This is an archive of the discontinued LLVM Phabricator instance.

Differential D149042

Drop MLIR Bazel dependency on LLVM Analysis
ClosedPublic

Authored by ftynse on Apr 24 2023, 12:34 AM.

Details

Reviewers
Dinistro
Commits
rG61cddaa2dabb: Drop MLIR Bazel dependency on LLVM Analysis
Summary

This is no longer necessary after f5425c128a30 and significatly
decreases the build time and the binary footprint.

Diff Detail

Event Timeline

ftynse created this revision.Apr 24 2023, 12:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2023, 12:34 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 23 others. · View Herald Transcript
ftynse requested review of this revision.Apr 24 2023, 12:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2023, 12:34 AM
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Dinistro accepted this revision.Apr 24 2023, 12:38 AM

LGTM! Glad to see that the changes to the LoopInfo helped resolve this issue.

This revision is now accepted and ready to land.Apr 24 2023, 12:38 AM
Harbormaster completed remote builds in B227642: Diff 516293.Apr 24 2023, 12:59 AM
ftynse added a comment.Apr 24 2023, 1:09 AM

The build was successful (it wouldn't have been if mlir:Analysis had still had a dependency on files from llvm:Analysis) The failing tests under Bazel are

@llvm-project//mlir/test/Dialect:IRDL/test-cmath.mlir.test               
@llvm-project//mlir/test/Dialect:IRDL/testd.mlir.test

which are not related to this change.

This revision was landed with ongoing or failed builds.Apr 24 2023, 1:10 AM
Closed by commit rG61cddaa2dabb: Drop MLIR Bazel dependency on LLVM Analysis (authored by ftynse). · Explain Why
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rG61cddaa2dabb: Drop MLIR Bazel dependency on LLVM Analysis.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
mlir/
1 line

Diff 516300

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 6,740 Lines • ▼ Show 20 Lines deps = [
":DataLayoutInterfaces", ":DataLayoutInterfaces",
":IR", ":IR",
":InferIntRangeInterface", ":InferIntRangeInterface",
":LoopLikeInterface", ":LoopLikeInterface",
":Pass", ":Pass",
":SideEffectInterfaces", ":SideEffectInterfaces",
":Support", ":Support",
":ViewLikeInterface", ":ViewLikeInterface",
"//llvm:Analysis",
"//llvm:Support", "//llvm:Support",
], ],
) )
cc_library( cc_library(
name = "TranslateLib", name = "TranslateLib",
srcs = glob([ srcs = glob([
"lib/Tools/mlir-translate/*.cpp", "lib/Tools/mlir-translate/*.cpp",
▲ Show 20 Lines • Show All 4,429 Lines • Show Last 20 Lines