This is an archive of the discontinued LLVM Phabricator instance.

Differential D148964

[mlir][sparse] avoid slice rewriting when conditions are not met
ClosedPublic

Authored by aartbik on Apr 21 2023, 2:41 PM.

Details

Reviewers
Peiming
nicolasvasilache
Commits
rGdbdb4affa007: [mlir][sparse] avoid slice rewriting when conditions are not met

Diff Detail

Event Timeline

aartbik created this revision.Apr 21 2023, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 2:41 PM
Herald added subscribers: bviyer, hanchung, jsetoain and 24 others. · View Herald Transcript
aartbik requested review of this revision.Apr 21 2023, 2:41 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 2:41 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Peiming added inline comments.Apr 21 2023, 2:48 PM
utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
7603 ↗(On Diff #515922)

is it intended?

Harbormaster completed remote builds in B227332: Diff 515922.Apr 21 2023, 3:01 PM
aartbik updated this revision to Diff 515930.Apr 21 2023, 3:16 PM
aartbik marked an inline comment as done.

removed unrelated stuff

Herald added a subscriber: hoy. · View Herald TranscriptApr 21 2023, 3:16 PM
Peiming accepted this revision.Apr 21 2023, 3:16 PM
This revision is now accepted and ready to land.Apr 21 2023, 3:16 PM
aartbik added inline comments.Apr 21 2023, 3:16 PM
utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
7603 ↗(On Diff #515922)

sorry about that, the "prep" tool looks at all build changes, also not included in CL ;-)

Harbormaster completed remote builds in B227339: Diff 515930.Apr 21 2023, 3:52 PM
Closed by commit rGdbdb4affa007: [mlir][sparse] avoid slice rewriting when conditions are not met (authored by aartbik). · Explain WhyApr 21 2023, 4:09 PM
This revision was automatically updated to reflect the committed changes.
aartbik added a commit: rGdbdb4affa007: [mlir][sparse] avoid slice rewriting when conditions are not met.

Revision Contents

PathSize
mlir/
lib/
Dialect/
SparseTensor/
Transforms/
6 lines

Diff 515930

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp

Show First 20 Lines • Show All 1,159 Lines • ▼ Show 20 Linespublic:
using OpConversionPattern::OpConversionPattern; using OpConversionPattern::OpConversionPattern;
LogicalResult LogicalResult
matchAndRewrite(tensor::ExtractSliceOp op, OpAdaptor adaptor, matchAndRewrite(tensor::ExtractSliceOp op, OpAdaptor adaptor,
ConversionPatternRewriter &rewriter) const override { ConversionPatternRewriter &rewriter) const override {
Location loc = op.getLoc(); Location loc = op.getLoc();
MLIRContext *ctx = op.getContext(); MLIRContext *ctx = op.getContext();
auto srcEnc = getSparseTensorEncoding(op.getSourceType()); auto srcEnc = getSparseTensorEncoding(op.getSourceType());
auto dstEnc = getSparseTensorEncoding(op.getResult().getType()); auto dstEnc = getSparseTensorEncoding(op.getResult().getType());
if (!srcEnc && !dstEnc)
return failure();
// TODO: We should check these in ExtractSliceOp::verify. // TODO: We should check these in ExtractSliceOp::verify.
assert(srcEnc && dstEnc && dstEnc.isSlice()); if (!srcEnc || !dstEnc || !dstEnc.isSlice())
return failure();
assert(srcEnc.getDimLevelType() == dstEnc.getDimLevelType()); assert(srcEnc.getDimLevelType() == dstEnc.getDimLevelType());
assert(srcEnc.getDimOrdering() == dstEnc.getDimOrdering()); assert(srcEnc.getDimOrdering() == dstEnc.getDimOrdering());
assert(srcEnc.getHigherOrdering() == dstEnc.getHigherOrdering()); assert(srcEnc.getHigherOrdering() == dstEnc.getHigherOrdering());
assert(srcEnc.getPosWidth() == dstEnc.getPosWidth()); assert(srcEnc.getPosWidth() == dstEnc.getPosWidth());
assert(srcEnc.getCrdWidth() == dstEnc.getCrdWidth()); assert(srcEnc.getCrdWidth() == dstEnc.getCrdWidth());
SmallVector<Value> fields; SmallVector<Value> fields;
auto desc = getMutDescriptorFromTensorTuple(adaptor.getSource(), fields); auto desc = getMutDescriptorFromTensorTuple(adaptor.getSource(), fields);
▲ Show 20 Lines • Show All 477 Lines • Show Last 20 Lines