[Clang][Sema] Fix invalid cast when validating SVE types within CheckVariableDeclarationType.

[paulwalker-arm]

Summary

Fixes #62087

[paulwalker-arm]

This is not my area so I don't know if replacing isFunctionOrMethod() rather than just extending the if clause is a bad idea, but all the tests still pass including the new one that would trigger an assert prior to this change.

[dmgreen]

This LGTM, but I don't remember why it was written this way. (I am not an expert in this area either). It seems to still give correct error messages with/without __attribute__((target("sve"))).

clang/lib/Sema/SemaDecl.cpp

void Sema::CheckVariableDeclarationType(VarDecl *NewVD) {
   if (Context.getTargetInfo().getTriple().isPPC64() &&
       !NewVD->isLocalVarDecl() &&
       CheckPPCMMAType(T, NewVD->getLocation())) {
     NewVD->setInvalidDecl();
     return;
   }
 
   // Check that SVE types are only used in functions with SVE available.
-  if (T->isSVESizelessBuiltinType() && CurContext->isFunctionOrMethod()) {
+  if (T->isSVESizelessBuiltinType() && isa<FunctionDecl>(CurContext)) {
     const FunctionDecl *FD = cast<FunctionDecl>(CurContext);
     llvm::StringMap<bool> CallerFeatureMap;
     Context.getFunctionFeatureMap(CallerFeatureMap, FD);
     if (!Builtin::evaluateRequiredTargetFeatures(
         "sve", CallerFeatureMap)) {
       Diag(NewVD->getLocation(), diag::err_sve_vector_in_non_sve_target) << T;
       NewVD->setInvalidDecl();
       return;

clang/test/SemaOpenMP/arm-sve-acle-types.cpp

+// RUN: %clang_cc1 -fopenmp -fsyntax-only -triple aarch64-arm-none-eabi -target-feature +sve -verify %s
+// expected-no-diagnostics
+
+__SVBool_t foo(int);
+
+void test() {
+#pragma omp parallel
+  {
+    __SVBool_t pg = foo(1);
+  }
+}