This is an archive of the discontinued LLVM Phabricator instance.

[bazel] Update Bazel version to 6.1.2.
ClosedPublic

Authored by aaronmondal on Apr 20 2023, 5:10 PM.

Details

Diff Detail

Event Timeline

aaronmondal created this revision.Apr 20 2023, 5:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 5:10 PM
aaronmondal requested review of this revision.Apr 20 2023, 5:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2023, 5:10 PM
aaronmondal added reviewers: Restricted Project, GMNGeoffrey, MaskRay, csigg.Apr 20 2023, 5:10 PM

SGTM, I'm not sure if LLVM has any policy w/ bazel versions like it does for host toolchains or CMake. (Probably not, since bazel is not an officially supported build system for LLVM). As long as CI passes, this should be fine. Any specific reason you're bumping it?

It it looks like buildkite failed for some unrelated reason. Can you retry it? https://buildkite.com/llvm-project/diff-checks/builds/166476#0187a125-f96b-4f16-9b2c-65aa85b14e90

Any specific reason you're bumping it?

Yes. The 5.x releases don't work properly with bzlmod, a new module system for Bazel which will become the default with Bazel 7 later this year and deprecate the WORKSPACE setup.

5.x also has some legacy functionality around platform/toolchain resolution that's mostly gone in 6.0 and shouldn't be used anymore. AFAIK the llvm-overlay doesn't use any of that, so it should generally be fine to just bump versions upon release.

@rupprecht Reran. Seems to work.

akuegel accepted this revision.Apr 20 2023, 11:50 PM
This revision is now accepted and ready to land.Apr 20 2023, 11:50 PM
MaskRay accepted this revision.Apr 21 2023, 9:31 AM
rupprecht accepted this revision.Apr 21 2023, 9:46 AM

@rupprecht Reran. Seems to work.

Awesome, thanks!

This revision was automatically updated to reflect the committed changes.