This is an archive of the discontinued LLVM Phabricator instance.

Differential D148612

[clang][dataflow] Use existing accessors to check for copy and move assignment ops.
ClosedPublic

Authored by mboehme on Apr 18 2023, 1:25 AM.

Details

Reviewers
NoQ
gribozavr2
Commits
rG6b85cc18eb7b: [clang][dataflow] Use existing accessors to check for copy and move assignment…

Diff Detail

Event Timeline

mboehme created this revision.Apr 18 2023, 1:25 AM
Herald added a reviewer: NoQ. · View Herald TranscriptApr 18 2023, 1:25 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: martong, xazax.hun. · View Herald Transcript
mboehme requested review of this revision.Apr 18 2023, 1:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2023, 1:25 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mboehme added a reviewer: gribozavr2.Apr 18 2023, 1:26 AM
Harbormaster completed remote builds in B226325: Diff 514557.Apr 18 2023, 2:34 AM
gribozavr2 accepted this revision.Apr 24 2023, 4:36 AM
This revision is now accepted and ready to land.Apr 24 2023, 4:36 AM
mboehme updated this revision to Diff 516378.Apr 24 2023, 6:11 AM

Rebased to head

Harbormaster completed remote builds in B227704: Diff 516378.Apr 24 2023, 7:25 AM
Closed by commit rG6b85cc18eb7b: [clang][dataflow] Use existing accessors to check for copy and move assignment… (authored by mboehme). · Explain WhyApr 24 2023, 7:32 AM
This revision was automatically updated to reflect the committed changes.
mboehme added a commit: rG6b85cc18eb7b: [clang][dataflow] Use existing accessors to check for copy and move assignment….

Revision Contents

PathSize
clang/
lib/
Analysis/
FlowSensitive/
9 lines

Diff 516378

clang/lib/Analysis/FlowSensitive/Transfer.cpp

Show First 20 Lines • Show All 640 Lines • ▼ Show 20 Lines if (S->getOperator() == OO_Equal) {
const Expr *Arg0 = S->getArg(0); const Expr *Arg0 = S->getArg(0);
assert(Arg0 != nullptr); assert(Arg0 != nullptr);
const Expr *Arg1 = S->getArg(1); const Expr *Arg1 = S->getArg(1);
assert(Arg1 != nullptr); assert(Arg1 != nullptr);
// Evaluate only copy and move assignment operators. // Evaluate only copy and move assignment operators.
auto *Arg0Type = Arg0->getType()->getUnqualifiedDesugaredType(); const auto *Method =
auto *Arg1Type = Arg1->getType()->getUnqualifiedDesugaredType(); dyn_cast_or_null<CXXMethodDecl>(S->getDirectCallee());
if (Arg0Type != Arg1Type) if (!Method)
return;
if (!Method->isCopyAssignmentOperator() &&
!Method->isMoveAssignmentOperator())
return; return;
auto *ObjectLoc = Env.getStorageLocation(*Arg0, SkipPast::Reference); auto *ObjectLoc = Env.getStorageLocation(*Arg0, SkipPast::Reference);
if (ObjectLoc == nullptr) if (ObjectLoc == nullptr)
return; return;
auto *Val = Env.getValue(*Arg1, SkipPast::Reference); auto *Val = Env.getValue(*Arg1, SkipPast::Reference);
if (Val == nullptr) if (Val == nullptr)
▲ Show 20 Lines • Show All 258 Lines • Show Last 20 Lines