This is an archive of the discontinued LLVM Phabricator instance.

Differential D148540

Summary: Fix for MemRefBuilder when using opaque pointers.
ClosedPublic

Authored by herhut on Apr 17 2023, 9:32 AM.

Details

Reviewers
ftynse
dcaballe
Commits
rG6a10381b6f12: [mlir][llvm] Fix for MemRefBuilder when using opaque pointers.
Summary

Loading the offset of an unranked memref descriptor is creating an invalid load.

Diff Detail

Event Timeline

herhut created this revision.Apr 17 2023, 9:32 AM
Herald added a reviewer: dcaballe. · View Herald TranscriptApr 17 2023, 9:32 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, Moerafaat, zero9178 and 23 others. · View Herald Transcript
herhut requested review of this revision.Apr 17 2023, 9:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 9:32 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B226130: Diff 514276.Apr 17 2023, 10:46 AM
ftynse accepted this revision.Apr 18 2023, 12:59 AM
This revision is now accepted and ready to land.Apr 18 2023, 12:59 AM
Closed by commit rG6a10381b6f12: [mlir][llvm] Fix for MemRefBuilder when using opaque pointers. (authored by herhut). · Explain WhyApr 18 2023, 1:02 AM
This revision was automatically updated to reflect the committed changes.
herhut added a commit: rG6a10381b6f12: [mlir][llvm] Fix for MemRefBuilder when using opaque pointers..

Revision Contents

PathSize
mlir/
lib/
Conversion/
LLVMCommon/
3 lines

Diff 514276

mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp

Show First 20 Lines • Show All 476 Lines • ▼ Show 20 Lines
} }
Value UnrankedMemRefDescriptor::offset(OpBuilder &builder, Location loc, Value UnrankedMemRefDescriptor::offset(OpBuilder &builder, Location loc,
LLVMTypeConverter &typeConverter, LLVMTypeConverter &typeConverter,
Value memRefDescPtr, Value memRefDescPtr,
LLVM::LLVMPointerType elemPtrType) { LLVM::LLVMPointerType elemPtrType) {
Value offsetPtr = Value offsetPtr =
offsetBasePtr(builder, loc, typeConverter, memRefDescPtr, elemPtrType); offsetBasePtr(builder, loc, typeConverter, memRefDescPtr, elemPtrType);
return builder.create<LLVM::LoadOp>(loc, offsetPtr); return builder.create<LLVM::LoadOp>(loc, typeConverter.getIndexType(),
offsetPtr);
} }
void UnrankedMemRefDescriptor::setOffset(OpBuilder &builder, Location loc, void UnrankedMemRefDescriptor::setOffset(OpBuilder &builder, Location loc,
LLVMTypeConverter &typeConverter, LLVMTypeConverter &typeConverter,
Value memRefDescPtr, Value memRefDescPtr,
LLVM::LLVMPointerType elemPtrType, LLVM::LLVMPointerType elemPtrType,
Value offset) { Value offset) {
Value offsetPtr = Value offsetPtr =
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines