[compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

[mgorny]

Summary

Mark the two dfsan tests that are known to be broken on glibc-2.37
as XFAIL, to make the test suite start passing on Gentoo again.

Bug: https://github.com/llvm/llvm-project/issues/60678

[thesamesam]

Yes, please. Obviously we want to fix it properly but right now it's a known issue and it's noise when checking for regressions weekly.

[browneee]

LGTM

release_shadow_space.c:29: size_t get_rss_kb(): Assertion `feof(f)' failed.

custom.cpp:1858: void test_sprintf(): Assertion `strcmp(buf, "Hello world!") == 0' failed.

Issue appears to be with the program rather than the instrumentation. Did the behavior of the the libc functions used in the test change?

[mgorny]

In D148496#4274352, @browneee wrote:

Issue appears to be with the program rather than the instrumentation. Did the behavior of the the libc functions used in the test change?

If the question was directed at me, then I'm afraid I don't know.

compiler-rt/test/dfsan/custom.cpp

+// https://github.com/llvm/llvm-project/issues/60678
+// XFAIL: glibc-2.37
+
 // RUN: %clang_dfsan %s -o %t && DFSAN_OPTIONS="strict_data_dependencies=0" %run %t
 // RUN: %clang_dfsan -DSTRICT_DATA_DEPENDENCIES %s -o %t && %run %t
 // RUN: %clang_dfsan -DORIGIN_TRACKING -mllvm -dfsan-track-origins=1 -mllvm -dfsan-combine-pointer-labels-on-load=false -DSTRICT_DATA_DEPENDENCIES %s -o %t && %run %t
 // RUN: %clang_dfsan -DORIGIN_TRACKING -mllvm -dfsan-track-origins=1 -mllvm -dfsan-combine-pointer-labels-on-load=false %s -o %t && DFSAN_OPTIONS="strict_data_dependencies=0" %run %t
 //
 // Tests custom implementations of various glibc functions.
 
 #pragma clang diagnostic ignored "-Wformat-extra-args"

compiler-rt/test/dfsan/release_shadow_space.c

+// https://github.com/llvm/llvm-project/issues/60678
+// XFAIL: glibc-2.37
+
 // DFSAN_OPTIONS=no_huge_pages_for_shadow=false RUN: %clang_dfsan %s -o %t && %run %t
 // DFSAN_OPTIONS=no_huge_pages_for_shadow=true RUN: %clang_dfsan %s -o %t && %run %t
 // DFSAN_OPTIONS=no_huge_pages_for_shadow=false RUN: %clang_dfsan %s -DORIGIN_TRACKING -mllvm -dfsan-track-origins=1 -o %t && %run %t
 // DFSAN_OPTIONS=no_huge_pages_for_shadow=true RUN: %clang_dfsan %s -DORIGIN_TRACKING -mllvm -dfsan-track-origins=1 -o %t && %run %t
 
 #include <assert.h>
 #include <sanitizer/dfsan_interface.h>
 #include <stdbool.h>

compiler-rt/test/lit.common.cfg.py

ldd_ver_cmd = subprocess.Popen(['ldd', '--version'],
                                  stdout=subprocess.PIPE,
                                  stderr=subprocess.DEVNULL,
                                  env={'LANG': 'C'})
   sout, _ = ldd_ver_cmd.communicate()
   ver_lines = sout.splitlines()
   if not config.android and len(ver_lines) and ver_lines[0].startswith(b"ldd "):
     from distutils.version import LooseVersion
     ver = LooseVersion(ver_lines[0].split()[-1].decode())
-    for required in ["2.27", "2.30", "2.34"]:
+    for required in ["2.27", "2.30", "2.34", "2.37"]:
       if ver >= LooseVersion(required):
         config.available_features.add("glibc-" + required)
 
 sancovcc_path = os.path.join(config.llvm_tools_dir, "sancov")
 if os.path.exists(sancovcc_path):
   config.available_features.add("has_sancovcc")
   config.substitutions.append( ("%sancovcc ", sancovcc_path) )