This is an archive of the discontinued LLVM Phabricator instance.

[mlir][math] Properly disable ctlz conversion in MathToFuncs.

Authored by vzakhari on Apr 16 2023, 1:15 PM.

Diff Detail

Event Timeline

vzakhari created this revision.Apr 16 2023, 1:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2023, 1:15 PM
vzakhari requested review of this revision.Apr 16 2023, 1:15 PM
mehdi_amini accepted this revision.Apr 16 2023, 3:43 PM



We could have added the test to the other file that already run without the option enabled.

This revision is now accepted and ready to land.Apr 16 2023, 3:43 PM
vzakhari added inline comments.Apr 16 2023, 3:49 PM

Thanks for the review. I do not think there is another test for math.ctlz that enables convert-math-to-funcs converter explicitly. @j2kun, can you please follow up on this comment?

I will merge it as-is shortly.

Thanks, Slava! This passes all of my tests.

What exactly is the followup here? I see the extra test added that ensures ctlz is not lowered when the flag is disabled. Is another test helpful?