This is an archive of the discontinued LLVM Phabricator instance.

[clang-repl] JITTargetAddress --> ExecutorAddr
ClosedPublic

Authored by junaire on Apr 15 2023, 9:39 AM.

Details

Summary

Signed-off-by: Jun Zhang <jun@junz.org>

Diff Detail

Event Timeline

junaire created this revision.Apr 15 2023, 9:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2023, 9:39 AM
junaire requested review of this revision.Apr 15 2023, 9:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2023, 9:39 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
junaire updated this revision to Diff 513924.Apr 15 2023, 9:45 AM

Avoid unnecessary changes

sgraenitz accepted this revision.Apr 15 2023, 2:51 PM

Thanks. Maybe you can fix this one detail and add a description like "Most of Orc and JITLink are movinng away from JITTargetAddress and use ExecutorAddr instead"? Otherwise LGTM.

clang/lib/Interpreter/IncrementalExecutor.cpp
89

I think Sym is a Expected<ExecutorAddr> already

This revision is now accepted and ready to land.Apr 15 2023, 2:51 PM
junaire marked an inline comment as done.Apr 15 2023, 6:47 PM
junaire added inline comments.
clang/lib/Interpreter/IncrementalExecutor.cpp
89

good catch, thx!

This revision was landed with ongoing or failed builds.Apr 15 2023, 6:47 PM
This revision was automatically updated to reflect the committed changes.
junaire marked an inline comment as done.