remove useless condition in assert in SelectionDAG.cpp

[XinWang10]

Summary

The condition Opcode <= std::numeric_limits<int>::max() will
always be true here.

[XinWang10]

• align

[skan]

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

7956

Should we use Opcode <= (unsigned)std::numeric_limits<int>::max()?

[XinWang10]

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

7956

Yes, it should be the intention of the author.

[XinWang10]

• update condition

[XinWang10]

• update

[XinWang10]

• rebase

[skan]

LGTM

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

 
 SDValue SelectionDAG::getMemIntrinsicNode(unsigned Opcode, const SDLoc &dl,
                                           SDVTList VTList,
                                           ArrayRef<SDValue> Ops, EVT MemVT,
                                           MachineMemOperand *MMO) {
   assert((Opcode == ISD::INTRINSIC_VOID ||
           Opcode == ISD::INTRINSIC_W_CHAIN ||
           Opcode == ISD::PREFETCH ||
-          ((int)Opcode <= std::numeric_limits<int>::max() &&
+          (Opcode <= (unsigned)std::numeric_limits<int>::max() &&
            (int)Opcode >= ISD::FIRST_TARGET_MEMORY_OPCODE)) &&
          "Opcode is not a memory-accessing opcode!");
 
   // Memoize the node unless it returns a flag.
   MemIntrinsicSDNode *N;
   if (VTList.VTs[VTList.NumVTs-1] != MVT::Glue) {
     FoldingSetNodeID ID;
     AddNodeIDNode(ID, Opcode, VTList, Ops);
     ID.AddInteger(getSyntheticNodeSubclassData<MemIntrinsicSDNode>(