This is an archive of the discontinued LLVM Phabricator instance.

[clang][tests] Fix Flang driver tests for Windows
ClosedPublic

Authored by kaadam on Apr 13 2023, 3:26 AM.

Details

Summary

Updated the regular expression in order to match '.exe' suffix,
if these Flang tests are running on Windows.

Diff Detail

Event Timeline

kaadam created this revision.Apr 13 2023, 3:26 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: sunshaoce. · View Herald Transcript
kaadam requested review of this revision.Apr 13 2023, 3:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 3:26 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

clang/test/Driver/flang/multiple-inputs-mixed.f90 uses a more general FileCheck pattern:

! CHECK-SYNTAX-ONLY-LABEL: "{{[^"]*}}flang-new{{[^"/]*}}" "-fc1"

Perhaps these files should use the same regexp?

Yes, it could be. I will update them.

This revision is now accepted and ready to land.Apr 21 2023, 6:47 AM

Bryan, thanks for the review. Is another acceptance required for merging? May I ask you to commit the change? I do not have commit access. Thanks, Adam

This revision was automatically updated to reflect the committed changes.

May I ask you to commit the change? I do not have commit access.

Done.