Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D148207

[mlir][Tensor] Drop SplitPaddingPatterns.
ClosedPublic
Actions

Authored by nicolasvasilache on Apr 13 2023, 3:06 AM.

Details

Reviewers
qcolombet
ThomasRaoux
antiagainst
Commits
rG2031d7d66dc8: [mlir][Tensor] Drop SplitPaddingPatterns.
Summary

These old patterns are not in use in either MLIR or downstream projects except for one test.
Additionally this is redundant with logic in the tensor.pad tiling implementation.

Drop SplitPaddingPatterns to reduce entropy.

Diff Detail

Event Timeline

nicolasvasilache created this revision.Apr 13 2023, 3:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 3:06 AM
Herald added subscribers: bviyer, hanchung, Moerafaat and 23 others. · View Herald Transcript
nicolasvasilache requested review of this revision.Apr 13 2023, 3:06 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 13 2023, 3:06 AM
Herald added subscribers: cfe-commits, stephenneuendorffer. · View Herald Transcript
nicolasvasilache added reviewers: qcolombet, ThomasRaoux, antiagainst.Apr 13 2023, 3:07 AM
qcolombet accepted this revision.Apr 13 2023, 3:37 AM
This revision is now accepted and ready to land.Apr 13 2023, 3:37 AM
This revision was landed with ongoing or failed builds.Apr 13 2023, 3:41 AM
Closed by commit rG2031d7d66dc8: [mlir][Tensor] Drop SplitPaddingPatterns. (authored by nicolasvasilache). · Explain Why
This revision was automatically updated to reflect the committed changes.
nicolasvasilache added a commit: rG2031d7d66dc8: [mlir][Tensor] Drop SplitPaddingPatterns..
Harbormaster completed remote builds in B225289: Diff 513142.Apr 13 2023, 3:46 AM

Revision Contents
Changeset List

PathSize
clang/
docs/
tools/
1 line
mlir/
include/
mlir/
Dialect/
Tensor/
Transforms/
6 lines
lib/
Dialect/
Tensor/
Transforms/
1 line
test/
Dialect/
Tensor/
lib/
Dialect/
Tensor/
13 lines

Diff 513157

View Options

clang/docs/tools/clang-formatted-files.txt

Loading...
View Options

mlir/include/mlir/Dialect/Tensor/Transforms/Transforms.h

Loading...
View Options

mlir/lib/Dialect/Tensor/Transforms/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/Tensor/Transforms/SplitPaddingPatterns.cpp

Loading...
View Options

mlir/test/Dialect/Tensor/split-padding.mlir

Loading...
View Options

mlir/test/lib/Dialect/Tensor/TestTensorTransforms.cpp

Loading...