This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Handle DebugLoc in DebugValueManager
ClosedPublic

Authored by aheejin on Apr 12 2023, 4:42 AM.

Details

Summary

According to
https://llvm.org/docs/HowToUpdateDebugInfo.html#when-to-preserve-an-instruction-location,
when moving (and in our case cloning) within the same BB, the debug
location is preserved. But when moving / cloning to a different BB, we
preserve the debug location only if the destination BB contains the same
location. Currently we preserve the debug loc unconditionally in all
cases. This CL correctly handles the debug locs in DebugValueManager.

Diff Detail

Event Timeline

aheejin created this revision.Apr 12 2023, 4:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 4:42 AM
Herald added subscribers: pmatos, asb, wingo and 5 others. · View Herald Transcript
aheejin requested review of this revision.Apr 12 2023, 4:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 4:42 AM
dschuff accepted this revision.Apr 12 2023, 10:42 AM
dschuff added inline comments.
llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.cpp
229
This revision is now accepted and ready to land.Apr 12 2023, 10:42 AM
aheejin updated this revision to Diff 513072.Apr 12 2023, 11:46 PM
aheejin marked an inline comment as done.

Typo fix

This revision was landed with ongoing or failed builds.Apr 12 2023, 11:47 PM
This revision was automatically updated to reflect the committed changes.