This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis][NFC] remove runAndMeasure
ClosedPublic

Authored by aidengrossman on Apr 9 2023, 3:53 AM.

Details

Summary

This completes the FIXME listed in FunctionExecutor in regards to
deprecating this function. It simply makes the appropriate call into
runAndSample and grabs the first counter value. This patch completely
removes the function, moving that logic into the callers (currently only
uopsBenchmarkRunner). This makes creating new FunctionExecutors easier
as an implementation no longer needs to worry about this detail.

Diff Detail

Event Timeline

aidengrossman created this revision.Apr 9 2023, 3:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 9 2023, 3:53 AM
Herald added a subscriber: mstojanovic. · View Herald Transcript
aidengrossman requested review of this revision.Apr 9 2023, 3:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 9 2023, 3:53 AM
gchatelet accepted this revision.Apr 13 2023, 1:31 AM
This revision is now accepted and ready to land.Apr 13 2023, 1:31 AM
This revision was landed with ongoing or failed builds.Apr 14 2023, 12:16 AM
This revision was automatically updated to reflect the committed changes.