This is an archive of the discontinued LLVM Phabricator instance.

[flang][NFC] Update polymorphic design document to reflect implementation
ClosedPublic

Authored by clementval on Apr 5 2023, 2:57 PM.

Details

Summary

Update the design document to reflect the actual implementation
of polymorphic entities.

Diff Detail

Event Timeline

clementval created this revision.Apr 5 2023, 2:57 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
clementval requested review of this revision.Apr 5 2023, 2:57 PM
PeteSteinfeld accepted this revision.Apr 5 2023, 5:55 PM

Found a few nits that should be corrected. Otherwise, looks good!

flang/docs/PolymorphicEntities.md
176–177

Should read "these two".

237–250

Should read "Dynamid type comparisons"

This revision is now accepted and ready to land.Apr 5 2023, 5:55 PM
jeanPerier accepted this revision.Apr 6 2023, 12:24 AM

Looks good

This revision was automatically updated to reflect the committed changes.
clementval marked an inline comment as done.
clementval marked an inline comment as done.Apr 6 2023, 8:43 AM