This is an archive of the discontinued LLVM Phabricator instance.

Differential D147402

[mlir] Fix ignoring return value warning for Toy CLIs
ClosedPublic

Authored by Lewuathe on Apr 2 2023, 12:01 AM.

Details

Reviewers
rriddle
mehdi_amini
Commits
rG633146093c4e: [mlir] Fix ignoring return value warning for Toy CLIs
rG470f3cee3557: [mlir] Catch the case using ir print without disabling multithread
Summary

After the change returning LogicalResult from applyPassManagerCLIOptions, the warning message is shown in the Toy CLIs saying it's not using the returned values. We can check the result and return non-zero value as the pass failure.

/Users/sasaki/dev/llvm-project/mlir/examples/toy/Ch3/toyc.cpp:118:5: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
    applyPassManagerCLOptions(pm);
    ^~~~~~~~~~~~~~~~~~~~~~~~~ ~~
1 warning generated.
[473/485] Building CXX object tools/mlir/examples/toy/Ch4/CMakeFiles/toyc-ch4.dir/toyc.cpp.o
/Users/sasaki/dev/llvm-project/mlir/examples/toy/Ch4/toyc.cpp:119:5: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
    applyPassManagerCLOptions(pm);
    ^~~~~~~~~~~~~~~~~~~~~~~~~ ~~
1 warning generated.
[477/485] Building CXX object tools/mlir/examples/toy/Ch5/CMakeFiles/toyc-ch5.dir/toyc.cpp.o
/Users/sasaki/dev/llvm-project/mlir/examples/toy/Ch5/toyc.cpp:122:3: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
  applyPassManagerCLOptions(pm);
  ^~~~~~~~~~~~~~~~~~~~~~~~~ ~~
1 warning generated.
[479/485] Building CXX object tools/mlir/examples/toy/Ch6/CMakeFiles/toyc-ch6.dir/toyc.cpp.o
/Users/sasaki/dev/llvm-project/mlir/examples/toy/Ch6/toyc.cpp:139:3: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
  applyPassManagerCLOptions(pm);
  ^~~~~~~~~~~~~~~~~~~~~~~~~ ~~
1 warning generated.
[481/485] Building CXX object tools/mlir/examples/toy/Ch7/CMakeFiles/toyc-ch7.dir/toyc.cpp.o
/Users/sasaki/dev/llvm-project/mlir/examples/toy/Ch7/toyc.cpp:139:3: warning: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result]
  applyPassManagerCLOptions(pm);
  ^~~~~~~~~~~~~~~~~~~~~~~~~ ~~
1 warning generated.

Diff Detail

Revision Contents

PathSize
mlir/
examples/
toy/
Ch3/
3 lines
Ch4/
3 lines
Ch5/
3 lines
Ch6/
3 lines
Ch7/
3 lines

Diff 510307

mlir/examples/toy/Ch3/toyc.cpp

Show First 20 Lines • Show All 109 Lines • ▼ Show 20 Linesint dumpMLIR() {
llvm::SourceMgr sourceMgr; llvm::SourceMgr sourceMgr;
mlir::SourceMgrDiagnosticHandler sourceMgrHandler(sourceMgr, &context); mlir::SourceMgrDiagnosticHandler sourceMgrHandler(sourceMgr, &context);
if (int error = loadMLIR(sourceMgr, context, module)) if (int error = loadMLIR(sourceMgr, context, module))
return error; return error;
if (enableOpt) { if (enableOpt) {
mlir::PassManager pm(module.get()->getName()); mlir::PassManager pm(module.get()->getName());
// Apply any generic pass manager command line options and run the pipeline. // Apply any generic pass manager command line options and run the pipeline.
applyPassManagerCLOptions(pm); if (mlir::failed(mlir::applyPassManagerCLOptions(pm)))
return 4;
// Add a run of the canonicalizer to optimize the mlir module. // Add a run of the canonicalizer to optimize the mlir module.
pm.addNestedPass<mlir::toy::FuncOp>(mlir::createCanonicalizerPass()); pm.addNestedPass<mlir::toy::FuncOp>(mlir::createCanonicalizerPass());
if (mlir::failed(pm.run(*module))) if (mlir::failed(pm.run(*module)))
return 4; return 4;
} }
module->dump(); module->dump();
Show All 36 Lines

mlir/examples/toy/Ch4/toyc.cpp

Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Linesint dumpMLIR() {
llvm::SourceMgr sourceMgr; llvm::SourceMgr sourceMgr;
mlir::SourceMgrDiagnosticHandler sourceMgrHandler(sourceMgr, &context); mlir::SourceMgrDiagnosticHandler sourceMgrHandler(sourceMgr, &context);
if (int error = loadMLIR(sourceMgr, context, module)) if (int error = loadMLIR(sourceMgr, context, module))
return error; return error;
if (enableOpt) { if (enableOpt) {
mlir::PassManager pm(module.get()->getName()); mlir::PassManager pm(module.get()->getName());
// Apply any generic pass manager command line options and run the pipeline. // Apply any generic pass manager command line options and run the pipeline.
applyPassManagerCLOptions(pm); if (mlir::failed(mlir::applyPassManagerCLOptions(pm)))
return 4;
// Inline all functions into main and then delete them. // Inline all functions into main and then delete them.
pm.addPass(mlir::createInlinerPass()); pm.addPass(mlir::createInlinerPass());
// Now that there is only one function, we can infer the shapes of each of // Now that there is only one function, we can infer the shapes of each of
// the operations. // the operations.
mlir::OpPassManager &optPM = pm.nest<mlir::toy::FuncOp>(); mlir::OpPassManager &optPM = pm.nest<mlir::toy::FuncOp>();
optPM.addPass(mlir::toy::createShapeInferencePass()); optPM.addPass(mlir::toy::createShapeInferencePass());
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines

mlir/examples/toy/Ch5/toyc.cpp

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Linesint dumpMLIR() {
mlir::OwningOpRef<mlir::ModuleOp> module; mlir::OwningOpRef<mlir::ModuleOp> module;
llvm::SourceMgr sourceMgr; llvm::SourceMgr sourceMgr;
mlir::SourceMgrDiagnosticHandler sourceMgrHandler(sourceMgr, &context); mlir::SourceMgrDiagnosticHandler sourceMgrHandler(sourceMgr, &context);
if (int error = loadMLIR(sourceMgr, context, module)) if (int error = loadMLIR(sourceMgr, context, module))
return error; return error;
mlir::PassManager pm(module.get()->getName()); mlir::PassManager pm(module.get()->getName());
// Apply any generic pass manager command line options and run the pipeline. // Apply any generic pass manager command line options and run the pipeline.
applyPassManagerCLOptions(pm); if (mlir::failed(mlir::applyPassManagerCLOptions(pm)))
return 4;
// Check to see what granularity of MLIR we are compiling to. // Check to see what granularity of MLIR we are compiling to.
bool isLoweringToAffine = emitAction >= Action::DumpMLIRAffine; bool isLoweringToAffine = emitAction >= Action::DumpMLIRAffine;
if (enableOpt || isLoweringToAffine) { if (enableOpt || isLoweringToAffine) {
// Inline all functions into main and then delete them. // Inline all functions into main and then delete them.
pm.addPass(mlir::createInlinerPass()); pm.addPass(mlir::createInlinerPass());
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines

mlir/examples/toy/Ch6/toyc.cpp

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
int loadAndProcessMLIR(mlir::MLIRContext &context, int loadAndProcessMLIR(mlir::MLIRContext &context,
mlir::OwningOpRef<mlir::ModuleOp> &module) { mlir::OwningOpRef<mlir::ModuleOp> &module) {
if (int error = loadMLIR(context, module)) if (int error = loadMLIR(context, module))
return error; return error;
mlir::PassManager pm(module.get()->getName()); mlir::PassManager pm(module.get()->getName());
// Apply any generic pass manager command line options and run the pipeline. // Apply any generic pass manager command line options and run the pipeline.
applyPassManagerCLOptions(pm); if (mlir::failed(mlir::applyPassManagerCLOptions(pm)))
return 4;
// Check to see what granularity of MLIR we are compiling to. // Check to see what granularity of MLIR we are compiling to.
bool isLoweringToAffine = emitAction >= Action::DumpMLIRAffine; bool isLoweringToAffine = emitAction >= Action::DumpMLIRAffine;
bool isLoweringToLLVM = emitAction >= Action::DumpMLIRLLVM; bool isLoweringToLLVM = emitAction >= Action::DumpMLIRLLVM;
if (enableOpt || isLoweringToAffine) { if (enableOpt || isLoweringToAffine) {
// Inline all functions into main and then delete them. // Inline all functions into main and then delete them.
pm.addPass(mlir::createInlinerPass()); pm.addPass(mlir::createInlinerPass());
▲ Show 20 Lines • Show All 170 Lines • Show Last 20 Lines

mlir/examples/toy/Ch7/toyc.cpp

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
int loadAndProcessMLIR(mlir::MLIRContext &context, int loadAndProcessMLIR(mlir::MLIRContext &context,
mlir::OwningOpRef<mlir::ModuleOp> &module) { mlir::OwningOpRef<mlir::ModuleOp> &module) {
if (int error = loadMLIR(context, module)) if (int error = loadMLIR(context, module))
return error; return error;
mlir::PassManager pm(module.get()->getName()); mlir::PassManager pm(module.get()->getName());
// Apply any generic pass manager command line options and run the pipeline. // Apply any generic pass manager command line options and run the pipeline.
applyPassManagerCLOptions(pm); if (mlir::failed(mlir::applyPassManagerCLOptions(pm)))
return 4;
// Check to see what granularity of MLIR we are compiling to. // Check to see what granularity of MLIR we are compiling to.
bool isLoweringToAffine = emitAction >= Action::DumpMLIRAffine; bool isLoweringToAffine = emitAction >= Action::DumpMLIRAffine;
bool isLoweringToLLVM = emitAction >= Action::DumpMLIRLLVM; bool isLoweringToLLVM = emitAction >= Action::DumpMLIRLLVM;
if (enableOpt || isLoweringToAffine) { if (enableOpt || isLoweringToAffine) {
// Inline all functions into main and then delete them. // Inline all functions into main and then delete them.
pm.addPass(mlir::createInlinerPass()); pm.addPass(mlir::createInlinerPass());
▲ Show 20 Lines • Show All 171 Lines • Show Last 20 Lines