This is an archive of the discontinued LLVM Phabricator instance.

Differential D147365

[HIPSPV] Remove useIntegratedAs. NFC
AbandonedPublic

Authored by brad on Mar 31 2023, 5:44 PM.

Details

Reviewers
jhuber6
ronlieb
Summary

useIntegratedAs() is enabled if IsIntegratedAssemblerDefault() is enabled.

Diff Detail

Event Timeline

brad created this revision.Mar 31 2023, 5:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2023, 5:44 PM
Herald added a subscriber: yaxunl. · View Herald Transcript
brad requested review of this revision.Mar 31 2023, 5:44 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald TranscriptMar 31 2023, 5:44 PM
jhuber6 added a comment.Mar 31 2023, 6:02 PM

I don't know the toolchain, does HIPSPV perform as expected if you pass -fno-integrated-as? The difference is that useIntegratedAs forces it to always be enabled so the user can't change it AFAIK.

Harbormaster completed remote builds in B223097: Diff 510156.Mar 31 2023, 7:03 PM
brad abandoned this revision.Jul 10 2023, 8:32 PM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
1 line

Diff 510156

clang/lib/Driver/ToolChains/HIPSPV.h

Context not available.
const llvm::opt::ArgList &Args) const override; const llvm::opt::ArgList &Args) const override;
bool IsIntegratedAssemblerDefault() const override { return true; } bool IsIntegratedAssemblerDefault() const override { return true; }
bool IsMathErrnoDefault() const override { return false; } bool IsMathErrnoDefault() const override { return false; }
bool useIntegratedAs() const override { return true; }
bool isCrossCompiling() const override { return true; } bool isCrossCompiling() const override { return true; }
bool isPICDefault() const override { return false; } bool isPICDefault() const override { return false; }
bool isPIEDefault(const llvm::opt::ArgList &Args) const override { bool isPIEDefault(const llvm::opt::ArgList &Args) const override {
Context not available.