This is an archive of the discontinued LLVM Phabricator instance.

llvm/docs/GitHub.rst
21	This is fine, but as mentioned in the issue, I'd like to see something in the instructions on how to create forked repos that can be used for branches for PRs. I know that I'm not familiar with it (we don't use this model internally), so I expect many others won't be either.

nhaehnle added a subscriber: nhaehnle.Mar 31 2023, 2:54 AM

nhaehnle added inline comments.

llvm/docs/GitHub.rst
21	This is a super standard workflow for GitHub, so we really shouldn't put any details here. A link to some appropriate documentation from GitHub would be appropriate though.

I would go further and do not even mention stacked pull request.

This repository is reserved for official project branches only. Do not create any branches in the llvm/llvm-project repository. We may relax this rule in
the future.

jhenderson added inline comments.Mar 31 2023, 3:37 AM

llvm/docs/GitHub.rst
21	A link to external documentation is fine by me, but we need something.

Add a link to documentation about creating pull requests from forks.

tstellar marked an inline comment as done.Apr 19 2023, 4:15 PM

Harbormaster completed remote builds in B226712: Diff 515111.Apr 19 2023, 4:31 PM

asl added a subscriber: asl.Apr 19 2023, 4:31 PM

asl added inline comments.

llvm/docs/GitHub.rst
23	This might be misleading. Are we suggesting that the repo is accepting PRs currently?

tstellar added inline comments.Apr 19 2023, 6:34 PM

llvm/docs/GitHub.rst
23	Maybe it would make more sense to move this part into my other patch: D147284 @jhenderson what do you think about that?

jhenderson added inline comments.Apr 20 2023, 1:15 AM

llvm/docs/GitHub.rst
23	Makes sense to me.

Move note about pull requests to D147284.

LGTM.

ldionne accepted this revision.May 4 2023, 11:40 AM

This revision was landed with ongoing or failed builds.May 4 2023, 11:52 AM

Closed by commit rGead502454c2a: docs: Document policy around GitHub branches (authored by tstellar). · Explain Why

This revision was automatically updated to reflect the committed changes.

tstellar added a commit: rGead502454c2a: docs: Document policy around GitHub branches.

Revision Contents

Path

Size

llvm/

docs/

GitHub.rst

8 lines

Diff 519591

llvm/docs/GitHub.rst

	======================			======================
	LLVM GitHub User Guide			LLVM GitHub User Guide
	======================			======================

	Introduction			Introduction
	============			============
	The LLVM Project uses `GitHub <https://github.com/>`_ for			The LLVM Project uses `GitHub <https://github.com/>`_ for
	`Source Code <https://github.com/llvm/llvm-project>`_,			`Source Code <https://github.com/llvm/llvm-project>`_,
	`Releases <https://github.com/llvm/llvm-project/releases>`_, and			`Releases <https://github.com/llvm/llvm-project/releases>`_, and
	`Issue Tracking <https://github.com/llvm/llvm-project/issues>`_.			`Issue Tracking <https://github.com/llvm/llvm-project/issues>`_.

	This page describes how the LLVM Project users and developers can			This page describes how the LLVM Project users and developers can
	participate in the project using GitHub.			participate in the project using GitHub.

				Branches
				========
				Do not create any branches in the llvm/llvm-project repository. This repository
				is reserved for official project branches only. We may relax this rule in
				the future if needed to support "stacked" pull request, but in that case only
				branches being used for "stacked" pull requests will be allowed.

				jhendersonUnsubmitted Not Done Reply Inline Actions This is fine, but as mentioned in the issue, I'd like to see something in the instructions on how to create forked repos that can be used for branches for PRs. I know that I'm not familiar with it (we don't use this model internally), so I expect many others won't be either. jhenderson: This is fine, but as mentioned in the issue, I'd like to see something in the instructions on…
				nhaehnleUnsubmitted Not Done Reply Inline Actions This is a super standard workflow for GitHub, so we really shouldn't put any details here. A link to some appropriate documentation from GitHub would be appropriate though. nhaehnle: This is a super standard workflow for GitHub, so we really shouldn't put any details here. A…
				jhendersonUnsubmitted Done Reply Inline Actions A link to external documentation is fine by me, but we need something. jhenderson: A link to external documentation is fine by me, but we need something.

	Releases			Releases
				aslUnsubmitted Not Done Reply Inline Actions This might be misleading. Are we suggesting that the repo is accepting PRs currently? asl: This might be misleading. Are we suggesting that the repo is accepting PRs currently?
				tstellarAuthorUnsubmitted Done Reply Inline Actions Maybe it would make more sense to move this part into my other patch: D147284 @jhenderson what do you think about that? tstellar: Maybe it would make more sense to move this part into my other patch: D147284 @jhenderson what…
				jhendersonUnsubmitted Not Done Reply Inline Actions Makes sense to me. jhenderson: Makes sense to me.
	========			========

	Backporting Fixes to the Release Branches			Backporting Fixes to the Release Branches
	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^			^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
	You can use special comments on issues to make backport requests for the			You can use special comments on issues to make backport requests for the
	release branches. This is done by making a comment containing one of the			release branches. This is done by making a comment containing one of the
	following commands on any issue that has been added to one of the "X.Y.Z Release"			following commands on any issue that has been added to one of the "X.Y.Z Release"
	milestones.			milestones.
	Show All 18 Lines

This is an archive of the discontinued LLVM Phabricator instance.

docs: Document policy around GitHub branchesClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 519591

llvm/docs/GitHub.rst

docs: Document policy around GitHub branches
ClosedPublic