Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D147234

[clang][ExtractAPI] Reland ExtractAPI for libclang improvements
ClosedPublic
Actions

Authored by dang on Mar 30 2023, 7:06 AM.

Details

Reviewers
hctim
zixuw
ributzka
Commits
rG142c3d9d1414: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements
Summary

This relands the changes that were originally introduced by:

This also fixes the leak that led to these changes being reverted

Diff Detail

Event Timeline

dang created this revision.Mar 30 2023, 7:06 AM
Herald added a reviewer: ributzka. · View Herald TranscriptMar 30 2023, 7:06 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: ChuanqiXu, arphaman. · View Herald Transcript
dang requested review of this revision.Mar 30 2023, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2023, 7:06 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
dang added inline comments.Mar 30 2023, 7:07 AM
clang/tools/c-index-test/c-index-test.c
4898

The previous version didn't free the string here which was the source of the leak @hctim

Harbormaster completed remote builds in B222743: Diff 509660.Mar 30 2023, 8:33 AM
zixuw accepted this revision.Mar 30 2023, 10:13 AM
This revision is now accepted and ready to land.Mar 30 2023, 10:13 AM
Closed by commit rG142c3d9d1414: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements (authored by dang). · Explain WhyMar 30 2023, 10:14 AM
This revision was automatically updated to reflect the committed changes.
dang added a commit: rG142c3d9d1414: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements.

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
ExtractAPI/
604 lines
include/
clang/
ExtractAPI/
lib/
ExtractAPI/
lib/
ExtractAPI/
1 line
2 lines
30 lines
Serialization/
4 lines
2 lines
test/
Index/
177 lines
18 lines
tools/
c-index-test/
21 lines
libclang/
132 lines

Diff 509714

View Options

clang/include/clang/ExtractAPI/ExtractAPIVisitor.h

Loading...
View Options

clang/include/clang/ExtractAPI/TypedefUnderlyingTypeResolver.h

Loading...
View Options

clang/lib/ExtractAPI/CMakeLists.txt

Loading...
View Options

clang/lib/ExtractAPI/DeclarationFragments.cpp

Loading...
View Options

clang/lib/ExtractAPI/ExtractAPIConsumer.cpp

Loading...
View Options

clang/lib/ExtractAPI/ExtractAPIVisitor.cpp

Loading...
View Options

clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp

Loading...
View Options

clang/lib/ExtractAPI/TypedefUnderlyingTypeResolver.h

Loading...
View Options

clang/lib/ExtractAPI/TypedefUnderlyingTypeResolver.cpp

Loading...
View Options

clang/test/Index/extract-api-cursor.m

Loading...
View Options

clang/test/Index/extract-api-usr.m

Loading...
View Options

clang/tools/c-index-test/c-index-test.c

Loading...
View Options

clang/tools/libclang/CXExtractAPI.cpp

Loading...