Page MenuHomePhabricator

zixuw (Zixu Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 28 2020, 11:15 AM (146 w, 4 d)

Recent Activity

Mon, Mar 6

zixuw accepted D145371: [AArch64TargetParser] reinstate assert for optional.
Mon, Mar 6, 9:31 AM · Restricted Project, Restricted Project

Fri, Mar 3

zixuw added a comment to D145206: [NFC] Properly handle optional minor value for ArchInfo::Version.

I'm not sure that this is the right fix. The exception indicates that this is being called with ArchInfo objects with invalid VersionTuples, how is that happening? Also could you explain what the issue is with bad_optional_access on older macOS?

Fri, Mar 3, 10:03 AM · Restricted Project, Restricted Project

Thu, Mar 2

zixuw committed rGd7623507ac25: [NFC] Properly handle optional minor value for ArchInfo::Version (authored by zixuw).
[NFC] Properly handle optional minor value for ArchInfo::Version
Thu, Mar 2, 5:29 PM · Restricted Project, Restricted Project
zixuw closed D145206: [NFC] Properly handle optional minor value for ArchInfo::Version.
Thu, Mar 2, 5:28 PM · Restricted Project, Restricted Project
zixuw added a comment to D145206: [NFC] Properly handle optional minor value for ArchInfo::Version.

This fixes the checking logic, and also works around a build failure with clang/unittest/Interpreter/ExceptionTests which enables exceptions. std::optional::value() throws std::bad_optional_access, which won't build if targeting older versions of macOS

Thu, Mar 2, 4:50 PM · Restricted Project, Restricted Project
zixuw added a reviewer for D145206: [NFC] Properly handle optional minor value for ArchInfo::Version: tmatheson.
Thu, Mar 2, 4:46 PM · Restricted Project, Restricted Project
zixuw requested review of D145206: [NFC] Properly handle optional minor value for ArchInfo::Version.
Thu, Mar 2, 4:45 PM · Restricted Project, Restricted Project
zixuw added inline comments to D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin.
Thu, Mar 2, 3:34 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, Mar 1

zixuw added a comment to D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin.

Hi! This broke the asan replaceable_new_delete.cpp test on Darwin because it has a run line using -static-libsan. Could you take a look? Probably need to separate that check out and mark as unsupported on Darwin

Wed, Mar 1, 3:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 15 2022

zixuw accepted D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums.
Dec 15 2022, 11:24 AM · Restricted Project, Restricted Project

Dec 14 2022

zixuw added inline comments to D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums.
Dec 14 2022, 11:23 AM · Restricted Project, Restricted Project
zixuw added inline comments to D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums.
Dec 14 2022, 10:30 AM · Restricted Project, Restricted Project

Dec 12 2022

zixuw accepted D139115: [clang][ExtractAPI] Add support for single symbol SGF.
Dec 12 2022, 10:41 AM · Restricted Project, Restricted Project

Dec 8 2022

zixuw added a reviewer for D139115: [clang][ExtractAPI] Add support for single symbol SGF: cishida.
Dec 8 2022, 11:03 AM · Restricted Project, Restricted Project

Dec 6 2022

zixuw added inline comments to D139115: [clang][ExtractAPI] Add support for single symbol SGF.
Dec 6 2022, 4:31 PM · Restricted Project, Restricted Project

Oct 25 2022

zixuw accepted D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph.
Oct 25 2022, 10:14 AM · Restricted Project, Restricted Project

Oct 24 2022

zixuw added a comment to D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph.

Is it easy to/worth checking if the target is actually outside of the current module to keep the output smaller and concise?

Oct 24 2022, 9:56 AM · Restricted Project, Restricted Project
zixuw accepted D136450: [clang][ExtractAPI] Allow users to specify a list of symbols to ignore.
Oct 24 2022, 9:53 AM · Restricted Project, Restricted Project

Oct 5 2022

zixuw committed rG5301826fa86a: [clang][ExtractAPI] Don't print locations for anonymous tags (authored by zixuw).
[clang][ExtractAPI] Don't print locations for anonymous tags
Oct 5 2022, 1:11 PM · Restricted Project, Restricted Project
zixuw closed D135295: [clang][ExtractAPI] Don't print locations for anonymous tags.
Oct 5 2022, 1:11 PM · Restricted Project, Restricted Project
zixuw added a comment to D135295: [clang][ExtractAPI] Don't print locations for anonymous tags.

This doesn't affect any tests?

Just finished building locally, running tests to verify now

Doesn't affect any test for this patch as expected. Still need to see how does it interacts with https://reviews.llvm.org/D134813.

Oct 5 2022, 1:09 PM · Restricted Project, Restricted Project
zixuw added a comment to D134813: Properly print unnamed TagDecl objects in diagnostics.

With the PrintingPolicy fix in https://reviews.llvm.org/D135295 and landed USR fix, the diff within ExtractAPI tests is only the wording with anonymous enums, and we can drop the lit change:

658c658
<             "spelling": "(anonymous)"
---
>             "spelling": "enum (unnamed)"
661c661
<         "title": "(anonymous)"
---
>         "title": "enum (unnamed)"
664c664
<         "(anonymous)"
---
>         "enum (unnamed)"
706c706
<         "(anonymous)",
---
>         "enum (unnamed)",
746c746
<             "spelling": "(anonymous)"
---
>             "spelling": "enum (unnamed)"
749c749
<         "title": "(anonymous)"
---
>         "title": "enum (unnamed)"
752c752
<         "(anonymous)"
---
>         "enum (unnamed)"
794c794
<         "(anonymous)",
---
>         "enum (unnamed)",

@dang @QuietMisdreavus for this change.

Oct 5 2022, 1:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zixuw added a comment to D134813: Properly print unnamed TagDecl objects in diagnostics.

I'm pulling this on top of https://reviews.llvm.org/D135295 to try locally now.

Oct 5 2022, 12:47 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zixuw added a comment to D135295: [clang][ExtractAPI] Don't print locations for anonymous tags.

This doesn't affect any tests?

Just finished building locally, running tests to verify now

Oct 5 2022, 12:30 PM · Restricted Project, Restricted Project
zixuw updated the diff for D135295: [clang][ExtractAPI] Don't print locations for anonymous tags.

Update on top of the existing PrintingPolicy in the ASTContext instead of creating a new default one.

Oct 5 2022, 12:28 PM · Restricted Project, Restricted Project
zixuw added inline comments to D135295: [clang][ExtractAPI] Don't print locations for anonymous tags.
Oct 5 2022, 12:24 PM · Restricted Project, Restricted Project
zixuw added a comment to D135295: [clang][ExtractAPI] Don't print locations for anonymous tags.

This doesn't affect any tests?

Oct 5 2022, 12:20 PM · Restricted Project, Restricted Project
zixuw updated the diff for D135295: [clang][ExtractAPI] Don't print locations for anonymous tags.

Set PrintingPolicy properly

Oct 5 2022, 11:37 AM · Restricted Project, Restricted Project
zixuw added a comment to D134813: Properly print unnamed TagDecl objects in diagnostics.

Setting PrintingPolicy::AnonymousTagLocations to false in https://reviews.llvm.org/D135295

Oct 5 2022, 11:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zixuw added reviewers for D135295: [clang][ExtractAPI] Don't print locations for anonymous tags: sammccall, aaron.ballman.
Oct 5 2022, 11:15 AM · Restricted Project, Restricted Project
zixuw requested review of D135295: [clang][ExtractAPI] Don't print locations for anonymous tags.
Oct 5 2022, 11:14 AM · Restricted Project, Restricted Project
zixuw added a comment to D134813: Properly print unnamed TagDecl objects in diagnostics.

Ah sorry I just finished reading the discussions. IIUC 20c9ac29250493f5e0a3791dc1e5e9114ff0dc6e should have already fixed the USR generation part, and all of the USR updates in the test cases should be gone now?

Oct 5 2022, 10:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zixuw added inline comments to D134813: Properly print unnamed TagDecl objects in diagnostics.
Oct 5 2022, 10:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zixuw updated subscribers of D134813: Properly print unnamed TagDecl objects in diagnostics.

I'd guess we need some kind of change to CommentXML and ExtractAPI, but I don't know enough to be sure what it should be.

Ping @dang @zixuw and @dexonsmith for questions about how to handle ExtractAPI changes, and @gribozavr for questions about CommentXML

Oct 5 2022, 10:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 2 2022

zixuw accepted D130918: [clang][ExtractAPI] Record availability information on all platforms.

LGTM!

Aug 2 2022, 9:24 AM · Restricted Project, Restricted Project

Aug 1 2022

zixuw added a comment to D130918: [clang][ExtractAPI] Record availability information on all platforms.

Thanks Daniel!

Aug 1 2022, 11:24 AM · Restricted Project, Restricted Project

Jul 26 2022

zixuw accepted D130583: [clang][ExtractAPI] Add a space between type and name in property declaration fragments.

Awesome! Thanks Daniel!

Jul 26 2022, 11:44 AM · Restricted Project, Restricted Project
zixuw accepted D130581: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property".

LGTM. Thanks Daniel!

Jul 26 2022, 11:42 AM · Restricted Project, Restricted Project

May 16 2022

zixuw accepted D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore.

clang-format failed:

---  clang-format

changed files:

    clang/test/ExtractAPI/underscored.c
May 16 2022, 2:04 PM · Restricted Project, Restricted Project

May 5 2022

zixuw added a comment to D125061: [clang] A more robust way to attach comments.

Well, apparently there are still some corner-case bugs in the logic. ExtractAPI and a few other tests failed. Will look into it tomorrow.

May 5 2022, 7:12 PM · Restricted Project, Restricted Project
zixuw added reviewers for D125061: [clang] A more robust way to attach comments: ributzka, akyrtzi, doug.gregor, gribozavr.
May 5 2022, 5:27 PM · Restricted Project, Restricted Project
zixuw requested review of D125061: [clang] A more robust way to attach comments.
May 5 2022, 5:20 PM · Restricted Project, Restricted Project

May 4 2022

zixuw added a reverting change for rG2966f0fa5052: Revert "[clang][extract-api] Use relative includes": rGcb5bb28511f2: Revert "Revert "[clang][extract-api] Use relative includes"".
May 4 2022, 2:53 PM · Restricted Project, Restricted Project
zixuw committed rGcb5bb28511f2: Revert "Revert "[clang][extract-api] Use relative includes"" (authored by zixuw).
Revert "Revert "[clang][extract-api] Use relative includes""
May 4 2022, 2:53 PM · Restricted Project, Restricted Project
zixuw closed D124964: Revert "Revert "[clang][extract-api] Use relative includes"".
May 4 2022, 2:53 PM · Restricted Project, Restricted Project
zixuw added a comment to D124964: Revert "Revert "[clang][extract-api] Use relative includes"".

LGTM! If I understand the issue correctly we gave llvm::Regex::match a string temporary to match against before and now we store it for long enough to process the match results?

May 4 2022, 2:51 PM · Restricted Project, Restricted Project
zixuw updated the diff for D124964: Revert "Revert "[clang][extract-api] Use relative includes"".

Whitespace change: clang-format removed an empty line

May 4 2022, 2:36 PM · Restricted Project, Restricted Project
zixuw added a reverting change for rG2966f0fa5052: Revert "[clang][extract-api] Use relative includes": D124964: Revert "Revert "[clang][extract-api] Use relative includes"".
May 4 2022, 2:27 PM · Restricted Project, Restricted Project
zixuw requested review of D124964: Revert "Revert "[clang][extract-api] Use relative includes"".
May 4 2022, 2:26 PM · Restricted Project, Restricted Project
zixuw committed rG2966f0fa5052: Revert "[clang][extract-api] Use relative includes" (authored by zixuw).
Revert "[clang][extract-api] Use relative includes"
May 4 2022, 12:28 PM · Restricted Project, Restricted Project
zixuw added a reverting change for rG4c262fee08b5: [clang][extract-api] Use relative includes: rG2966f0fa5052: Revert "[clang][extract-api] Use relative includes".
May 4 2022, 12:28 PM · Restricted Project, Restricted Project
zixuw added a reverting change for D123831: [clang][extract-api] Use relative includes: rG2966f0fa5052: Revert "[clang][extract-api] Use relative includes".
May 4 2022, 12:28 PM · Restricted Project, Restricted Project
zixuw added a comment to D123831: [clang][extract-api] Use relative includes.

Accidentally added another test case in my local workspace. Removed in 5f841c71fc2cc77c92f526791cd7a938bcac69aa

May 4 2022, 10:45 AM · Restricted Project, Restricted Project
zixuw committed rG5f841c71fc2c: [NFC] Remove unfinished test case (authored by zixuw).
[NFC] Remove unfinished test case
May 4 2022, 10:42 AM · Restricted Project, Restricted Project
zixuw committed rG4c262fee08b5: [clang][extract-api] Use relative includes (authored by zixuw).
[clang][extract-api] Use relative includes
May 4 2022, 10:28 AM · Restricted Project, Restricted Project
zixuw closed D123831: [clang][extract-api] Use relative includes.
May 4 2022, 10:28 AM · Restricted Project, Restricted Project
zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.

Update test case to use cc1 instead of driver

May 4 2022, 10:27 AM · Restricted Project, Restricted Project
zixuw added a comment to D123831: [clang][extract-api] Use relative includes.

Since this is a new test can we use the approach in https://reviews.llvm.org/D124634 to check for diagnostics output.

May 4 2022, 10:00 AM · Restricted Project, Restricted Project

May 3 2022

zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.
  • Capture whether the include is quoted in KnownFiles
  • Misc: use getInputBufferName() instead of string literal
May 3 2022, 12:24 PM · Restricted Project, Restricted Project

May 2 2022

zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.

Convert file path to use slashes for headermap reverse lookup

May 2 2022, 5:29 PM · Restricted Project, Restricted Project
zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.
  • Delete test known_files_only_hmap
  • Handle quoted includes
  • Attempt to fix Windows fails by converting backslashes before matching the framework regex
  • Update test relative_include
May 2 2022, 4:15 PM · Restricted Project, Restricted Project

Apr 28 2022

zixuw accepted D124638: [clang] Track how headers get included generally during lookup time.

LGTM!

Apr 28 2022, 2:38 PM · Restricted Project, Restricted Project

Apr 25 2022

zixuw retitled D123831: [clang][extract-api] Use relative includes from [POC][WIP] Use relative include in extract-api to [clang][extract-api] Use relative includes.
Apr 25 2022, 5:51 PM · Restricted Project, Restricted Project
zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.
  • Rewrite commit message for preparation
  • Remove shortening paths based on the current working directory: it does not work with angled includes, and unnecessary for our use
  • XFAIL test known_files_only_hmap.c, as it is not a valid setup with a questionable headermap. Need to determine how to fix that test case or just discard it, as the new relative_include.m test also checks that symbols from external files are dropped
Apr 25 2022, 5:48 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123831: [clang][extract-api] Use relative includes.
Apr 25 2022, 5:25 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123831: [clang][extract-api] Use relative includes.
Apr 25 2022, 3:39 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123831: [clang][extract-api] Use relative includes.
Apr 25 2022, 3:33 PM · Restricted Project, Restricted Project
zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.
  • Create FileManager in PrepareToExecuteAction
  • Use FileManager to load headermaps and reverse lookup mappings
  • Use FileSystem to correctly get working directory and make absolute paths
Apr 25 2022, 1:28 PM · Restricted Project, Restricted Project
zixuw added a comment to D123831: [clang][extract-api] Use relative includes.

The problem is that we are trying to shorten the input file paths in PrepareToExecuteAction, where the CompilerInstance is still primal and doesn't even have a FileManager that we could use. That makes it hard (if possible at all) to reverse lookup headermaps and use the spelled names if we failed to find a search path prefix.
The impact is that we won't be able to get an angled include name for cases where an input doesn't reside in any of the normal search paths, but a headermap entry maps some name to that path. Or we might get the wrong include name where there are both headermap entries and search paths that match the input path and the ordering matters.

Apr 25 2022, 12:09 PM · Restricted Project, Restricted Project
zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.
  • Use first match in getRelativeIncludeName
  • Try to get Preprocessor and reverse lookup headermaps in getRelativeIncludeName
  • Use getRelativeIncludeName to check for known files in LocationFileChecker
  • Misc fixes & adjustments
Apr 25 2022, 10:37 AM · Restricted Project, Restricted Project

Apr 14 2022

zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.

Add test case to demonstrate the framework case.

Apr 14 2022, 9:00 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123831: [clang][extract-api] Use relative includes.
Apr 14 2022, 8:25 PM · Restricted Project, Restricted Project
zixuw requested review of D123831: [clang][extract-api] Use relative includes.
Apr 14 2022, 7:52 PM · Restricted Project, Restricted Project

Apr 12 2022

zixuw accepted D123533: [clang][extract-api] Add support for true anonymous enums.

LGTM

Apr 12 2022, 10:55 AM · Restricted Project, Restricted Project
zixuw committed rGe08c435401bc: [clang][ExtractAPI][NFC] Fix sed delimiter in test (authored by zixuw).
[clang][ExtractAPI][NFC] Fix sed delimiter in test
Apr 12 2022, 10:04 AM · Restricted Project, Restricted Project
zixuw closed D123526: [clang][ExtractAPI][NFC] Fix sed delimiter in test.
Apr 12 2022, 10:04 AM · Restricted Project, Restricted Project
zixuw added inline comments to D123533: [clang][extract-api] Add support for true anonymous enums.
Apr 12 2022, 9:00 AM · Restricted Project, Restricted Project

Apr 11 2022

zixuw added inline comments to D123533: [clang][extract-api] Add support for true anonymous enums.
Apr 11 2022, 12:04 PM · Restricted Project, Restricted Project
zixuw added a reviewer for D123526: [clang][ExtractAPI][NFC] Fix sed delimiter in test: michele.scandale.
Apr 11 2022, 11:02 AM · Restricted Project, Restricted Project
zixuw requested review of D123526: [clang][ExtractAPI][NFC] Fix sed delimiter in test.
Apr 11 2022, 11:01 AM · Restricted Project, Restricted Project
zixuw accepted D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..

LGTM!

Apr 11 2022, 10:41 AM · Restricted Project, Restricted Project
zixuw added inline comments to D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..
Apr 11 2022, 10:00 AM · Restricted Project, Restricted Project

Apr 7 2022

zixuw added inline comments to D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..
Apr 7 2022, 11:40 AM · Restricted Project, Restricted Project
zixuw committed rG4048aad85a84: [clang][ExtractAPI] Fix declaration fragments for ObjC methods (authored by zixuw).
[clang][ExtractAPI] Fix declaration fragments for ObjC methods
Apr 7 2022, 10:23 AM · Restricted Project, Restricted Project
zixuw closed D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods.
Apr 7 2022, 10:23 AM · Restricted Project, Restricted Project
zixuw accepted D123295: [clang][extract-api] Use dedicated API to check for macro equality.

LGTM

Apr 7 2022, 9:51 AM · Restricted Project, Restricted Project
zixuw committed rGfe2c77a0065c: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments (authored by zixuw).
[clang][ExtractAPI] Fix appendSpace in DeclarationFragments
Apr 7 2022, 9:17 AM · Restricted Project, Restricted Project
zixuw closed D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments.
Apr 7 2022, 9:17 AM · Restricted Project, Restricted Project
zixuw accepted D123148: [clang][extract-api] Process only APIs declared in inputs.
Apr 7 2022, 9:04 AM · Restricted Project, Restricted Project

Apr 6 2022

zixuw added reviewers for D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods: QuietMisdreavus, ributzka.
Apr 6 2022, 2:59 PM · Restricted Project, Restricted Project
zixuw requested review of D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods.
Apr 6 2022, 2:58 PM · Restricted Project, Restricted Project
zixuw added reviewers for D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments: ributzka, QuietMisdreavus.
Apr 6 2022, 2:47 PM · Restricted Project, Restricted Project
zixuw requested review of D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments.
Apr 6 2022, 2:46 PM · Restricted Project, Restricted Project
zixuw committed rG178aad9b946e: [clang][extract-api] Add Objective-C Category support (authored by zixuw).
[clang][extract-api] Add Objective-C Category support
Apr 6 2022, 12:03 PM · Restricted Project, Restricted Project
zixuw closed D122774: [clang][extract-api] Add Objective-C Category support.
Apr 6 2022, 12:03 PM · Restricted Project, Restricted Project
zixuw updated the diff for D122774: [clang][extract-api] Add Objective-C Category support.

Remove extra commas in test case.

Apr 6 2022, 12:00 PM · Restricted Project, Restricted Project
zixuw updated the diff for D122774: [clang][extract-api] Add Objective-C Category support.

Rebase

Apr 6 2022, 11:41 AM · Restricted Project, Restricted Project
zixuw accepted D123019: [clang][extract-api] Add support for typedefs.
Apr 6 2022, 11:09 AM · Restricted Project, Restricted Project
zixuw accepted D123019: [clang][extract-api] Add support for typedefs.

LGTM! 🚢

Apr 6 2022, 10:10 AM · Restricted Project, Restricted Project
zixuw accepted D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

Unused include of declaration fragments in SymbolGraphSerializer. Otherwise LGTM!

Apr 6 2022, 10:08 AM · Restricted Project, Restricted Project