Page MenuHomePhabricator

zixuw (Zixu Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 28 2020, 11:15 AM (6 w, 1 d)

Recent Activity

Mon, Jul 6

zixuw committed rGf47b8851318d: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver (authored by zixuw).
[clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver
Mon, Jul 6, 2:52 PM
zixuw closed D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver.
Mon, Jul 6, 2:52 PM · Restricted Project
zixuw updated the diff for D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver.

Add a test case.

Mon, Jul 6, 1:27 PM · Restricted Project
Herald added a project to D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver: Restricted Project.
Mon, Jul 6, 12:26 PM · Restricted Project
zixuw added a comment to D82118: [clang][module] Improve incomplete-umbrella warning.

Ping

Mon, Jul 6, 9:59 AM · Restricted Project
zixuw added a reviewer for D82118: [clang][module] Improve incomplete-umbrella warning: vsapsai.
Mon, Jul 6, 9:58 AM · Restricted Project

Wed, Jul 1

zixuw committed rG66f3b625a078: Test commit (authored by zixuw).
Test commit
Wed, Jul 1, 10:16 AM

Mon, Jun 29

zixuw updated the summary of D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
Mon, Jun 29, 4:06 PM · Restricted Project
zixuw updated the diff for D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.

Abort the design of making 'Wundef' an alias to 'Wundef-prefix' because it
depends on the alias expansion to work, which adds an empty string to 'UndefPrefixes'
to do the trick. However, any other way to enable 'Wundef', for example, via 'Werror=undef'
or '#pragma clang diagnostic', will not work and cannot be handled easily.

Mon, Jun 29, 4:06 PM · Restricted Project
zixuw updated the diff for D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
  • Remove implementation details from the help text of 'Wundef';
  • Hide help text for 'Wundef-prefix' and 'Wundef'.
Mon, Jun 29, 1:36 PM · Restricted Project
zixuw updated the diff for D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
  • Refine test cases to check combinations of 'Wundef' and 'Wundef-prefix', and with/without 'Werror';
  • Fix issues with '-Werror=undef' by explicitly looking for the option.
Mon, Jun 29, 1:01 PM · Restricted Project

Thu, Jun 18

zixuw added reviewers for D82118: [clang][module] Improve incomplete-umbrella warning: arphaman, bruno, ributzka, rsmith.
Thu, Jun 18, 1:06 PM · Restricted Project
zixuw created D82118: [clang][module] Improve incomplete-umbrella warning.
Thu, Jun 18, 12:34 PM · Restricted Project

Tue, Jun 16

zixuw abandoned D81966: [clang][module] Improve -Wincomplete-umbrella.

Abandoning this revision because the upstream for this work is not correctly tracking the llvm.org branch.
The method setGenModuleActionWrapper is available in apple/master but not in llvm.

Tue, Jun 16, 5:01 PM · Restricted Project
zixuw added reviewers for D81966: [clang][module] Improve -Wincomplete-umbrella: arphaman, rsmith, bruno.
Tue, Jun 16, 2:18 PM · Restricted Project
zixuw created D81966: [clang][module] Improve -Wincomplete-umbrella.
Tue, Jun 16, 2:18 PM · Restricted Project

Fri, Jun 12

zixuw added inline comments to D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
Fri, Jun 12, 3:58 PM · Restricted Project

Jun 9 2020

zixuw added inline comments to D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
Jun 9 2020, 12:40 PM · Restricted Project
zixuw updated the diff for D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.

Update test case for #pragma clang diagnostic
Update test case to verify that the state of -Wundef can still be modified using #pragma clang diagnostic

Jun 9 2020, 12:07 PM · Restricted Project

Jun 8 2020

zixuw added inline comments to D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
Jun 8 2020, 4:39 PM · Restricted Project

May 28 2020

zixuw added a reviewer for D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option: rsmith.
May 28 2020, 12:38 PM · Restricted Project
zixuw updated the summary of D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
May 28 2020, 12:05 PM · Restricted Project
zixuw added reviewers for D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option: ributzka, steven_wu, cishida, bruno, arphaman.
May 28 2020, 12:05 PM · Restricted Project
zixuw created D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option.
May 28 2020, 12:05 PM · Restricted Project
zixuw abandoned D80748: [clang] Add '-Wundef-prefix' warning option.
May 28 2020, 11:33 AM · Restricted Project
zixuw created D80748: [clang] Add '-Wundef-prefix' warning option.
May 28 2020, 11:33 AM · Restricted Project