Page MenuHomePhabricator

zixuw (Zixu Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 28 2020, 11:15 AM (102 w, 6 d)

Recent Activity

Mon, May 16

zixuw accepted D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore.

clang-format failed:

---  clang-format

changed files:

    clang/test/ExtractAPI/underscored.c
Mon, May 16, 2:04 PM · Restricted Project, Restricted Project

Thu, May 5

zixuw added a comment to D125061: [clang] A more robust way to attach comments.

Well, apparently there are still some corner-case bugs in the logic. ExtractAPI and a few other tests failed. Will look into it tomorrow.

Thu, May 5, 7:12 PM · Restricted Project, Restricted Project
zixuw added reviewers for D125061: [clang] A more robust way to attach comments: ributzka, akyrtzi, doug.gregor, gribozavr.
Thu, May 5, 5:27 PM · Restricted Project, Restricted Project
zixuw requested review of D125061: [clang] A more robust way to attach comments.
Thu, May 5, 5:20 PM · Restricted Project, Restricted Project

Wed, May 4

zixuw added a reverting change for rG2966f0fa5052: Revert "[clang][extract-api] Use relative includes": rGcb5bb28511f2: Revert "Revert "[clang][extract-api] Use relative includes"".
Wed, May 4, 2:53 PM · Restricted Project, Restricted Project
zixuw committed rGcb5bb28511f2: Revert "Revert "[clang][extract-api] Use relative includes"" (authored by zixuw).
Revert "Revert "[clang][extract-api] Use relative includes""
Wed, May 4, 2:53 PM · Restricted Project, Restricted Project
zixuw closed D124964: Revert "Revert "[clang][extract-api] Use relative includes"".
Wed, May 4, 2:53 PM · Restricted Project, Restricted Project
zixuw added a comment to D124964: Revert "Revert "[clang][extract-api] Use relative includes"".

LGTM! If I understand the issue correctly we gave llvm::Regex::match a string temporary to match against before and now we store it for long enough to process the match results?

Wed, May 4, 2:51 PM · Restricted Project, Restricted Project
zixuw updated the diff for D124964: Revert "Revert "[clang][extract-api] Use relative includes"".

Whitespace change: clang-format removed an empty line

Wed, May 4, 2:36 PM · Restricted Project, Restricted Project
zixuw added a reverting change for rG2966f0fa5052: Revert "[clang][extract-api] Use relative includes": D124964: Revert "Revert "[clang][extract-api] Use relative includes"".
Wed, May 4, 2:27 PM · Restricted Project, Restricted Project
zixuw requested review of D124964: Revert "Revert "[clang][extract-api] Use relative includes"".
Wed, May 4, 2:26 PM · Restricted Project, Restricted Project
zixuw committed rG2966f0fa5052: Revert "[clang][extract-api] Use relative includes" (authored by zixuw).
Revert "[clang][extract-api] Use relative includes"
Wed, May 4, 12:28 PM · Restricted Project, Restricted Project
zixuw added a reverting change for rG4c262fee08b5: [clang][extract-api] Use relative includes: rG2966f0fa5052: Revert "[clang][extract-api] Use relative includes".
Wed, May 4, 12:28 PM · Restricted Project, Restricted Project
zixuw added a reverting change for D123831: [clang][extract-api] Use relative includes: rG2966f0fa5052: Revert "[clang][extract-api] Use relative includes".
Wed, May 4, 12:28 PM · Restricted Project, Restricted Project
zixuw added a comment to D123831: [clang][extract-api] Use relative includes.

Accidentally added another test case in my local workspace. Removed in 5f841c71fc2cc77c92f526791cd7a938bcac69aa

Wed, May 4, 10:45 AM · Restricted Project, Restricted Project
zixuw committed rG5f841c71fc2c: [NFC] Remove unfinished test case (authored by zixuw).
[NFC] Remove unfinished test case
Wed, May 4, 10:42 AM · Restricted Project, Restricted Project
zixuw committed rG4c262fee08b5: [clang][extract-api] Use relative includes (authored by zixuw).
[clang][extract-api] Use relative includes
Wed, May 4, 10:28 AM · Restricted Project, Restricted Project
zixuw closed D123831: [clang][extract-api] Use relative includes.
Wed, May 4, 10:28 AM · Restricted Project, Restricted Project
zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.

Update test case to use cc1 instead of driver

Wed, May 4, 10:27 AM · Restricted Project, Restricted Project
zixuw added a comment to D123831: [clang][extract-api] Use relative includes.

Since this is a new test can we use the approach in https://reviews.llvm.org/D124634 to check for diagnostics output.

Wed, May 4, 10:00 AM · Restricted Project, Restricted Project

Tue, May 3

zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.
  • Capture whether the include is quoted in KnownFiles
  • Misc: use getInputBufferName() instead of string literal
Tue, May 3, 12:24 PM · Restricted Project, Restricted Project

Mon, May 2

zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.

Convert file path to use slashes for headermap reverse lookup

Mon, May 2, 5:29 PM · Restricted Project, Restricted Project
zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.
  • Delete test known_files_only_hmap
  • Handle quoted includes
  • Attempt to fix Windows fails by converting backslashes before matching the framework regex
  • Update test relative_include
Mon, May 2, 4:15 PM · Restricted Project, Restricted Project

Thu, Apr 28

zixuw accepted D124638: [clang] Track how headers get included generally during lookup time.

LGTM!

Thu, Apr 28, 2:38 PM · Restricted Project, Restricted Project

Mon, Apr 25

zixuw retitled D123831: [clang][extract-api] Use relative includes from [POC][WIP] Use relative include in extract-api to [clang][extract-api] Use relative includes.
Mon, Apr 25, 5:51 PM · Restricted Project, Restricted Project
zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.
  • Rewrite commit message for preparation
  • Remove shortening paths based on the current working directory: it does not work with angled includes, and unnecessary for our use
  • XFAIL test known_files_only_hmap.c, as it is not a valid setup with a questionable headermap. Need to determine how to fix that test case or just discard it, as the new relative_include.m test also checks that symbols from external files are dropped
Mon, Apr 25, 5:48 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123831: [clang][extract-api] Use relative includes.
Mon, Apr 25, 5:25 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123831: [clang][extract-api] Use relative includes.
Mon, Apr 25, 3:39 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123831: [clang][extract-api] Use relative includes.
Mon, Apr 25, 3:33 PM · Restricted Project, Restricted Project
zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.
  • Create FileManager in PrepareToExecuteAction
  • Use FileManager to load headermaps and reverse lookup mappings
  • Use FileSystem to correctly get working directory and make absolute paths
Mon, Apr 25, 1:28 PM · Restricted Project, Restricted Project
zixuw added a comment to D123831: [clang][extract-api] Use relative includes.

The problem is that we are trying to shorten the input file paths in PrepareToExecuteAction, where the CompilerInstance is still primal and doesn't even have a FileManager that we could use. That makes it hard (if possible at all) to reverse lookup headermaps and use the spelled names if we failed to find a search path prefix.
The impact is that we won't be able to get an angled include name for cases where an input doesn't reside in any of the normal search paths, but a headermap entry maps some name to that path. Or we might get the wrong include name where there are both headermap entries and search paths that match the input path and the ordering matters.

Mon, Apr 25, 12:09 PM · Restricted Project, Restricted Project
zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.
  • Use first match in getRelativeIncludeName
  • Try to get Preprocessor and reverse lookup headermaps in getRelativeIncludeName
  • Use getRelativeIncludeName to check for known files in LocationFileChecker
  • Misc fixes & adjustments
Mon, Apr 25, 10:37 AM · Restricted Project, Restricted Project

Apr 14 2022

zixuw updated the diff for D123831: [clang][extract-api] Use relative includes.

Add test case to demonstrate the framework case.

Apr 14 2022, 9:00 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123831: [clang][extract-api] Use relative includes.
Apr 14 2022, 8:25 PM · Restricted Project, Restricted Project
zixuw requested review of D123831: [clang][extract-api] Use relative includes.
Apr 14 2022, 7:52 PM · Restricted Project, Restricted Project

Apr 12 2022

zixuw accepted D123533: [clang][extract-api] Add support for true anonymous enums.

LGTM

Apr 12 2022, 10:55 AM · Restricted Project, Restricted Project
zixuw committed rGe08c435401bc: [clang][ExtractAPI][NFC] Fix sed delimiter in test (authored by zixuw).
[clang][ExtractAPI][NFC] Fix sed delimiter in test
Apr 12 2022, 10:04 AM · Restricted Project, Restricted Project
zixuw closed D123526: [clang][ExtractAPI][NFC] Fix sed delimiter in test.
Apr 12 2022, 10:04 AM · Restricted Project, Restricted Project
zixuw added inline comments to D123533: [clang][extract-api] Add support for true anonymous enums.
Apr 12 2022, 9:00 AM · Restricted Project, Restricted Project

Apr 11 2022

zixuw added inline comments to D123533: [clang][extract-api] Add support for true anonymous enums.
Apr 11 2022, 12:04 PM · Restricted Project, Restricted Project
zixuw added a reviewer for D123526: [clang][ExtractAPI][NFC] Fix sed delimiter in test: michele.scandale.
Apr 11 2022, 11:02 AM · Restricted Project, Restricted Project
zixuw requested review of D123526: [clang][ExtractAPI][NFC] Fix sed delimiter in test.
Apr 11 2022, 11:01 AM · Restricted Project, Restricted Project
zixuw accepted D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..

LGTM!

Apr 11 2022, 10:41 AM · Restricted Project, Restricted Project
zixuw added inline comments to D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..
Apr 11 2022, 10:00 AM · Restricted Project, Restricted Project

Apr 7 2022

zixuw added inline comments to D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..
Apr 7 2022, 11:40 AM · Restricted Project, Restricted Project
zixuw committed rG4048aad85a84: [clang][ExtractAPI] Fix declaration fragments for ObjC methods (authored by zixuw).
[clang][ExtractAPI] Fix declaration fragments for ObjC methods
Apr 7 2022, 10:23 AM · Restricted Project, Restricted Project
zixuw closed D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods.
Apr 7 2022, 10:23 AM · Restricted Project, Restricted Project
zixuw accepted D123295: [clang][extract-api] Use dedicated API to check for macro equality.

LGTM

Apr 7 2022, 9:51 AM · Restricted Project, Restricted Project
zixuw committed rGfe2c77a0065c: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments (authored by zixuw).
[clang][ExtractAPI] Fix appendSpace in DeclarationFragments
Apr 7 2022, 9:17 AM · Restricted Project, Restricted Project
zixuw closed D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments.
Apr 7 2022, 9:17 AM · Restricted Project, Restricted Project
zixuw accepted D123148: [clang][extract-api] Process only APIs declared in inputs.
Apr 7 2022, 9:04 AM · Restricted Project, Restricted Project

Apr 6 2022

zixuw added reviewers for D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods: QuietMisdreavus, ributzka.
Apr 6 2022, 2:59 PM · Restricted Project, Restricted Project
zixuw requested review of D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods.
Apr 6 2022, 2:58 PM · Restricted Project, Restricted Project
zixuw added reviewers for D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments: ributzka, QuietMisdreavus.
Apr 6 2022, 2:47 PM · Restricted Project, Restricted Project
zixuw requested review of D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments.
Apr 6 2022, 2:46 PM · Restricted Project, Restricted Project
zixuw committed rG178aad9b946e: [clang][extract-api] Add Objective-C Category support (authored by zixuw).
[clang][extract-api] Add Objective-C Category support
Apr 6 2022, 12:03 PM · Restricted Project, Restricted Project
zixuw closed D122774: [clang][extract-api] Add Objective-C Category support.
Apr 6 2022, 12:03 PM · Restricted Project, Restricted Project
zixuw updated the diff for D122774: [clang][extract-api] Add Objective-C Category support.

Remove extra commas in test case.

Apr 6 2022, 12:00 PM · Restricted Project, Restricted Project
zixuw updated the diff for D122774: [clang][extract-api] Add Objective-C Category support.

Rebase

Apr 6 2022, 11:41 AM · Restricted Project, Restricted Project
zixuw accepted D123019: [clang][extract-api] Add support for typedefs.
Apr 6 2022, 11:09 AM · Restricted Project, Restricted Project
zixuw accepted D123019: [clang][extract-api] Add support for typedefs.

LGTM! 🚢

Apr 6 2022, 10:10 AM · Restricted Project, Restricted Project
zixuw accepted D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

Unused include of declaration fragments in SymbolGraphSerializer. Otherwise LGTM!

Apr 6 2022, 10:08 AM · Restricted Project, Restricted Project

Apr 5 2022

zixuw added inline comments to D123148: [clang][extract-api] Process only APIs declared in inputs.
Apr 5 2022, 1:20 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123019: [clang][extract-api] Add support for typedefs.
Apr 5 2022, 12:33 PM · Restricted Project, Restricted Project

Apr 4 2022

zixuw added inline comments to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
Apr 4 2022, 3:54 PM · Restricted Project, Restricted Project
zixuw updated the diff for D122774: [clang][extract-api] Add Objective-C Category support.

Address review comment:

  • Use llvm_unreachable for the Objective-C category case in serializeSymbolKind
Apr 4 2022, 3:44 PM · Restricted Project, Restricted Project
zixuw added inline comments to D122774: [clang][extract-api] Add Objective-C Category support.
Apr 4 2022, 3:43 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
Apr 4 2022, 3:42 PM · Restricted Project, Restricted Project
zixuw added a comment to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

After a quick scan comparing the current output of these symbol graphs with the primary library used for reading them, the last thing i can spot that's "off" is that the "function signature" is currently being serialized under a parameters field instead of the required functionSignature.

Apr 4 2022, 3:35 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123019: [clang][extract-api] Add support for typedefs.
Apr 4 2022, 2:07 PM · Restricted Project, Restricted Project
zixuw added inline comments to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
Apr 4 2022, 2:02 PM · Restricted Project, Restricted Project
zixuw accepted D123056: [clang][extract-api] Undefining macros should not result in a crash.

Ha! Nice catch!

Apr 4 2022, 1:32 PM · Restricted Project, Restricted Project
zixuw added a comment to D122798: [clang][extract-api][NFC] Add documentation.

Has this landed yet?

Apr 4 2022, 10:54 AM · Restricted Project, Restricted Project

Mar 31 2022

zixuw updated the diff for D122774: [clang][extract-api] Add Objective-C Category support.

Add missing documentatin for ObjCCategoryRecord.

Mar 31 2022, 8:25 AM · Restricted Project, Restricted Project
zixuw accepted D122798: [clang][extract-api][NFC] Add documentation.
Mar 31 2022, 8:22 AM · Restricted Project, Restricted Project

Mar 30 2022

zixuw added reviewers for D122774: [clang][extract-api] Add Objective-C Category support: ributzka, QuietMisdreavus.
Mar 30 2022, 5:30 PM · Restricted Project, Restricted Project
zixuw updated the diff for D122774: [clang][extract-api] Add Objective-C Category support.

Remove probably unnecessary includes added automatically by clangd.

Mar 30 2022, 5:29 PM · Restricted Project, Restricted Project
zixuw requested review of D122774: [clang][extract-api] Add Objective-C Category support.
Mar 30 2022, 5:25 PM · Restricted Project, Restricted Project
zixuw accepted D122611: [clang][extract-api] Add support for macros.

LGTM!

Mar 30 2022, 10:26 AM · Restricted Project, Restricted Project
zixuw accepted D122648: [clang][extractapi] Tie API and serialization to the FrontendAction.

LGTM!

Mar 30 2022, 10:26 AM · Restricted Project, Restricted Project

Mar 29 2022

zixuw added inline comments to D122611: [clang][extract-api] Add support for macros.
Mar 29 2022, 3:11 PM · Restricted Project, Restricted Project
zixuw committed rGd1d34bafef56: [clang][extract-api] Add Objective-C protocol support (authored by zixuw).
[clang][extract-api] Add Objective-C protocol support
Mar 29 2022, 2:45 PM · Restricted Project, Restricted Project
zixuw closed D122511: [clang][extract-api] Add Objective-C protocol support.
Mar 29 2022, 2:45 PM · Restricted Project, Restricted Project
zixuw committed rG9b36e126fdb1: [clang][extract-api] Add Objective-C interface support (authored by zixuw).
[clang][extract-api] Add Objective-C interface support
Mar 29 2022, 2:30 PM · Restricted Project, Restricted Project
zixuw closed D122446: [clang][extract-api] Add Objective-C interface support.
Mar 29 2022, 2:29 PM · Restricted Project, Restricted Project
zixuw added a comment to D122648: [clang][extractapi] Tie API and serialization to the FrontendAction.

Mostly LGTM after addressing the inline comments.

Mar 29 2022, 11:30 AM · Restricted Project, Restricted Project
zixuw added inline comments to D122446: [clang][extract-api] Add Objective-C interface support.
Mar 29 2022, 10:31 AM · Restricted Project, Restricted Project
zixuw committed rG15bf0e567375: [clang][extract-api] Use correct language info from inputs (authored by zixuw).
[clang][extract-api] Use correct language info from inputs
Mar 29 2022, 10:06 AM · Restricted Project, Restricted Project
zixuw closed D122495: [clang][extract-api] Use correct language info from inputs.
Mar 29 2022, 10:06 AM · Restricted Project, Restricted Project

Mar 28 2022

zixuw added inline comments to D122611: [clang][extract-api] Add support for macros.
Mar 28 2022, 5:31 PM · Restricted Project, Restricted Project
zixuw added inline comments to D122511: [clang][extract-api] Add Objective-C protocol support.
Mar 28 2022, 5:22 PM · Restricted Project, Restricted Project
zixuw updated the diff for D122511: [clang][extract-api] Add Objective-C protocol support.

Rebase upstream changes in D122446:

  • Move the change of the objc_interface.m test to D122446.
Mar 28 2022, 5:22 PM · Restricted Project, Restricted Project
zixuw added inline comments to D122446: [clang][extract-api] Add Objective-C interface support.
Mar 28 2022, 5:13 PM · Restricted Project, Restricted Project
D12251: Analyzer: Calculate field offset correctly now requires changes to proceed.
Mar 28 2022, 5:13 PM
zixuw updated the diff for D122446: [clang][extract-api] Add Objective-C interface support.
  • Address review comments:
    • Use template to reuse logic for building function signatures for FunctionDecl and ObjCMethodDecl.
  • Move the change of objc_interface.m test in this patch from D122511.
Mar 28 2022, 5:13 PM · Restricted Project, Restricted Project
zixuw updated the diff for D122495: [clang][extract-api] Use correct language info from inputs.

Address review issues.

Mar 28 2022, 4:23 PM · Restricted Project, Restricted Project
zixuw added inline comments to D122495: [clang][extract-api] Use correct language info from inputs.
Mar 28 2022, 4:23 PM · Restricted Project, Restricted Project
zixuw added a comment to D122611: [clang][extract-api] Add support for macros.

Still going through the declaration fragments builder and ExtractAPIVisitor/Consumer/Action changes, but it seems that the patch needs a rebase onto the latest main right now as it's missing several already landed changes.

Mar 28 2022, 2:15 PM · Restricted Project, Restricted Project

Mar 25 2022

zixuw updated the summary of D122446: [clang][extract-api] Add Objective-C interface support.
Mar 25 2022, 3:19 PM · Restricted Project, Restricted Project
zixuw added reviewers for D122511: [clang][extract-api] Add Objective-C protocol support: ributzka, QuietMisdreavus.
Mar 25 2022, 3:19 PM · Restricted Project, Restricted Project