This is an archive of the discontinued LLVM Phabricator instance.

[SLP][AArch64] Add test to check for the vectorization of fshl
ClosedPublic

Authored by zjaffal on Mar 28 2023, 8:49 AM.

Details

Summary

Currently the cost for fshl is an overestimate causing SLP to vectorize when it is not necessary.

Diff Detail

Event Timeline

zjaffal created this revision.Mar 28 2023, 8:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 8:49 AM
zjaffal requested review of this revision.Mar 28 2023, 8:49 AM
fhahn accepted this revision.Mar 28 2023, 9:34 AM

LGTM, thanks! Maybe drop the -vectorize part from the name :)

llvm/test/Transforms/SLPVectorizer/AArch64/fshl-vectorize.ll
3 ↗(On Diff #509037)

Can you add a newline before and remove the newline before the function definition?

This revision is now accepted and ready to land.Mar 28 2023, 9:34 AM
This revision was landed with ongoing or failed builds.Mar 28 2023, 9:46 AM
This revision was automatically updated to reflect the committed changes.