Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Looks good but is this really NFC ?
I.e. replacePayloadOp used to implicitly also replacePayloadValues and now we fail hard.
Is this a standalone applicable first step or does it need to land at the same time as dependent changes to avoid breaking downstream?
mlir/test/lib/Dialect/Transform/TestTransformStateExtension.cpp | ||
---|---|---|
25 | nit: less -> fewer |
Comment Actions
Removed the NFC. This requires downstream changes if replacePayloadOp is used. In the case of IREE, it should be integrated together with D147039, then the integration fix is simply deleting the IREE TrackingListener.
nit: less -> fewer