This is an archive of the discontinued LLVM Phabricator instance.

Differential D147035

[mlir] Add missing dependency to Bazel build fails.
AbandonedPublic

Authored by ingomueller-net on Mar 28 2023, 2:29 AM.

Download Raw Diff

Details

Reviewers

Summary

The dependency was introduced in the CMake files in
https://reviews.llvm.org/D146959.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ingomueller-net created this revision.Mar 28 2023, 2:29 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 2:29 AM

Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 21 others. · View Herald Transcript

ingomueller-net requested review of this revision.Mar 28 2023, 2:29 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 2:29 AM

Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Feel free to commit such changes directly.

This revision is now accepted and ready to land.Mar 28 2023, 2:30 AM

ftynse added inline comments.Mar 28 2023, 2:30 AM

utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
524–525	Nit: keep sorted alphabetically.

Sorting dependencies alphabetically.

Harbormaster completed remote builds in B222193: Diff 508938.Mar 28 2023, 2:56 AM

Abanding since cf115f30 fixed the problem in the meantime.

Revision Contents

Path

Size

utils/

bazel/

llvm-project-overlay/

mlir/

test/

2 lines

Diff 508938

utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel

	Show First 20 Lines • Show All 513 Lines • ▼ Show 20 Lines		cc_library(
	defines = ["MLIR_CUDA_CONVERSIONS_ENABLED"],			defines = ["MLIR_CUDA_CONVERSIONS_ENABLED"],
	includes = ["lib/Dialect/Test"],			includes = ["lib/Dialect/Test"],
	deps = [			deps = [
	":TestDialect",			":TestDialect",
	"//mlir:FuncDialect",			"//mlir:FuncDialect",
	"//mlir:FuncTransforms",			"//mlir:FuncTransforms",
	"//mlir:IR",			"//mlir:IR",
	"//mlir:Pass",			"//mlir:Pass",
				"//mlir:SCFDialect",
				"//mlir:SCFTransforms",
	"//mlir:TransformUtils",			"//mlir:TransformUtils",
	],			],
				ftynseUnsubmitted Not Done Reply Inline Actions Nit: keep sorted alphabetically. ftynse: Nit: keep sorted alphabetically.
	)			)

	cc_library(			cc_library(
	name = "TestVectorToSPIRV",			name = "TestVectorToSPIRV",
	srcs = glob(["lib/Conversion/VectorToSPIRV/*.cpp"]),			srcs = glob(["lib/Conversion/VectorToSPIRV/*.cpp"]),
	deps = [			deps = [
	"//mlir:ArithDialect",			"//mlir:ArithDialect",
	"//mlir:FuncDialect",			"//mlir:FuncDialect",
	▲ Show 20 Lines • Show All 426 Lines • Show Last 20 Lines