[RISCV] Replace an 'else if' with 'else'+assert. NFC

[craig.topper]

Summary

There are only two cases here. Using an assert ensures there is
no handled third case.

Also move comment to avoid odd formatting.

[reames]

LGTM

llvm/lib/Target/RISCV/RISCVGatherScatterLowering.cpp

static std::pair<Value *, Value *> matchStridedStart(Value *Start,
   Value *Stride;
   std::tie(Start, Stride) = matchStridedStart(BO->getOperand(OtherIndex),
                                               Builder);
   if (!Start)
     return std::make_pair(nullptr, nullptr);
 
   Builder.SetInsertPoint(BO);
   Builder.SetCurrentDebugLocation(DebugLoc());
-  // Add the splat value to the start
+  // Add the splat value to the start or multiply the start and stride by the
+  // splat.
   if (BO->getOpcode() == Instruction::Add) {
     Start = Builder.CreateAdd(Start, Splat);
-  }
-  // Or multiply the start and stride by the splat.
-  else if (BO->getOpcode() == Instruction::Mul) {
+  } else {
+    assert(BO->getOpcode() == Instruction::Mul && "Unexpected opcode");
     Start = Builder.CreateMul(Start, Splat);
     Stride = Builder.CreateMul(Stride, Splat);
   }
   return std::make_pair(Start, Stride);
 }
 
 // Recursively, walk about the use-def chain until we find a Phi with a strided
 // start value. Build and update a scalar recurrence as we unwind the recursion.