Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D146841

[WebAssembly] Use ArrayRef/SmallVectorImpl in parameters (NFC)
ClosedPublic
Actions

Authored by aheejin on Mar 24 2023, 12:23 PM.

Details

Reviewers
dschuff
Commits
rGcfd36aa5b773: [WebAssembly] Use ArrayRef/SmallVectorImpl in parameters (NFC)
Summary

It is recommended to use SmallVectorImpl/ArrayRef over
SmallVector<TypeName, N> for function parameters:
https://llvm.org/docs/ProgrammersManual.html#llvm-adt-smallvector-h

Diff Detail

Event Timeline

aheejin created this revision.Mar 24 2023, 12:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2023, 12:23 PM
Herald added subscribers: pmatos, asb, wingo and 5 others. · View Herald Transcript
aheejin requested review of this revision.Mar 24 2023, 12:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2023, 12:23 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
dschuff accepted this revision.Mar 24 2023, 1:06 PM

cool, LGTM!

This revision is now accepted and ready to land.Mar 24 2023, 1:06 PM
Harbormaster completed remote builds in B221668: Diff 508194.Mar 24 2023, 1:19 PM
Closed by commit rGcfd36aa5b773: [WebAssembly] Use ArrayRef/SmallVectorImpl in parameters (NFC) (authored by aheejin). · Explain WhyMar 29 2023, 12:48 PM
This revision was automatically updated to reflect the committed changes.
aheejin added a commit: rGcfd36aa5b773: [WebAssembly] Use ArrayRef/SmallVectorImpl in parameters (NFC).

Revision Contents
Changeset List

Diff 508194

View Options

llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.h

Loading...
View Options

llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp

Loading...
View Options

llvm/lib/Target/WebAssembly/Utils/WebAssemblyTypeUtilities.h

Loading...
View Options

llvm/lib/Target/WebAssembly/Utils/WebAssemblyTypeUtilities.cpp

Loading...
View Options

llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.h

Loading...
View Options

llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp

Loading...