This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Tidy up DebugValueManager (NFC)
ClosedPublic

Authored by aheejin on Mar 23 2023, 10:52 AM.

Details

Summary

Misc. cleanups for WebAssemblyDebugValueManager.

  • Use Register for registers
  • Simpler for loop iteration
  • Rename a variable
  • Reorder methods
  • Reduce SmallVector size for DBG_VALUEs to 1; one def usually have a single DBG_VALUE attached to it in most cases
  • Add a few more lines of comments

Diff Detail

Event Timeline

aheejin created this revision.Mar 23 2023, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 10:52 AM
Herald added subscribers: pmatos, asb, wingo and 5 others. · View Herald Transcript
aheejin requested review of this revision.Mar 23 2023, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 10:52 AM
aheejin retitled this revision from [WebAssembly] Tidy up DebugValueManager to [WebAssembly] Tidy up DebugValueManager (NFC).Mar 23 2023, 10:55 AM
dschuff accepted this revision.Mar 23 2023, 2:31 PM
dschuff added inline comments.
llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.h
12
This revision is now accepted and ready to land.Mar 23 2023, 2:31 PM
This revision was landed with ongoing or failed builds.Mar 23 2023, 3:35 PM
This revision was automatically updated to reflect the committed changes.
aheejin marked an inline comment as done.