This is an archive of the discontinued LLVM Phabricator instance.

Differential D146718

[LV] Add tests for integer min max with index reduction pattern. (NFC)
ClosedPublic

Authored by Mel-Chen on Mar 23 2023, 6:02 AM.

Details

Reviewers
fhahn
Commits
rGde01dba7f229: [LV] Add tests for integer min max with index reduction pattern. (NFC)
Summary

The test case for signed max with index, include strict and non-strict
max.

Diff Detail

Event Timeline

Mel-Chen created this revision.Mar 23 2023, 6:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 6:02 AM
Herald added a subscriber: arphaman. · View Herald Transcript
Mel-Chen requested review of this revision.Mar 23 2023, 6:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 6:02 AM
Herald added subscribers: llvm-commits, • pcwang-thead. · View Herald Transcript
Mel-Chen added a child revision: D143465: [LoopVectorize] Vectorize the reduction pattern of integer min/max with index..Mar 23 2023, 6:03 AM
Mel-Chen added a reviewer: fhahn.
Herald added a subscriber: StephenFan. · View Herald TranscriptMar 23 2023, 6:05 AM
Harbormaster completed remote builds in B221295: Diff 507715.Mar 23 2023, 7:21 AM
Mel-Chen added a comment.Apr 12 2023, 6:15 AM

@fhahn Ping

fhahn accepted this revision.Apr 23 2023, 12:25 PM

LGTM, thanks!

llvm/test/Transforms/LoopVectorize/smax-idx.ll
2

this doesn't check any debug output, so maybe remove -debug-only=? If it needs to check debug output, this needs REQUIRES: asserts otherwise it will fail with assertions disabled (which removes debug-only support.

14

nit: remove unnecessary indvars prefix.

43

stray ;; at end?

This revision is now accepted and ready to land.Apr 23 2023, 12:25 PM
Mel-Chen updated this revision to Diff 517833.Apr 28 2023, 1:27 AM

Updates according to comments.

Harbormaster completed remote builds in B228765: Diff 517833.Apr 28 2023, 2:15 AM
This revision was landed with ongoing or failed builds.Apr 28 2023, 5:13 AM
Closed by commit rGde01dba7f229: [LV] Add tests for integer min max with index reduction pattern. (NFC) (authored by Mel-Chen). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mel-Chen marked 2 inline comments as done.
Mel-Chen added a commit: rGde01dba7f229: [LV] Add tests for integer min max with index reduction pattern. (NFC).

Revision Contents

PathSize
llvm/
test/
Transforms/
LoopVectorize/
234 lines

Diff 517878

llvm/test/Transforms/LoopVectorize/smax-idx.ll

  • This file was added.
; RUN: opt -passes=loop-vectorize -force-vector-width=4 -force-vector-interleave=1 -S < %s | FileCheck %s --check-prefix=CHECK
; RUN: opt -passes=loop-vectorize -force-vector-width=4 -force-vector-interleave=4 -S < %s | FileCheck %s --check-prefix=CHECK
fhahnUnsubmitted
Done
ReplyInline Actions

this doesn't check any debug output, so maybe remove -debug-only=? If it needs to check debug output, this needs REQUIRES: asserts otherwise it will fail with assertions disabled (which removes debug-only support.

fhahn: this doesn't check any debug output, so maybe remove `-debug-only=`? If it needs to check…
; RUN: opt -passes=loop-vectorize -force-vector-width=1 -force-vector-interleave=4 -S < %s | FileCheck %s --check-prefix=CHECK
define i64 @smax_idx(ptr nocapture readonly %a, i64 %mm, i64 %ii, ptr nocapture writeonly %res_max, i64 %n) {
; CHECK-LABEL: @smax_idx(
; CHECK-NOT: vector.body:
;
entry:
br label %for.body
for.body:
%indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
%max.09 = phi i64 [ %mm, %entry ], [ %1, %for.body ]
fhahnUnsubmitted
Not Done
ReplyInline Actions

nit: remove unnecessary indvars prefix.

fhahn: nit: remove unnecessary `indvars` prefix.
%idx.011 = phi i64 [ %ii, %entry ], [ %spec.select7, %for.body ]
%arrayidx = getelementptr inbounds i64, ptr %a, i64 %indvars.iv
%0 = load i64, ptr %arrayidx
%1 = tail call i64 @llvm.smax.i64(i64 %max.09, i64 %0)
%cmp1 = icmp slt i64 %max.09, %0
%spec.select7 = select i1 %cmp1, i64 %indvars.iv, i64 %idx.011
%indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
%exitcond.not = icmp eq i64 %indvars.iv.next, %n
br i1 %exitcond.not, label %exit, label %for.body
exit:
store i64 %1, ptr %res_max
ret i64 %spec.select7
}
;
; Check the different order of reduction phis.
;
define i64 @smax_idx_inverted_phi(ptr nocapture readonly %a, i64 %mm, i64 %ii, ptr nocapture writeonly %res_max, i64 %n) {
; CHECK-LABEL: @smax_idx_inverted_phi(
; CHECK-NOT: vector.body:
;
entry:
br label %for.body
for.body:
%indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
%idx.011 = phi i64 [ %ii, %entry ], [ %spec.select7, %for.body ]
%max.09 = phi i64 [ %mm, %entry ], [ %1, %for.body ]
fhahnUnsubmitted
Done
ReplyInline Actions

stray ;; at end?

fhahn: stray `;;` at end?
%arrayidx = getelementptr inbounds i64, ptr %a, i64 %indvars.iv
%0 = load i64, ptr %arrayidx
%1 = tail call i64 @llvm.smax.i64(i64 %max.09, i64 %0)
%cmp1 = icmp slt i64 %max.09, %0
%spec.select7 = select i1 %cmp1, i64 %indvars.iv, i64 %idx.011
%indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
%exitcond.not = icmp eq i64 %indvars.iv.next, %n
br i1 %exitcond.not, label %exit, label %for.body
exit:
store i64 %1, ptr %res_max
ret i64 %spec.select7
}
; Check if it is a MMI when smax is not used outside the loop.
;
; Currently at the end, it will check if smax has exitInstruction.
; But in fact MMI should be possible to use the exitInstruction of
; SelectICmp be the exitInstruction.
;
define i64 @smax_idx_max_no_exit_user(ptr nocapture readonly %a, i64 %mm, i64 %ii, i64 %n) {
; CHECK-LABEL: @smax_idx_max_no_exit_user(
; CHECK-NOT: vector.body:
;
entry:
br label %for.body
for.body:
%indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
%max.09 = phi i64 [ %mm, %entry ], [ %1, %for.body ]
%idx.011 = phi i64 [ %ii, %entry ], [ %spec.select7, %for.body ]
%arrayidx = getelementptr inbounds i64, ptr %a, i64 %indvars.iv
%0 = load i64, ptr %arrayidx
%1 = tail call i64 @llvm.smax.i64(i64 %max.09, i64 %0)
%cmp1 = icmp slt i64 %max.09, %0
%spec.select7 = select i1 %cmp1, i64 %indvars.iv, i64 %idx.011
%indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
%exitcond.not = icmp eq i64 %indvars.iv.next, %n
br i1 %exitcond.not, label %exit, label %for.body
exit:
; %1 has no external users
ret i64 %spec.select7
}
; Check smax implemented in terms of select(cmp()).
;
; Currently SelectICmp does not support icmp with multiple users.
; It may be possible to reuse some of the methods in Combination pass to check
; whether icmp can be copied.
;
define i64 @smax_idx_select_cmp(ptr nocapture readonly %a, i64 %mm, i64 %ii, ptr nocapture writeonly %res_max, i64 %n) {
; CHECK-LABEL: @smax_idx_select_cmp(
; CHECK-NOT: vector.body:
;
entry:
br label %for.body
for.body:
%indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
%max.09 = phi i64 [ %mm, %entry ], [ %spec.select, %for.body ]
%idx.011 = phi i64 [ %ii, %entry ], [ %spec.select7, %for.body ]
%arrayidx = getelementptr inbounds i64, ptr %a, i64 %indvars.iv
%0 = load i64, ptr %arrayidx
%cmp1 = icmp slt i64 %max.09, %0
%spec.select = select i1 %cmp1, i64 %0, i64 %max.09
%spec.select7 = select i1 %cmp1, i64 %indvars.iv, i64 %idx.011
%indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
%exitcond.not = icmp eq i64 %indvars.iv.next, %n
br i1 %exitcond.not, label %exit, label %for.body
exit:
store i64 %spec.select, ptr %res_max
ret i64 %spec.select7
}
;
; Check sge case.
;
define i64 @smax_idx_inverted_pred(ptr nocapture readonly %a, i64 %mm, i64 %ii, ptr nocapture writeonly %res_max, i64 %n) {
; CHECK-LABEL: @smax_idx_inverted_pred(
; CHECK-NOT: vector.body:
;
entry:
br label %for.body
for.body:
%indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
%max.09 = phi i64 [ %mm, %entry ], [ %1, %for.body ]
%idx.011 = phi i64 [ %ii, %entry ], [ %spec.select7, %for.body ]
%arrayidx = getelementptr inbounds i64, ptr %a, i64 %indvars.iv
%0 = load i64, ptr %arrayidx
%1 = tail call i64 @llvm.smax.i64(i64 %max.09, i64 %0)
%cmp1 = icmp sge i64 %0, %max.09
%spec.select7 = select i1 %cmp1, i64 %indvars.iv, i64 %idx.011
%indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
%exitcond.not = icmp eq i64 %indvars.iv.next, %n
br i1 %exitcond.not, label %exit, label %for.body
exit:
store i64 %1, ptr %res_max
ret i64 %spec.select7
}
;
; In such cases, the last index should be extracted.
;
define i64 @smax_idx_extract_last(ptr nocapture readonly %a, i64 %mm, i64 %ii, ptr nocapture writeonly %res_max, i64 %n) {
; CHECK-LABEL: @smax_idx_extract_last(
; CHECK-NOT: vector.body:
;
entry:
br label %for.body
for.body:
%indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
%max.09 = phi i64 [ %mm, %entry ], [ %1, %for.body ]
%idx.011 = phi i64 [ %ii, %entry ], [ %spec.select7, %for.body ]
%arrayidx = getelementptr inbounds i64, ptr %a, i64 %indvars.iv
%0 = load i64, ptr %arrayidx
%1 = tail call i64 @llvm.smax.i64(i64 %max.09, i64 %0)
%cmp1.not = icmp sgt i64 %max.09, %0
%spec.select7 = select i1 %cmp1.not, i64 %idx.011, i64 %indvars.iv
%indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
%exitcond.not = icmp eq i64 %indvars.iv.next, %n
br i1 %exitcond.not, label %exit, label %for.body
exit:
store i64 %1, ptr %res_max
ret i64 %spec.select7
}
;
; The operands of smax intrinsic and icmp are not the same to be recognized as MMI.
;
define i64 @smax_idx_not_vec_1(ptr nocapture readonly %a, ptr nocapture readonly %b, i64 %mm, i64 %ii, ptr nocapture writeonly %res_max, i64 %n) {
; CHECK-LABEL: @smax_idx_not_vec_1(
; CHECK-NOT: vector.body:
;
entry:
br label %for.body
for.body:
%indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
%max.09 = phi i64 [ %mm, %entry ], [ %2, %for.body ]
%idx.011 = phi i64 [ %ii, %entry ], [ %spec.select7, %for.body ]
%arrayidx = getelementptr inbounds i64, ptr %a, i64 %indvars.iv
%0 = load i64, ptr %arrayidx
%arrayidx.01 = getelementptr inbounds i64, ptr %b, i64 %indvars.iv
%1 = load i64, ptr %arrayidx
%2 = tail call i64 @llvm.smax.i64(i64 %max.09, i64 %0)
%cmp1 = icmp slt i64 %max.09, %1
%spec.select7 = select i1 %cmp1, i64 %indvars.iv, i64 %idx.011
%indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
%exitcond.not = icmp eq i64 %indvars.iv.next, %n
br i1 %exitcond.not, label %exit, label %for.body
exit:
store i64 %2, ptr %res_max
ret i64 %spec.select7
}
;
; It cannot be recognized as MMI when the operand of index select is not an induction variable.
;
define i64 @smax_idx_not_vec_2(ptr nocapture readonly %a, i64 %mm, i64 %ii, ptr nocapture writeonly %res_max, i64 %n) {
; CHECK-LABEL: @smax_idx_not_vec_2(
; CHECK-NOT: vector.body:
;
entry:
br label %for.body
for.body:
%indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
%max.09 = phi i64 [ %mm, %entry ], [ %1, %for.body ]
%idx.011 = phi i64 [ %ii, %entry ], [ %spec.select7, %for.body ]
%arrayidx = getelementptr inbounds i64, ptr %a, i64 %indvars.iv
%0 = load i64, ptr %arrayidx
%1 = tail call i64 @llvm.smax.i64(i64 %max.09, i64 %0)
%cmp1 = icmp slt i64 %max.09, %0
%spec.select7 = select i1 %cmp1, i64 123, i64 %idx.011
%indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
%exitcond.not = icmp eq i64 %indvars.iv.next, %n
br i1 %exitcond.not, label %exit, label %for.body
exit:
store i64 %1, ptr %res_max
ret i64 %spec.select7
}
declare i64 @llvm.smax.i64(i64, i64)