This is an archive of the discontinued LLVM Phabricator instance.

[LV] Add tests for integer min max with index reduction pattern. (NFC)

Authored by Mel-Chen on Mar 23 2023, 6:02 AM.



The test case for signed max with index, include strict and non-strict

Diff Detail

Event Timeline

Mel-Chen created this revision.Mar 23 2023, 6:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2023, 6:02 AM
Herald added a subscriber: arphaman. · View Herald Transcript
Mel-Chen requested review of this revision.Mar 23 2023, 6:02 AM
fhahn accepted this revision.Apr 23 2023, 12:25 PM

LGTM, thanks!


this doesn't check any debug output, so maybe remove -debug-only=? If it needs to check debug output, this needs REQUIRES: asserts otherwise it will fail with assertions disabled (which removes debug-only support.


nit: remove unnecessary indvars prefix.


stray ;; at end?

This revision is now accepted and ready to land.Apr 23 2023, 12:25 PM
Mel-Chen updated this revision to Diff 517833.Apr 28 2023, 1:27 AM

Updates according to comments.

This revision was landed with ongoing or failed builds.Apr 28 2023, 5:13 AM
This revision was automatically updated to reflect the committed changes.
Mel-Chen marked 2 inline comments as done.