[clang] replaces numeric SARIF ids with heirarchical names

[cjdb]

Summary

Per §3.27.5 and §3.27.7, the rule.id and ruleId properties need to
be heirarchical names (this is only a requirement of rule.id, but they
need to match when both are present). We've been using the enum values
for these properties up until now, but that's neither conforming nor
stable, so we've changed it to a dotted version of the enum identifiers
(which are substantially more stable than their numeric values).

Fixes #61597.
Depends on D145178.

[cjdb]

swaps commits to see if that fixes CI

[cjdb]

rebasing continues

[cjdb]

I think this corrects everything.

[denik]

clang/lib/Basic/DiagnosticIDs.cpp

103

As of now it's 4600 strings, around 150k characters. Doesn't look bad but I think it should be mentioned in the change message because it affects all diagnostic.

clang/lib/Frontend/SARIFDiagnostic.cpp

51–52

§3.5.4 says that the hierarchical strings are separated by "/".

But more generally, are diagnostic names really fall under "hierarchical" definition?
Words between underscores should be treated as components. And $3.27.5 says that the leading components have to be the identifier of the rule.
In some cases they look like valid components, e.g. err_access, err_access_dtor, err_access_dtor_exception.
But in cases like err_cannot_open_file neither of the leading components exists.

Theoretically we could use groups as the leading component for warnings for example. For errors the leading components are probably not even necessary, since if I understood correctly they are needed to suppress subsets of violations on the SARIF consumer side.
Or we just could keep the names with underscores as is. WDYT?

[cjdb]

clang/lib/Frontend/SARIFDiagnostic.cpp

51–52

I think in light of what you've said, changing back to underscores is probably best.

[vaibhav.y]

clang/lib/Frontend/SARIFDiagnostic.cpp

51–52

But more generally, are diagnostic names really fall under "hierarchical" definition?

I have the same concern, but this is okay for a first pass as a "flat hierarchy" :)

If we want a deeper structure, we'll need some extra metadata in DiagnosticSemaKinds.td's Error<...> to add cluster names as a follow up to this.

WDYT about something like clang/visibility/err_access or clang/syntax/err_stmtexpr_file_scope.

Alternatively: we could draw from the c++ standard structure: https://eel.is/c++draft/basic.def.odr#term.odr.use and say the error code for an ODR violation could be clang/basic/def/odr, again I'm unsure how well this meshes with clang's diagnostic model.

[Endill]

clang/lib/Frontend/SARIFDiagnostic.cpp

51–52

Alternatively: we could draw from the c++ standard structure: https://eel.is/c++draft/basic.def.odr#term.odr.use and say the error code for an ODR violation could be clang/basic/def/odr, again I'm unsure how well this meshes with clang's diagnostic model.

The only reliable thing there are stable clause names like [namespace.udecl], because there are precedents of them being rearranged in the table of contents (1, 2). We've got bitten by that in C++ conformance tests, which use table of contents for directory hierarchy.

[cjdb]

clang/lib/Frontend/SARIFDiagnostic.cpp

51–52

WDYT about something like clang/visibility/err_access or clang/syntax/err_stmtexpr_file_scope.

I think this might work!

Alternatively: we could draw from the c++ standard structure: https://eel.is/c++draft/basic.def.odr#term.odr.use and say the error code for an ODR violation could be clang/basic/def/odr, again I'm unsure how well this meshes with clang's diagnostic model.

The only reliable thing there are stable clause names like [namespace.udecl], because there are precedents of them being rearranged in the table of contents (1, 2). We've got bitten by that in C++ conformance tests, which use table of contents for directory hierarchy.

Right. Given that section names aren't actually stable, relying on those would be brittle at best.

[aaron.ballman]

My primary concern with this is that we're calling these stable IDs -- they're not really stable IDs, they're internal implementation details that we change from time to time. So what happens when we rename ext_foo_bar into warn_foo_bar as far as SARIF is concerned? Does it matter, or are we setting some tools up for problems because they'll want to map between the old name and the new name if they're the "same diagnostic" as before?

clang/include/clang/Basic/Diagnostic.h

  * Represents a diagnostic in a form that can be retained until its
  * corresponding source manager is destroyed.
  */
 class StoredDiagnostic {
   unsigned ID;
   DiagnosticsEngine::Level Level;
   FullSourceLoc Loc;
   std::string Message;
+  std::string StableName;
   std::vector<CharSourceRange> Ranges;
   std::vector<FixItHint> FixIts;
 
 public:
   StoredDiagnostic() = default;
   StoredDiagnostic(DiagnosticsEngine::Level Level, const Diagnostic &Info);
   StoredDiagnostic(DiagnosticsEngine::Level Level, unsigned ID,
-                   StringRef Message);
+                   StringRef Message, StringRef StableName);
   StoredDiagnostic(DiagnosticsEngine::Level Level, unsigned ID,
-                   StringRef Message, FullSourceLoc Loc,
+                   StringRef Message, StringRef StableName, FullSourceLoc Loc,
                    ArrayRef<CharSourceRange> Ranges,
                    ArrayRef<FixItHint> Fixits);
 
   /// Evaluates true when this object stores a diagnostic.
   explicit operator bool() const { return !Message.empty(); }
 
   unsigned getID() const { return ID; }
   DiagnosticsEngine::Level getLevel() const { return Level; }
   const FullSourceLoc &getLocation() const { return Loc; }
   StringRef getMessage() const { return Message; }
+  StringRef getStableName() const { return StableName; }
 
   void setLocation(FullSourceLoc Loc) { this->Loc = Loc; }
 
   using range_iterator = std::vector<CharSourceRange>::const_iterator;
 
   range_iterator range_begin() const { return Ranges.begin(); }
   range_iterator range_end() const { return Ranges.end(); }
   unsigned range_size() const { return Ranges.size(); }

clang/include/clang/Basic/DiagnosticIDs.h

public:
 
   //===--------------------------------------------------------------------===//
   // Diagnostic classification and reporting interfaces.
   //
 
   /// Given a diagnostic ID, return a description of the issue.
   StringRef getDescription(unsigned DiagID) const;
 
+  /// Given a diagnostic ID, return its stable name
+  StringRef getStableName(unsigned DiagID) const;
+
   /// Return true if the unmapped diagnostic levelof the specified
   /// diagnostic ID is a Warning or Extension.
   ///
   /// This only works on builtin diagnostics, not custom ones, and is not
   /// legal to call on NOTEs.
   static bool isBuiltinWarningOrExtension(unsigned DiagID);
 
   /// Return true if the specified diagnostic is mapped to errors by

clang/include/clang/Frontend/ASTUnit.h

struct StandaloneFixIt {
     bool BeforePreviousInsertions;
   };
 
   struct StandaloneDiagnostic {
     unsigned ID;
     DiagnosticsEngine::Level Level;
     std::string Message;
     std::string Filename;
+    std::string StableName;
     unsigned LocOffset;
     std::vector<std::pair<unsigned, unsigned>> Ranges;
     std::vector<StandaloneFixIt> FixIts;
   };
 
 private:
   std::shared_ptr<LangOptions>            LangOpts;
   IntrusiveRefCntPtr<DiagnosticsEngine>   Diagnostics;

clang/lib/Basic/Diagnostic.cpp

else
                                         (intptr_t)getArgStdStr(ArgNo).c_str()));
   }
 
   // Append the type tree to the end of the diagnostics.
   OutStr.append(Tree.begin(), Tree.end());
 }
 
 StoredDiagnostic::StoredDiagnostic(DiagnosticsEngine::Level Level, unsigned ID,
-                                   StringRef Message)
-    : ID(ID), Level(Level), Message(Message) {}
+                                   StringRef Message, StringRef StableName)
+    : ID(ID), Level(Level), Message(Message), StableName(StableName) {}
 
 StoredDiagnostic::StoredDiagnostic(DiagnosticsEngine::Level Level,
                                    const Diagnostic &Info)
     : ID(Info.getID()), Level(Level) {
   assert((Info.getLocation().isInvalid() || Info.hasSourceManager()) &&
        "Valid source location without setting a source manager for diagnostic");
   if (Info.getLocation().isValid())
     Loc = FullSourceLoc(Info.getLocation(), Info.getSourceManager());
   SmallString<64> Message;
   Info.FormatDiagnostic(Message);
   this->Message.assign(Message.begin(), Message.end());
   this->Ranges.assign(Info.getRanges().begin(), Info.getRanges().end());
   this->FixIts.assign(Info.getFixItHints().begin(), Info.getFixItHints().end());
 }
 
 StoredDiagnostic::StoredDiagnostic(DiagnosticsEngine::Level Level, unsigned ID,
-                                   StringRef Message, FullSourceLoc Loc,
+                                   StringRef Message, StringRef StableName,
+                                   FullSourceLoc Loc,
                                    ArrayRef<CharSourceRange> Ranges,
                                    ArrayRef<FixItHint> FixIts)
-    : ID(ID), Level(Level), Loc(Loc), Message(Message),
-      Ranges(Ranges.begin(), Ranges.end()), FixIts(FixIts.begin(), FixIts.end())
-{
-}
+    : ID(ID), Level(Level), Loc(Loc), Message(Message), StableName(StableName),
+      Ranges(Ranges.begin(), Ranges.end()),
+      FixIts(FixIts.begin(), FixIts.end()) {}
 
 llvm::raw_ostream &clang::operator<<(llvm::raw_ostream &OS,
                                      const StoredDiagnostic &SD) {
   if (SD.getLocation().hasManager())
     OS << SD.getLocation().printToString(SD.getLocation().getManager()) << ": ";
   OS << SD.getMessage();
   return OS;
 }

clang/lib/Basic/DiagnosticIDs.cpp

 #include "clang/Basic/DiagnosticCrossTUKinds.inc"
 #include "clang/Basic/DiagnosticSemaKinds.inc"
 #include "clang/Basic/DiagnosticAnalysisKinds.inc"
 #include "clang/Basic/DiagnosticRefactoringKinds.inc"
   // clang-format on
 #undef DIAG
 };
 
+// Stable names
+const char *const StaticDiagInfoStableNames[] = {
+#define DIAG(ENUM, CLASS, DEFAULT_SEVERITY, DESC, GROUP, SFINAE, NOWERROR,     \
+             SHOWINSYSHEADER, SHOWINSYSMACRO, DEFERRABLE, CATEGORY)            \
+  #ENUM,
+// clang-format off
+#include "clang/Basic/DiagnosticCommonKinds.inc"
+#include "clang/Basic/DiagnosticDriverKinds.inc"
+#include "clang/Basic/DiagnosticFrontendKinds.inc"
+#include "clang/Basic/DiagnosticSerializationKinds.inc"
+#include "clang/Basic/DiagnosticLexKinds.inc"
+#include "clang/Basic/DiagnosticParseKinds.inc"
+#include "clang/Basic/DiagnosticASTKinds.inc"
+#include "clang/Basic/DiagnosticCommentKinds.inc"
+#include "clang/Basic/DiagnosticCrossTUKinds.inc"
+#include "clang/Basic/DiagnosticSemaKinds.inc"
+#include "clang/Basic/DiagnosticAnalysisKinds.inc"
+#include "clang/Basic/DiagnosticRefactoringKinds.inc"
+// clang-format on
+#undef DIAG
+};
+
 // Diagnostic classes.
 enum {
   CLASS_NOTE       = 0x01,
   CLASS_REMARK     = 0x02,
   CLASS_WARNING    = 0x03,
   CLASS_EXTENSION  = 0x04,
   CLASS_ERROR      = 0x05
 };
struct StaticDiagInfoRec {
 
   StringRef getDescription() const {
     size_t MyIndex = this - &StaticDiagInfo[0];
     uint32_t StringOffset = StaticDiagInfoDescriptionOffsets[MyIndex];
     const char* Table = reinterpret_cast<const char*>(&StaticDiagInfoDescriptions);
     return StringRef(&Table[StringOffset], DescriptionLen);
   }
 
+  StringRef getStableName() const {
+    size_t MyIndex = this - &StaticDiagInfo[0];
+    return StringRef(StaticDiagInfoStableNames[MyIndex]);
+  }
+
   diag::Flavor getFlavor() const {
     return Class == CLASS_REMARK ? diag::Flavor::Remark
                                  : diag::Flavor::WarningOrError;
   }
 
   bool operator<(const StaticDiagInfoRec &RHS) const {
     return DiagID < RHS.DiagID;
   }
public:
       /// getDescription - Return the description of the specified custom
       /// diagnostic.
       StringRef getDescription(unsigned DiagID) const {
         assert(DiagID - DIAG_UPPER_LIMIT < DiagInfo.size() &&
                "Invalid diagnostic ID");
         return DiagInfo[DiagID-DIAG_UPPER_LIMIT].second;
       }
 
+      StringRef getStableName(unsigned DiagID) const {
+        assert(DiagID - DIAG_UPPER_LIMIT < DiagInfo.size() &&
+               "Invalid diagnostic ID");
+        return DiagInfo[DiagID - DIAG_UPPER_LIMIT].second;
+      }
+
       /// getLevel - Return the level of the specified custom diagnostic.
       DiagnosticIDs::Level getLevel(unsigned DiagID) const {
         assert(DiagID - DIAG_UPPER_LIMIT < DiagInfo.size() &&
                "Invalid diagnostic ID");
         return DiagInfo[DiagID-DIAG_UPPER_LIMIT].first;
       }
 
       unsigned getOrCreateDiagID(DiagnosticIDs::Level L, StringRef Message,

 /// issue.
 StringRef DiagnosticIDs::getDescription(unsigned DiagID) const {
   if (const StaticDiagInfoRec *Info = GetDiagInfo(DiagID))
     return Info->getDescription();
   assert(CustomDiagInfo && "Invalid CustomDiagInfo");
   return CustomDiagInfo->getDescription(DiagID);
 }
 
+StringRef DiagnosticIDs::getStableName(unsigned DiagID) const {
+  if (const StaticDiagInfoRec *Info = GetDiagInfo(DiagID))
+    return Info->getStableName();
+  assert(CustomDiagInfo && "Invalid CustomDiagInfo");
+  return CustomDiagInfo->getStableName(DiagID);
+}
+
 static DiagnosticIDs::Level toLevel(diag::Severity SV) {
   switch (SV) {
   case diag::Severity::Ignored:
     return DiagnosticIDs::Ignored;
   case diag::Severity::Remark:
     return DiagnosticIDs::Remark;
   case diag::Severity::Warning:
     return DiagnosticIDs::Warning;

clang/lib/Frontend/ASTUnit.cpp

for (const auto &FixIt : SD.FixIts) {
       FixIts.push_back(FixItHint());
       FixItHint &FH = FixIts.back();
       FH.CodeToInsert = FixIt.CodeToInsert;
       SourceLocation BL = FileLoc.getLocWithOffset(FixIt.RemoveRange.first);
       SourceLocation EL = FileLoc.getLocWithOffset(FixIt.RemoveRange.second);
       FH.RemoveRange = CharSourceRange::getCharRange(BL, EL);
     }
 
-    Result.push_back(StoredDiagnostic(SD.Level, SD.ID,
-                                      SD.Message, Loc, Ranges, FixIts));
+    Result.push_back(StoredDiagnostic(SD.Level, SD.ID, SD.Message,
+                                      SD.StableName, Loc, Ranges, FixIts));
   }
   Result.swap(Out);
 }
 
 void ASTUnit::addFileLevelDecl(Decl *D) {
   assert(D);
 
   // We only care about local declarations.

clang/lib/Frontend/SARIFDiagnostic.cpp

void SARIFDiagnostic::emitDiagnosticMessage(
     StringRef Message, ArrayRef<clang::CharSourceRange> Ranges,
     DiagOrStoredDiag D) {
 
   const auto *Diag = D.dyn_cast<const Diagnostic *>();
 
   if (!Diag)
     return;
 
-  SarifRule Rule = SarifRule::create().setRuleId(std::to_string(Diag->getID()));
+  std::string StableName =
+      Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str();
+  std::replace(StableName.begin(), StableName.end(), '_', '.');
+  SarifRule Rule = SarifRule::create().setRuleId(StableName);
 
   Rule = addDiagnosticLevelToRule(Rule, Level);
 
   unsigned RuleIdx = Writer->createRule(Rule);
 
   SarifResult Result =
       SarifResult::create(RuleIdx).setDiagnosticMessage(Message);
 

clang/test/Frontend/sarif-diagnostics.cpp

 // SARIF:                   "startLine":12
 // SARIF:                 }
 // SARIF:               }
 // SARIF:             }
 // SARIF:           ],
 // SARIF:           "message":{
 // SARIF:             "text":"'main' must return 'int'"
 // SARIF:           },
-// SARIF:           "ruleId":"3485",
+// SARIF:           "ruleId":"err.main.returns.nonint",
 // SARIF:           "ruleIndex":0
 // SARIF:         },
 // SARIF:         {
 // SARIF:           "level":"error",
 // SARIF:           "locations":[
 // SARIF:             {
 // SARIF:               "physicalLocation":{
 // SARIF:                 "artifactLocation":{
 // SARIF:                   "index":0,
 // SARIF:                   "uri":{{"file://[^"]+/clang/test/Frontend/sarif-diagnostics.cpp"}}
 // SARIF:                 },
 // SARIF:                 "region":{
 // SARIF:                   "endColumn":11,
 // SARIF:                   "startColumn":11,
 // SARIF:                   "startLine":13
 // SARIF:                 }
 // SARIF:               }
 // SARIF:             }
 // SARIF:           ],
 // SARIF:           "message":{
 // SARIF:             "text":"use of undeclared identifier 'hello'"
 // SARIF:           },
-// SARIF:           "ruleId":"4632",
+// SARIF:           "ruleId":"err.undeclared.var.use",
 // SARIF:           "ruleIndex":1
 // SARIF:         },
 // SARIF:         {
 // SARIF:           "level":"error",
 // SARIF:           "locations":[
 // SARIF:             {
 // SARIF:               "physicalLocation":{
 // SARIF:                 "artifactLocation":{
 // SARIF:                   "index":0,
 // SARIF:                   "uri":{{"file://[^"]+/clang/test/Frontend/sarif-diagnostics.cpp"}}
 // SARIF:                 },
 // SARIF:                 "region":{
 // SARIF:                   "endColumn":17,
 // SARIF:                   "startColumn":17,
 // SARIF:                   "startLine":15
 // SARIF:                 }
 // SARIF:               }
 // SARIF:             }
 // SARIF:           ],
 // SARIF:           "message":{
 // SARIF:             "text":"invalid digit 'a' in decimal constant"
 // SARIF:           },
-// SARIF:           "ruleId":"898",
+// SARIF:           "ruleId":"err.invalid.digit",
 // SARIF:           "ruleIndex":2
 // SARIF:         },
 // SARIF:         {
 // SARIF:           "level":"warning",
 // SARIF:           "locations":[
 // SARIF:             {
 // SARIF:               "physicalLocation":{
 // SARIF:                 "artifactLocation":{
 // SARIF:                   "index":0,
 // SARIF:                   "uri":{{"file://[^"]+clang/test/Frontend/sarif-diagnostics.cpp"}}
 // SARIF:                 },
 // SARIF:                 "region":{
 // SARIF:                   "endColumn":5,
 // SARIF:                   "startColumn":5,
 // SARIF:                   "startLine":19
 // SARIF:                 }
 // SARIF:               }
 // SARIF:             }
 // SARIF:           ],
 // SARIF:           "message":{
 // SARIF:             "text":"misleading indentation; statement is not part of the previous 'if'"
 // SARIF:           },
-// SARIF:           "ruleId":"1826",
+// SARIF:           "ruleId":"warn.misleading.indentation",
 // SARIF:           "ruleIndex":3
 // SARIF:         },
 // SARIF:         {
 // SARIF:           "level":"note",
 // SARIF:           "locations":[
 // SARIF:             {
 // SARIF:               "physicalLocation":{
 // SARIF:                 "artifactLocation":{
 // SARIF:                   "index":0,
 // SARIF:                   "uri":{{"file://[^"]+/clang/test/Frontend/sarif-diagnostics.cpp"}}
 // SARIF:                 },
 // SARIF:                 "region":{
 // SARIF:                   "endColumn":3,
 // SARIF:                   "startColumn":3,
 // SARIF:                   "startLine":17
 // SARIF:                 }
 // SARIF:               }
 // SARIF:             }
 // SARIF:           ],
 // SARIF:           "message":{
 // SARIF:             "text":"previous statement is here"
 // SARIF:           },
-// SARIF:           "ruleId":"1746",
+// SARIF:           "ruleId":"note.previous.statement",
 // SARIF:           "ruleIndex":4
 // SARIF:         },
 // SARIF:         {
 // SARIF:           "level":"warning",
 // SARIF:           "locations":[
 // SARIF:             {
 // SARIF:               "physicalLocation":{
 // SARIF:                 "artifactLocation":{
 // SARIF:                   "index":0,
 // SARIF:                   "uri":{{"file://[^"]+/clang/test/Frontend/sarif-diagnostics.cpp"}}
 // SARIF:                 },
 // SARIF:                 "region":{
 // SARIF:                   "endColumn":10,
 // SARIF:                   "startColumn":10,
 // SARIF:                   "startLine":18
 // SARIF:                 }
 // SARIF:               }
 // SARIF:             }
 // SARIF:           ],
 // SARIF:           "message":{
 // SARIF:             "text":"unused variable 'Yes'"
 // SARIF:           },
-// SARIF:           "ruleId":"6593",
+// SARIF:           "ruleId":"warn.unused.variable",
 // SARIF:           "ruleIndex":5
 // SARIF:         },
 // SARIF:         {
 // SARIF:           "level":"error",
 // SARIF:           "locations":[
 // SARIF:             {
 // SARIF:               "physicalLocation":{
 // SARIF:                 "artifactLocation":{
 // SARIF:                   "index":0,
 // SARIF:                   "uri":{{"file://[^"]+/clang/test/Frontend/sarif-diagnostics.cpp"}}
 // SARIF:                 },
 // SARIF:                 "region":{
 // SARIF:                   "endColumn":12,
 // SARIF:                   "startColumn":12,
 // SARIF:                   "startLine":21
 // SARIF:                 }
 // SARIF:               }
 // SARIF:             }
 // SARIF:           ],
 // SARIF:           "message":{
 // SARIF:             "text":"use of undeclared identifier 'hi'"
 // SARIF:           },
-// SARIF:           "ruleId":"4632",
+// SARIF:           "ruleId":"err.undeclared.var.use",
 // SARIF:           "ruleIndex":6
 // SARIF:         },
 // SARIF:         {
 // SARIF:           "level":"error",
 // SARIF:           "locations":[
 // SARIF:             {
 // SARIF:               "physicalLocation":{
 // SARIF:                 "artifactLocation":{
 // SARIF:                   "index":0,
 // SARIF:                   "uri":{{"file://[^"]+/clang/test/Frontend/sarif-diagnostics.cpp"}}
 // SARIF:                 },
 // SARIF:                 "region":{
 // SARIF:                   "endColumn":1,
 // SARIF:                   "startColumn":1,
 // SARIF:                   "startLine":23
 // SARIF:                 }
 // SARIF:               }
 // SARIF:             }
 // SARIF:           ],
 // SARIF:           "message":{
 // SARIF:             "text":"extraneous closing brace ('}')"
 // SARIF:           },
-// SARIF:           "ruleId":"1400",
+// SARIF:           "ruleId":"err.extraneous.closing.brace",
 // SARIF:           "ruleIndex":7
 // SARIF:         },
 // SARIF:         {
 // SARIF:           "level":"error",
 // SARIF:           "locations":[
 // SARIF:             {
 // SARIF:               "physicalLocation":{
 // SARIF:                 "artifactLocation":{

 // SARIF:                   "startLine":27
 // SARIF:                 }
 // SARIF:               }
 // SARIF:             }
 // SARIF:           ],
 // SARIF:           "message":{
 // SARIF:             "text":"invalid operands to binary expression ('t1' and 't1')"
 // SARIF:           },
-// SARIF:           "ruleId":"4567",
+// SARIF:           "ruleId":"err.typecheck.invalid.operands",
 // SARIF:           "ruleIndex":8
 // SARIF:         }
 // SARIF:       ],
 // SARIF:       "tool":{
 // SARIF:         "driver":{
 // SARIF:           "fullName":"",
 // SARIF:           "informationUri":"https://clang.llvm.org/docs/UsersManual.html",
 // SARIF:           "language":"en-US",
 // SARIF:           "name":"clang",
 // SARIF:           "rules":[
 // SARIF:             {
 // SARIF:               "defaultConfiguration":{
 // SARIF:                 "enabled":true,
 // SARIF:                 "level":"error",
 // SARIF:                 "rank":50
 // SARIF:               },
 // SARIF:               "fullDescription":{
 // SARIF:                 "text":""
 // SARIF:               },
-// SARIF:               "id":"3485",
+// SARIF:               "id":"err.main.returns.nonint",
 // SARIF:               "name":""
 // SARIF:             },
 // SARIF:             {
 // SARIF:               "defaultConfiguration":{
 // SARIF:                 "enabled":true,
 // SARIF:                 "level":"error",
 // SARIF:                 "rank":50
 // SARIF:               },
 // SARIF:               "fullDescription":{
 // SARIF:                 "text":""
 // SARIF:               },
-// SARIF:               "id":"4632",
+// SARIF:               "id":"err.undeclared.var.use",
 // SARIF:               "name":""
 // SARIF:             },
 // SARIF:             {
 // SARIF:               "defaultConfiguration":{
 // SARIF:                 "enabled":true,
 // SARIF:                 "level":"error",
 // SARIF:                 "rank":50
 // SARIF:               },
 // SARIF:               "fullDescription":{
 // SARIF:                 "text":""
 // SARIF:               },
-// SARIF:               "id":"898",
+// SARIF:               "id":"err.invalid.digit",
 // SARIF:               "name":""
 // SARIF:             },
 // SARIF:             {
 // SARIF:               "defaultConfiguration":{
 // SARIF:                 "enabled":true,
 // SARIF:                 "level":"warning",
 // SARIF:                 "rank":-1
 // SARIF:               },
 // SARIF:               "fullDescription":{
 // SARIF:                 "text":""
 // SARIF:               },
-// SARIF:               "id":"1826",
+// SARIF:               "id":"warn.misleading.indentation",
 // SARIF:               "name":""
 // SARIF:             },
 // SARIF:             {
 // SARIF:               "defaultConfiguration":{
 // SARIF:                 "enabled":true,
 // SARIF:                 "level":"note",
 // SARIF:                 "rank":-1
 // SARIF:               },
 // SARIF:               "fullDescription":{
 // SARIF:                 "text":""
 // SARIF:               },
-// SARIF:               "id":"1746",
+// SARIF:               "id":"note.previous.statement",
 // SARIF:               "name":""
 // SARIF:             },
 // SARIF:             {
 // SARIF:               "defaultConfiguration":{
 // SARIF:                 "enabled":true,
 // SARIF:                 "level":"warning",
 // SARIF:                 "rank":-1
 // SARIF:               },
 // SARIF:               "fullDescription":{
 // SARIF:                 "text":""
 // SARIF:               },
-// SARIF:               "id":"6593",
+// SARIF:               "id":"warn.unused.variable",
 // SARIF:               "name":""
 // SARIF:             },
 // SARIF:             {
 // SARIF:               "defaultConfiguration":{
 // SARIF:                 "enabled":true,
 // SARIF:                 "level":"error",
 // SARIF:                 "rank":50
 // SARIF:               },
 // SARIF:               "fullDescription":{
 // SARIF:                 "text":""
 // SARIF:               },
-// SARIF:               "id":"4632",
+// SARIF:               "id":"err.undeclared.var.use",
 // SARIF:               "name":""
 // SARIF:             },
 // SARIF:             {
 // SARIF:               "defaultConfiguration":{
 // SARIF:                 "enabled":true,
 // SARIF:                 "level":"error",
 // SARIF:                 "rank":50
 // SARIF:               },
 // SARIF:               "fullDescription":{
 // SARIF:                 "text":""
 // SARIF:               },
-// SARIF:               "id":"1400",
+// SARIF:               "id":"err.extraneous.closing.brace",
 // SARIF:               "name":""
 // SARIF:             },
 // SARIF:             {
 // SARIF:               "defaultConfiguration":{
 // SARIF:                 "enabled":true,
 // SARIF:                 "level":"error",
 // SARIF:                 "rank":50
 // SARIF:               },
 // SARIF:               "fullDescription":{
 // SARIF:                 "text":""
 // SARIF:               },
-// SARIF:               "id":"4567",
+// SARIF:               "id":"err.typecheck.invalid.operands",
 // SARIF:               "name":""
 // SARIF:             }
 // SARIF:           ],
 // SARIF:           "version":"17.0.0"
 // SARIF:         }
 // SARIF:       }
 // SARIF:     }
 // SARIF:   ],
 // SARIF:   "version":"2.1.0"
 // SARIF: }
 // STDERR: 2 warnings and 6 errors generated.