workflows/release-tasks: Upload lit releases to pypi

[kwk]

LGTM except that I would publish to TestPyPi first. See suggestion.

.github/workflows/release-tasks.yml

96–99

I suggest to first try publishing to https://test.pypi.org/ and only if that works, use the official pypi.

[thieta]

Does lit have any test suite? In that case, I suggest the tests should be executed before uploading.

llvm/utils/lit/lit/__init__.py

6 ↗

(On Diff #506817)

Not sure I love this change. If a user builds a lit version locally, it should still include the dev suffix. Maybe we could substitute this or something when building the release?

[kwk]

In D146491#4280294, @thieta wrote:

Does lit have any test suite? In that case, I suggest the tests should be executed before uploading.

Good point. lit can be tested with: python3 lit.py tests

[kwk]

This comment was removed by kwk.

.github/workflows/release-tasks.yml

86–89

This should do the trick.

[kwk]

.github/workflows/release-tasks.yml

88

This should do the trick. I missed entering the directory in my first suggestion.

[tstellar]

llvm/utils/lit/lit/__init__.py

6 ↗

(On Diff #506817)

This was not meant to be part of the patch, I will remove it. There is code in the GitHub action that strips out the 'dev' before uploading.

[tstellar]

• Do some testing before uploading.
• Remove accidental change to __init__.py.

[thieta]

LGTM

[kwk]

Looks much better now. Thank you for applying my suggestions @tstellar ! As usual I hope the github action runs and is valid YAML. There's just one more thing where I need confirmation on: Have you tried running the Upload lit TestPyPI step? I've done releases to pypi and test.pypi in the recent past and I'm nearly 100% sure that you need a second API token for this. Here you're using LLVM_LIT_PYPI_API_TOKEN both, for the Upload lit TestPyPI step as well as the Upload lit.

.github/workflows/release-tasks.yml

101

104

I'm pretty sure you need need a different token for this than for the final upload to pypi. Try to log in to test.pypi.org and see for yourself.

107

[tstellar]

Address review comments.

[kwk]

LGTM. Thank you!

.github/workflows/release-tasks.yml

steps:
           mkdir -p ../www-releases/${{ steps.validate-tag.outputs.release-version }}
           mv ./docs-build/html-export/* ../www-releases/${{ steps.validate-tag.outputs.release-version }}
           cd ../www-releases
           git add ${{ steps.validate-tag.outputs.release-version }}
           git config user.email "[e-mail]"
           git config user.name "llvmbot"
           git commit -a -m "Add ${{ steps.validate-tag.outputs.release-version }} documentation"
           git push https://${{ secrets.WWW_RELEASES_TOKEN }}@github.com/${{ github.repository_owner }}/www-releases main:main
+
+  release-lit:
+    runs-on: ubuntu-latest
+    if: github.repository == 'llvm/llvm-project'
+    steps:
+      - name: Checkout LLVM
+        uses: actions/checkout@v3
+
+      - name: Install dependencies
+        run: apt-get install -y python3-setuptools
+
+      - name: Test lit
+        run: |
+          cd llvm/utils/lit
+          python3 lit.py tests
+
+      - name: Package lit
+        run: |
+          cd llvm/utils/lit
+          # Remove 'dev' suffix from lit version.
+          sed -i "s/ + 'dev'//g" lit/__init__.py
+          python3 setup.py sdist
+
+      - name: Upload lit to test.pypi.org
+        uses: pypa/gh-action-pypi-publish@release/v1
+        with:
+          password: ${{ secrets.LLVM_LIT_TEST_PYPI_API_TOKEN }}
+          repository-url: https://test.pypi.org/legacy/
+
+      - name: Upload lit to pypi.org
+        uses: pypa/gh-action-pypi-publish@release/v1
+        with:
+          password: ${{ secrets.LLVM_LIT_PYPI_API_TOKEN }}